Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): add SaaS git providers #984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grahamhar
Copy link

Adding in GitHub, BitBucket and GitLab as some of the commonly used git SaaS providers

@gabriel-tessier
Copy link
Collaborator

@grahamhar
Thanks for the PR actually the icons of your proposal are already registered here:

https://diagrams.mingrammer.com/docs/nodes/onprem#onpremvcs

But Bit bucket is not in the list, if you update your PR and add it in On Prem vcs, your PR can be merged.

@gabriel-tessier gabriel-tessier added the area/provider/onprem On-Premise provider label Nov 20, 2024
@grahamhar
Copy link
Author

@gabriel-tessier thanks for the review and sorry I didn't spot some of these were already in a different section.

I have moved as suggested but when I ran autogen.sh it looks like in previous PRs there may have been some manual changes as a few other changes have been picked up, I added them to my change let me know if if you want me to remove them.

@gabriel-tessier
Copy link
Collaborator

@grahamhar

Tanks for the changes, about the files from autogen you can remove them, include only the change you made.
Just 2 changes:

I will add the changes in the review to make more easy for other reviewer to validate.

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove not concerned files from autgen
  • Resize the icon to min 256
  • Change Icon background to transparent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/onprem On-Premise provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants