Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluate not equal to bug #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bprucha
Copy link

@bprucha bprucha commented Apr 4, 2024

When the first operand of a comparison evaluates to a Double, Int, or DateTime, if the second operand can't be parsed to the same datatype the evaluation automatically defaults to false regardless of the comparison. The evaluation should evaluate to true when the comparison is a not equals comparison.

Add testing for null to sample Word document

Add test cases checking for not equal bug
@shps951023
Copy link
Member

@bprucha Good day, Could you resolve the conflicts by following command?

Step 1: From your project repository, check out a new branch and test the changes.

git checkout -b bprucha-evaluate-not-equal main
git pull https://github.com/bprucha/MiniWord.git evaluate-not-equal
Step 2: Merge the changes and update on GitHub.

git checkout main
git merge --no-ff bprucha-evaluate-not-equal
git push origin main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants