Add rewrite rule to open HN comments w/ iOS apps #2078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my use case: I use
hnrss.org
as a feed fornews.ycombinator.com
, which returns entries as follows:When browsing from iPhone/iPad, clicking the "Comments URL" link opens Safari, instead of HN-specific apps (HACK, for example, or Opener for a more generic solution).
This PR adds two rewrite rules that add a "deep-link" to open the content directly in the app, as follows (the screenshot shows both rewrites applied):
NOTEs:
hack://
oropener://
scheme.Do you follow the guidelines?