fix: feed icon from xml ignored during force refresh #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe565
changed the title
gabe565
force-pushed
the
fix-feed-icon-ignored
branch
from
a2360fc
to
ff4c4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2871 was a huge improvement to the handling of feed icons, but I've found a bug. When force refreshing, the icon defined in a feed's XML is ignored. This is because the icon URL is not persisted, resulting in
originalFeed.IconURLalways being an empty string. This PR fixes this by assigning the value fromupdatedFeed.IconURLbefore refreshing the icon.Do you follow the guidelines?