Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing file extension to import #1336

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

Azlond
Copy link
Contributor

@Azlond Azlond commented Aug 22, 2024

The type import of PostPolicyResult in src/internal/client.ts is missing its file extension.

This can cause issues with projects requiring file extensions on import paths:

node_modules/minio/dist/esm/internal/client.d.mts:11:39 - error TS2307: Cannot find module '../minio' or its corresponding type declarations.

11 import type { PostPolicyResult } from '../minio';
                                         ~~~~~~~~~~


Found 1 error in node_modules/minio/dist/esm/internal/client.d.mts:11

I've added a .ts file extension similar to the import of xml-parser.ts, which also only exists as .js-file

@kaankabalak kaankabalak merged commit fe4d95f into minio:master Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants