SDIT-2021 Cater for retries to the mapping creation by performing an upsert #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehalmamoj
commented
Oct 30, 2024
Comment on lines
+81
to
+84
| @PutMapping("/migration") | ||
| @Operation( | ||
| summary = "Creates or updates a prison person migration mapping", | ||
| description = "Creates or updates a mapping between nomis prisoner numbers and prison person history ids. Requires ROLE_NOMIS_PRISONPERSON", |
There was a problem hiding this comment.
When testing we found that sometimes a prisoner migration is retried despite all records being created in DPS and the mapping service. As DPS is idempotent and just overwrites the previous migration we need the same behaviour in the mapping service, hence switching to a PUT.
mikehalmamoj
commented
Oct 30, 2024
Comment on lines
+46
to
+70
| private suspend fun PrisonPersonMigrationMappingRequest.update(): PrisonPersonMigrationMapping = | ||
| template.update<PrisonPersonMigrationMapping>() | ||
| .inTable("prison_person_migration_mapping") | ||
| .matching( | ||
| query( | ||
| where("nomis_prisoner_number").`is`(nomisPrisonerNumber) | ||
| .and(where("migration_type").`is`(migrationType)) | ||
| .and(where("label").`is`(label)), | ||
| ), | ||
| ) | ||
| .apply(update("dps_ids", dpsIds.toString())) | ||
| .awaitSingle() | ||
| .let { find()!! } | ||
|
|
||
| private suspend fun PrisonPersonMigrationMappingRequest.insert(): PrisonPersonMigrationMapping = | ||
| template.insert<PrisonPersonMigrationMapping>() | ||
| .using( | ||
| PrisonPersonMigrationMapping( | ||
| nomisPrisonerNumber = nomisPrisonerNumber, | ||
| migrationType = migrationType, | ||
| dpsIds = dpsIds.toString(), | ||
| label = label, | ||
| ), | ||
| ) | ||
| .awaitSingle() |
There was a problem hiding this comment.
Spring data R2DBC still doesn't support composite entity keys so we needed another way. I thought I'd try out the template instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.