Use local black and isort option #65
Conversation
dmitchell-mintel
force-pushed
the
use_local_black_and_isort_option
branch
from
a5e8f75 to
b96788f
Compare
| .PHONY: python/black/check/docker | ||
| python/black/check/docker: | ||
| @$(DOCKER) pull alphachai/black | ||
| $(DOCKER) run -i --rm --user $$(id -u):$$(id -g) --mount type=bind,src=$$(pwd),dst=/app alphachai/black --check $(PYTHON_LINT_TARGETS) |
There was a problem hiding this comment.
We could usecytopia/black:latest which gets built regularly or I can setup mintel/black
There was a problem hiding this comment.
cytopia/black looks fine, we would need to change the workdir to /data in the script
There was a problem hiding this comment.
orrrr, we could upgrade alphachai/black to build every day :P
|
Let's put this on hold until we figure out some direction from the meeting on Friday. Regarding build-harness there's a few options for handling dependencies. 1 - Install packages locally. This actually works really well (see https://github.com/cloudposse/packages ), and essentially means you can re-use this in CI and local (via 2 - Alpine Linux Packages ( https://github.com/cloudposse/packages ) also supports ALP, which gives us another route (i.e. add the repo and apk-add). This could be bundled into a base image. 3 - Docker - either a common image bundle (which could just be the pipeline image itself), or calling out to specific docker-images (like we're doing here). There's pros and cons of each There's a couple variants of docker still, such as using |
Check for black and isort in the pipenv and use them if found