Some gui improvements #1506
Merged
Some gui improvements #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
azarovh
commented
Jan 26, 2024
azarovh
commented
- Copy transaction id
- Added validation to all input fields
- Display pool ids for delegations
- Display margin ration and cost per block for pools
azarovh
requested review from
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
iljakuklic
approved these changes
Jan 26, 2024
| @@ -360,6 +361,7 @@ impl WalletTab { | |||
| self.account_state.send_delegation_id.clear(); | |||
| Command::none() | |||
| } | |||
| WalletMessage::NoOp => Command::none(), | |||
There was a problem hiding this comment.
Why is this needed? What's the difference between sending a NoOp and not sending anything?
There was a problem hiding this comment.
There are cases where I have to send a message, like in closures with input validation: Fn(String) -> Message. So NoOp is a workaround there
There was a problem hiding this comment.
Ok. I don't have a strong opinion about this.
TheQuantumPhysicist
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.