Enable/disable scheduled reports #3871
Open
+200
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/minvws/nl-kat-coordination into feature/disable-scheduled-reports
|
ammar92
reviewed
Nov 24, 2024
| <td class="nowrap">{{ schedule.deadline_at }}</td> | ||
| <td class="nowrap"> | ||
| {% if not schedule.enabled %} | ||
| {% translate "-" %} |
There was a problem hiding this comment.
Doesn't need to be translated
| <td> | ||
| {% if report.input_oois|length == 1 %} | ||
| {% with ooi=report.input_oois.0 %} | ||
| <a href="{% ooi_url 'ooi_detail' ooi organization.code query=ooi.mandatory_fields %}">{{ ooi|human_readable }}</a> | ||
| {% endwith %} | ||
| {% else %} | ||
| {{ report.input_oois|length }} | ||
| {{ report.input_oois|length }} {% translate "objects" %} |
There was a problem hiding this comment.
Would be nice to use pluralization here:
{% blocktrans count report.input_oois as objects %}
{{ objects }} object
{% plural %}
{{ objects }} objects
{% endblocktrans %}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes it possible to disable and enable scheduled reports.
It also makes some changes in the scheduled reports table conform the new design (see ticket).
Besides this, I've created enable/disable tags that haven't been implemented as a component yet. That's why I've implemented it the same way as how it's done for the grey label ("tags-color-grey-2").
Issue link
Closes #3124
Demo
Opname.2024-11-20.161301.mp4
QA notes
Check the video for an example.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.