fix: .visually-hidden (VoiceOver on macOS) #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've done some additional testing. The issue can be reproduced with freshly reset VoiceOver settings on macOS (13.6) with Safari (16.6). This fix resolves the issue on VoiceOver macOS Safari, without negatively affecting how the caption is read by VoiceOver macOS in Firefox (117) or Chrome (117), or by Talkback on Android (13) with Firefox (118) or Chrome (117). I also haven't found a visual regression in any of the previously mentioned browsers. As such I'm happy to have this PR reviewed & merged. More testing is of course welcome. |
HeleenSG
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at addressing an issue with
.visually-hidden, using VoiceOver (Safari 16.6, macOS 13.5).The
width: 0,height: 0,max-width: 0andmax-height: 0cause VoiceOver not to read.visually-hiddenelements in some contexts, including table<caption>s.Omitting the
max-widthandmax-heightand settingwidthandheightto1pxseems to address this issue without anything becoming visible.This requires further testing.