Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SonarCloud #43

Closed
wants to merge 2 commits into from
Closed

Introduce SonarCloud #43

wants to merge 2 commits into from

Conversation

pk27734
Copy link

@pk27734 pk27734 commented Jun 17, 2024

No description provided.


- name: Static analysis with PHPStan
run: vendor/bin/phpstan analyse
run: vendor/bin/phpstan analyse --error-format=json > reports/phpstan.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be nice to keep the github phpstan report and also have the json report.
Please check this out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which report are you referring to? I don't see a comment in any other PR with a phpstan report.

Copy link
Member

@ricklambrechts ricklambrechts Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because the errors are fixed.

But see the documentation.
https://phpstan.org/user-guide/output-format

The errors are shown in the files tab if there are any but we resolve them so they are not visible anymore.

@pk27734
Copy link
Author

pk27734 commented Jun 18, 2024

This PR will be closed for now because public repos are not onboarded in Sonarcloud for now.

@pk27734 pk27734 closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants