[pull] main from elastic:main #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
## Summary Adjust tests to #161614 Split tests into smaller files to better utilize parallelization and increase the stability of tests
This PR fixes a bug in the source classifier as it is currently not identifying xml as a static file. As part of this I've also identified a TODO in the source classifier related with the evaluating order. --------- Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Coen Warmer <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Clint Andrew Hall <[email protected]> Co-authored-by: Carlos Crespo <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]>
…ck (#164060) Fixes #96534 ## Summary Fixes the bug with some popovers are not closed if their trigger buttons are clicked *Bug demos from the original issue* Inventory:  Metrics Explorer  ### How to test * Checkout the branch locally * Goto "Inventory" section * Click on "Hosts" filter * Make sure popover opens * Click on "Hosts" again * Make sure the popover closes * Check the same for "Sort by" filter * Check the same for chart "Actions" in "Metrics Explorer"
…zation and suggestions panel (#163412) ## Summary Related to #163089 Adding the first performance journey for the Lens Editor. It simulated loading existing Lens visualisation with data view having 10k fields. We collect the following metrics: - `fetchFieldsExistenceInfo` reports time it takes to fetch fields in Data Panel - `lensVisualizationRenderTime` reports both time it takes to fetch the data (`time_to_data`) and render the main visualization (`time_to_render`) - `lensSuggestionsRenderTime` reports time it takes to render suggestions panel Metrics consistency <img width="568" alt="image" src="https://github.com/elastic/kibana/assets/10977896/3384bb8e-6152-4bae-93dc-4f7f4167ed07"> Run locally with ``` node scripts/functional_tests --config x-pack/performance/journeys/many_fields_lens_editor.ts ``` Metrics will be available here https://telemetry-v2-staging.elastic.dev/s/kibana-performance/app/dashboards#/view/dd0473ac-826f-5621-9a10-25319700326e?_g=h@61c5ac8 --------- Co-authored-by: Drew Tate <[email protected]>
## Summary Added docs for total alerts per case guardrails as per #146945 | Description | Limit | Done? | Documented? | UI? | ------------- | ---- | :---: | ---- | :----: | | Total alerts per case | 1.000 | ✅ | Yes | N/A |
Makes isSystemAction field in RawConnector optional and enables `requeue_invalid_tasks` config for functional tests.
## Summary Solves: #163465 Add maintenance window banner to Rules list and Alerts list in O11y and Management. <img width="1334" alt="Screenshot 2023-08-09 at 13 03 50" src="https://github.com/elastic/kibana/assets/26089545/de0708b1-db2a-4517-91aa-a3d6b3e62b44"> <img width="1350" alt="Screenshot 2023-08-09 at 13 05 10" src="https://github.com/elastic/kibana/assets/26089545/9f7c488d-e992-4807-a60e-3c077b623b4e"> --------- Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: kibanamachine <[email protected]>
## Summary Closes #161887 Merges most of the functionality from `feat/obs-asset-manager-demo` branch. We remove implicit collection code while including: - asset collectors from signals (also include pods and containers but we don't use then directly) - source configuration code (assets or signals) - `assetAccessor` logic that determines which indices to query The change also enables ftr test suite. We'll also merge the services endpoint #160294 when approved. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Jason Rhodes <[email protected]>
## Summary Relates to: elastic/search-team#5631 Add missing configuration fields for SPO native connector. Reference to the source of truth connector configuration: https://github.com/elastic/connectors-python/blob/main/connectors/sources/sharepoint_online.py#L1143 ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
…yment (#163836) ## Summary The reputation service Policy option should be `true` by default if it is a cloud deployment. Otherwise it should be `false`. This PR corrects the default option for new policies if it is a cloud deployment. The migrated Policies should still always default to `false` (already implemented in a previous PR) New Policy with `cloud: true`  New Policy with `cloud: false`  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Fix #164148 This PR changes the target Lens formula function for the TSVB `params._interval` conversion.  ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…e when custom title is used (#164004) ## Summary This PR fixes an issue where using a custom title in the saved search embeddable creates a race condition that could result in an extra fetch being triggered. I've also created a separate PR with the same changes that runs the flaky tests 100x each to confirm this fix resolves the flakiness: #164088. Resolves #162997. Resolves #164125. ### Checklist - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] ~Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ - [ ] ~Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
## Summary As part of #161151 a [selection of component imports were made lazy](https://github.com/elastic/kibana/blob/main/x-pack/plugins/logs_shared/public/index.ts#L52) and wrapped with a [`dynamic` wrapper component](https://github.com/elastic/kibana/blob/main/x-pack/plugins/logs_shared/common/dynamic.tsx#L22). Unfortunately some of these imports did not adhere to the rules of React's `lazy` imports (needing a `default` export, no named imports etc), and the `dynamic` wrapper seems to have suppressed error information that would have been available via using `lazy` directly. Only the anomaly and categories log entry examples (in the expanded rows) were affected by this, as the stream and embeddable import from locations that were backed by a `default` export (and those top level components don't import from that particular index file lower in the hierarchy). For imports that weren't backed by a `default` I've added them, and where necessary moved components to new files if needed (since it's one `default` per file). Also open to suggestions of ways we can alter the `<dynamic />` component and maintain the error safety 🤔 ## Examples Without these changes:  Warning using `lazy` directly without the `dynamic` wrapper:  ## Testing - Check all instances render correctly (stream, embeddable uses, and ML page log entry examples).
## Summary Partially addresses #161422 Co-authored-by: Kibana Machine <[email protected]>
## Summary Partially addresses #161422
## Summary Fix credential issues for running serverless tests for APM against MKI
## Summary Removing the telemetry banner during the CCS console test will help with flakiness (allowing for more of the query result to be in the view port).
- Closes #163979 - Closes #163980 It was adding both fields too fast. 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2908
…64078) ## Summary Note: this is only the API changes, the UI element will follow. Part of #162862 Add the ability to specify a `proxy_id` on a download source. If an agent policy uses a download source with a `proxy_id`, then the proxy url will be added to the policy like so: `agent.download.proxy_url: <proxy_url>`. Test cases automated: - create a download source with a valid proxy_id - create a download source with an invalid proxy_id - update download wource proxy_id - update download_source proxy_id to null (remove proxy) - updating a download source proxy bumps all policies using that download source - removing a download source proxy bumps all policies using that download source - updating the proxy url bumps all policies using a download source with the proxy id set - deleting the proxy bumps all policies using a download source with the proxy id set to remove the proxy ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Align buildkite pipelines between ess and serverless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )