Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from elastic:main #528

Merged
merged 223 commits into from
Aug 25, 2023
Merged

[pull] main from elastic:main #528

merged 223 commits into from
Aug 25, 2023

Commits on Aug 17, 2023

  1. chore(NA): upgrade typescript-eslint packages to v5.62.0 (#164117)

    After #163895 this PR forward
    ports the typescript-eslint packages to v5.62.0.
    mistic authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0a331f1 View commit details
    Browse the repository at this point in the history
  2. [ML] Fix Trained models list crashes on browser refresh if not on pag…

    …e 1 (#164163)
    
    ## Summary
    
    Fixes #162618
    
    There was an issue with setting pagination for the EUI table before
    models are fetched. Providing a page index while the items count is 0
    caused pagination to reset with an uninitialized URL state callback.
    This PR adds a check to verify model list has been retrieved.
    
    Also, the Kibana `_stats` endpoint has been updated to provide a `size`
    parameter.
    darnautov authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    24baf38 View commit details
    Browse the repository at this point in the history
  3. [Cloud Security] removed beta label from tty setting (#164122)

    ## Summary
    
    Removes a beta label from the "terminal output" feature in the linux
    settings for the endpoint integration. The beta tag was previously
    removed from the TTY player itself, but this spot was missed.
    
    Also, this PR changes codeowners of session_view, kubernetes_security
    and cloud_defend plugins to the **kibana-cloud-security-posture** team
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    mitodrummer and kibanamachine authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4ce5464 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1ab6a4c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8ffbc71 View commit details
    Browse the repository at this point in the history
  6. [OnWeek][Discover] Allow to fetch more documents on Discover page (#1…

    …63784)
    
    > [!WARNING]
    > Sorry, I had to recreate the PR
    #157241
    > Please submit your review again.
    
    - Closes #155019
    
    Per docs
    https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html
    <img width="851" alt="Screenshot 2023-05-10 at 10 25 20"
    src="https://github.com/elastic/kibana/assets/1415710/b4b9fef4-7dd8-40ed-8244-343889fc4367">
    
    
    ## Summary
    
    1. This PR improves `search_after` pagination for `date_nanos` time
    fields. `sort` value will be returned from ES as a string instead of a
    rounded and incorrect timestamp. This change allows to also simplify
    logic on Surrounding document page.
    
    Before:
    <img width="400" alt="Screenshot 2023-05-08 at 17 36 19"
    src="https://github.com/elastic/kibana/assets/1415710/fd9f45c4-5dc2-4103-83b9-8810e3a6e0df">
    
    After:
    <img width="400" alt="Screenshot 2023-05-08 at 17 37 13"
    src="https://github.com/elastic/kibana/assets/1415710/fe9090c0-2116-4f77-9a57-a96ae6b00365">
    
    2. Also in this PR we now allow users to load more documents within the
    same time range. Once the button is pressed, it will load next portion
    of documents (same "sampleSize" value will be used). Currently, we limit
    max total loaded documents to 10000.
    
    "Load more" demo:
    ![Aug-07-2023
    16-23-28](https://github.com/elastic/kibana/assets/1415710/53af9809-75cb-4b8a-8e99-d8f6d76b4981)
    
    If refresh interval is on, the button becomes disabled:
    ![Aug-07-2023
    16-24-58](https://github.com/elastic/kibana/assets/1415710/85db6144-98eb-40b5-ac88-80ea728bcd6b)
    
    Date nanos demo:
    ![Aug-07-2023
    16-34-59](https://github.com/elastic/kibana/assets/1415710/dc9fe0b1-e419-4c76-9fc6-79907b134e58)
    
    
    100x Flaky test runner
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2801
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    jughosta and kibanamachine authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    110449d View commit details
    Browse the repository at this point in the history
  7. chore(NA): update versions after v8.9.2 bump (#164193)

    This PR is a simple update of our versions file after the recent bumps.
    mistic authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c48b74a View commit details
    Browse the repository at this point in the history
  8. skip flaky suite (#164164)

    mistic committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    db1cec4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3720270 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5c1d118 View commit details
    Browse the repository at this point in the history
  11. [Automated PR] Sync cloud_defend plugin policy schema with cloud-defe…

    …nd repo (#164216)
    
    Automated by https://buildkite.com/elastic/cloud-defend/builds/2061
    
    Co-authored-by: sec_cloudnative_integrations <[email protected]>
    mitodrummer and sec_cloudnative_integrations authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7127d32 View commit details
    Browse the repository at this point in the history
  12. fix 'Download CSV' returns no data when panel has custom time range o…

    …utside timerange of global time picker (#163887)
    
    Closes #163614
    
    PR resolves issue by only adding global time filter to CSV export body
    when saved search embeddable does not have time range.
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    nreese and kibanamachine authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    53e803e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    2b3048f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5cfb693 View commit details
    Browse the repository at this point in the history
  3. [osquery] Update E2E to not install Osquery integration on the Fleet …

    …server (#164225)
    
    ## Summary
    
    Increase the stability of Osquery Cypress by stopping the installation
    of Osquery on the Fleet server and creating another Agent policy and
    enrolling another elastic agent instead
    patrykkopycinski authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    7c5392b View commit details
    Browse the repository at this point in the history
  4. unskip sample_data_apis test: dates (#164112)

    ## Summary
    
    Closes #121051
    
    I'm not seeing flakiness in the test suite after enabling all the tests.
    
    Test suite: `test/api_integration/config.js`
    Test runs:
    *
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2904
    *
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2917
    tsullivan authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f1402d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. [Search] Disable crawler on overview without ent-search (#164227)

    ## Summary
    
    This disables the crawler if Enterprise Search is not available on the
    new overview page.
    sphilipse authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8532b99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81a151e View commit details
    Browse the repository at this point in the history
  3. [Security Solution] [Endpoint] Generate empty endpoint user artifacts…

    … depending on the PLI (#163602)
    
    ## Summary
    
    Generates empty array when the PLI don't meet the requirement. It end up
    having empty fleet artifacts for those cannot be generated.
    
    It also adds new test cases
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    dasansol92 and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bc988f2 View commit details
    Browse the repository at this point in the history
  4. [HTTP] Allow for internal requests to also specify special query para…

    …m `elasticInternalOrigin` (#163796)
    
    ## Summary
    
    Closes #163678
    
    * Raise the notion of "internal" into `CoreKibanaRequest`. This enables
    us to share this with lifecycle handlers and control validation of query
    params
    * Added new `isInternalRequest` alongside `isSystemRequest` and
    `isFakeRequest`
    * Slight simplification to existing internal restriction check
    * Some other chores and minor fixes
    
    ## Test
    
    * Start ES with `yarn es serverless` and Kibana with `yarn start
    --serverless --server.restrictInternalApis=true`
    * Add the service account token to `kibana.dev.yml`:
    `elasticsearch.serviceAccountToken: <SAT>`
    * Send a request to an internal endpoint like: `curl -XPOST
    -uelastic:changeme http://localhost:5601/<base-path>/api/files/find -H
    'kbn-xsrf: foo' -H 'content-type: application/json' -d '{}'`
        * Should give you a 400 result
    * message like `{"statusCode":400,"error":"Bad Request","message":"uri
    [http://localhost:5603/api/files/find] with method [post] exists but is
    not available with the current configuration"}`
    * Send the same request, but include the query param:
    `elasticInternalOrigin=true`
       *  Should give you a 200 result
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    jloleysens and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    23d3955 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    037cbce View commit details
    Browse the repository at this point in the history
  6. [Sample data][ECommerce] Use Lens instead of TSVB (#164195)

    ## Summary
    
    Closes #164146
    
    Changes the remaining TSVB panel to a by value Lens metric.
    <img width="1652" alt="Screenshot 2023-08-17 at 6 10 06 PM"
    src="https://github.com/elastic/kibana/assets/17003240/538b4bfb-5066-4a93-a16c-4d748b29ea7c">
    
    ### How to test
    Remove the ecommerce dataset and reinstall it
    stratoula authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    00102e3 View commit details
    Browse the repository at this point in the history
  7. [APM] Remove power_user and read_only_user folders from e2e (#164242

    )
    
    We currently separate e2e tests into `power_user` tests and
    `read_only_user` tests. We often want to test different permissions
    within the same tests, so the distinction becomes a barrier rather than
    a help. This PR removed the folders and combines all tests regardless of
    which user they run as.
    sorenlouv authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ebe6b46 View commit details
    Browse the repository at this point in the history
  8. [Lens] Reduce the impact of TSDB downsample bug (#164183)

    ## Summary
    
    Fixes #163971 
    
    Reduces the impact of the ES promotion issue coming from the ES TSDB
    downsampling bug to only downsampling tests and not the entire TSDB
    suite.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    dej611 authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    dbb252b View commit details
    Browse the repository at this point in the history
  9. [DOCS] Removes 8.9.1 coming tag. (#164302)

    Removes `coming` tag from the 8.9.1 release notes.
    amyjtechwriter authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    90b6e4d View commit details
    Browse the repository at this point in the history
  10. [Dashboard] Remove clone by reference (#164108)

    Removes all clone by reference functionality on the Dashboard. This means that we no longer have any `savedObjectsClient` usage in the browser side.
    ThomThomson authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    011ae97 View commit details
    Browse the repository at this point in the history
  11. [Security Solution] File paths for Blocklist Windows and Mac should b…

    …e case insensitive (#164200)
    
    ## Summary
    
    This fixes a bug where Windows and Mac Blocklist file path entries
    should be passed as case insensitive. This is because Mac and Windows
    are caseless for most use cases.
    
    Bug ticket: #158581
    
    Here is how it will be displayed in the UI:
    <img width="1728" alt="image"
    src="https://github.com/elastic/kibana/assets/56395104/a3006397-f49e-4de0-818d-94e2de20dba3">
    
    Here are the breakdown of the artifacts after the fix:
    
    Linux:
    ```
    -------------------------------------------------------------------
    Policy:   Protect
    Manifest: 1.0.6 | v1
    Artifact: endpoint-blocklist-linux-v1
              Relative URL:   /api/fleet/artifacts/endpoint-blocklist-linux-v1/f33e6890aeced00861c26a08121dd42d2d29ba08abfeb3c065d0447e32e18640
              Encoded SHA256: a907835be40af89b8b7aa23a6efc66c01ceaa5a19622edd378139319f3ca5fa0
              Decoded SHA256: f33e6890aeced00861c26a08121dd42d2d29ba08abfeb3c065d0447e32e18640
    -------------------------------------------------------------------
    
    {
      "entries": [
        {
          "type": "simple",
          "entries": [
            {
              "field": "file.path",
              "operator": "included",
              "type": "exact_cased_any",
              "value": [
                "/opt/bin/bin.exe"
              ]
            }
          ]
        }
      ]
    }
    ```
    
    Mac:
    ```
    -------------------------------------------------------------------
    Policy:   Protect
    Manifest: 1.0.6 | v1
    Artifact: endpoint-blocklist-macos-v1
              Relative URL:   /api/fleet/artifacts/endpoint-blocklist-macos-v1/b28e7978da4314ebc2c94770e0638fc4b2270f9dc17a11d6d32b8634b1fbec0f
              Encoded SHA256: 4f3e80d688f5cae4bf6a88b0704e37909f9fa4f47fe8325b7b154cddd46a2db9
              Decoded SHA256: b28e7978da4314ebc2c94770e0638fc4b2270f9dc17a11d6d32b8634b1fbec0f
    -------------------------------------------------------------------
    
    {
      "entries": [
        {
          "type": "simple",
          "entries": [
            {
              "field": "file.path",
              "operator": "included",
              "type": "exact_caseless_any",
              "value": [
                "/opt/exe.exe"
              ]
            }
          ]
        }
    ```
    
    Windows:
    ```
    -------------------------------------------------------------------
    Policy:   Protect
    Manifest: 1.0.6 | v1
    Artifact: endpoint-blocklist-windows-v1
              Relative URL:   /api/fleet/artifacts/endpoint-blocklist-windows-v1/2a6fcc67c696ad4e29d91f8b685bff46977198cd34b9a61e8003d55b78dff6ac
              Encoded SHA256: c6e045fce97651336eeb400f0123541475b940e3aa38ce721f299585683da288
              Decoded SHA256: 2a6fcc67c696ad4e29d91f8b685bff46977198cd34b9a61e8003d55b78dff6ac
    -------------------------------------------------------------------
    
    {
      "entries": [
        {
          "type": "simple",
          "entries": [
            {
              "field": "file.path",
              "operator": "included",
              "type": "exact_caseless_any",
              "value": [
                "C:\\path\\path.exe"
              ]
            }
          ]
        }
      ]
    }
    ```
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    kevinlog and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    88bd71c View commit details
    Browse the repository at this point in the history
  12. It adds 8.10 into the .backportrc config file (#164259)

    ## Summary
    
    It adds 8.10 into the .backportrc config file
    
    Co-authored-by: Tiago Costa <[email protected]>
    patrykkopycinski and mistic authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    75d3510 View commit details
    Browse the repository at this point in the history
  13. [Security Solution] Fix value lists tests flakiness (#164253)

    **Fixes:** #164056
    
    ## Summary
    
    This PR fixes [value_lists.cy.ts](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists/value_lists.cy.ts) tests flakiness.
    
    ## The flakiness reason
    
    Value list items are processed in a bulk via bulk creation and `refresh=wait_for` is [used](https://github.com/elastic/kibana/blob/main/x-pack/plugins/lists/server/services/items/create_list_items_bulk.ts#L87). The problem it returns sometimes earlier than data is available. [Bulk API docs](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html#bulk-refresh) say the following
    
    > Only the shards that receive the bulk request will be affected by refresh. Imagine a _bulk?refresh=wait_for request with three documents in it that happen to be routed to different shards in an index with five shards. The request will only wait for those three shards to refresh. The other two shards that make up the index do not participate in the _bulk request at all.
    
    While (it seems) only one shard is used in tests but it still cause issues (approx. 1 test per 50 fails) so adding explicit index refresh helps to get rid of flakiness.
    
    ## Flaky test runner
    
    [value_lists.cy.ts (150 runs)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2924) 🟢
    maximpn authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d34c845 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    79a0a5e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5f310f7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    98a135c View commit details
    Browse the repository at this point in the history
  17. [Reporting] Adjust export type conditionals in server startup (#164232)

    ## Summary
    
    This PR cleans up how config settings are used as conditionals in the
    Reporting plugin startup phase.
    
    The existing code is correct, but it's heavily aligned to certain
    business requirements that might not be understood by a reader.
    
    The change in the PR uses simpler conditionals that are separated from
    internal business decisions. The result should be clearer readability of
    the code.
    tsullivan authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c328d2d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    c1d2834 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9cff5fc View commit details
    Browse the repository at this point in the history
  20. [APM] Swallow unhandled exceptions (#164251)

    If an unhandled error occurs, it will break the diagnostics bundle. This
    change will log errors and then swallow them.
    This should go out in 8.10 since it is already affecting users.
    sorenlouv authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    654de7b View commit details
    Browse the repository at this point in the history
  21. Removing refresh interval from session index (#164328)

    ## Summary
    
    Specifying a `refresh_interval` below 5s is no longer allowed with es
    serverless. This PR removes the explicit `refresh_interval` from the
    session index.
    
    Work done in #151800 makes
    specifying a `refresh_interval` unnecessary.
    
    ## Flaky Test Runner
    [Session Tests x50
    ea](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2932)
    🟢
    
    Co-authored-by: Kibana Machine <[email protected]>
    kc13greiner and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    19b3d50 View commit details
    Browse the repository at this point in the history
  22. [Security Solution][Detections] Fix "burning" test `detection_respons…

    …e/rule_creation/custom_query_rule.cy.ts` (#164312)
    
    ## Summary
    
    This PR fixes "burning" test
    `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule.cy.ts`
    (`'Allows a rule to be edited'`).
    
    Failing job
    https://buildkite.com/elastic/kibana-pull-request/builds/151789#018a1792-bf45-4a4e-bf54-8372468d4cfd
    
    More details in slack
    https://elastic.slack.com/archives/C056TQ5J81Y/p1692621948405779
    e40pud authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b6fcd79 View commit details
    Browse the repository at this point in the history
  23. [ResponseOps][Alerting] Unskips alerting serverless tests (#164091)

    Related to elastic/response-ops-team#124
    
    ## Summary
    
    Fixes tests that had an interval less than 1m
    doakalexi authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    03ee66c View commit details
    Browse the repository at this point in the history
  24. Failing test: Security Solution Cypress.x-pack/test/security_solution…

    …_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule·cy·ts - Custom query rules Custom detection rules deletion and edition Deletion Deletes one rule from detail page Deletes one rule from detail page #163977 (#164327)
    
    ## Summary
    
    Fixes: #163977
    Fixes: #163568
    
    These changes fix the issue with actions popover and the way we check
    whether it is closed on rule's detail page.
    
    The issue happens due to the fact that after we closed the popover we
    should be testing `should('not.exist')` instead of
    `should('not.be.visible')`.
    e40pud authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    49f9528 View commit details
    Browse the repository at this point in the history
  25. [Security Solution] [Detections] Fixes flakey exceptions read-only vi…

    …ewer cypress test (#164283)
    
    ## Summary
    
    Fixes: #162569
    Fixes: #164061
    Fixes: #164058
    Fixes: #163546
    Fixes: #162669
    
    We tried to fix the issue with this PR
    #162839 but test failed again.
    
    This is another attempt to fix it using the @jpdjere's approach where we
    disable rule's table refreshing
    (#163698).
    e40pud authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4477f64 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    dc3b486 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    0317ace View commit details
    Browse the repository at this point in the history
  28. Add indexName to data quality telemetry (#163937)

    ## Summary
    
    
    [Staging](https://telemetry-v2-staging.elastic.dev/s/securitysolution/app/r/s/1rf1f)
    
    
    
    https://github.com/elastic/kibana/assets/6295984/50d4fbbd-2ce4-4fb7-be73-e33bb242a261
    
    
    ```
    {
        "timestamp": "2023-08-15T13:39:27.513Z",
        "event_type": "Data Quality Index Checked",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "5d0d6127-4b9b-47af-8bb1-96e90fcdbb31",
            "ecsVersion": "8.6.1",
            "errorCount": 0,
            "ilmPhase": "hot",
            "indexId": "WxZsLLXbR9qeroNaFeY1wg",
            "indexName": ".internal.alerts-security.alerts-default-000001",
            "isCheckAll": true,
            "numberOfDocuments": 7834,
            "numberOfIncompatibleFields": 0,
            "numberOfIndices": 1,
            "numberOfIndicesChecked": 1,
            "sizeInBytes": 15097503,
            "timeConsumedMs": 151,
            "unallowedMappingFields": [],
            "unallowedValueFields": []
        }
    }
    
    
    {
        "timestamp": "2023-08-15T13:39:30.637Z",
        "event_type": "Data Quality Index Checked",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "5d0d6127-4b9b-47af-8bb1-96e90fcdbb31",
            "ecsVersion": "8.6.1",
            "errorCount": 0,
            "ilmPhase": "unmanaged",
            "indexId": "AoyctcRqTKG8HvUVmpuzEA",
            "indexName": "auditbeat-custom-index-1",
            "isCheckAll": true,
            "numberOfDocuments": 4,
            "numberOfIncompatibleFields": 3,
            "numberOfIndices": 1,
            "numberOfIndicesChecked": 1,
            "sizeInBytes": 28417,
            "timeConsumedMs": 69,
            "unallowedMappingFields": [
                "host.name",
                "source.ip"
            ],
            "unallowedValueFields": [
                "event.category"
            ]
        }
    }
    
    
    {
        "timestamp": "2023-08-15T13:39:33.806Z",
        "event_type": "Data Quality Index Checked",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "5d0d6127-4b9b-47af-8bb1-96e90fcdbb31",
            "ecsVersion": "8.6.1",
            "errorCount": 0,
            "ilmPhase": "hot",
            "indexId": "56NqQP_eSNCnesjLPmoe1g",
            "indexName": ".ds-auditbeat-8.7.1-2023.08.14-000001",
            "isCheckAll": true,
            "numberOfDocuments": 13593,
            "numberOfIncompatibleFields": 0,
            "numberOfIndices": 1,
            "numberOfIndicesChecked": 1,
            "sizeInBytes": 10588378,
            "timeConsumedMs": 134,
            "unallowedMappingFields": [],
            "unallowedValueFields": []
        }
    }
    
    
    {
        "timestamp": "2023-08-15T13:39:37.013Z",
        "event_type": "Data Quality Index Checked",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "5d0d6127-4b9b-47af-8bb1-96e90fcdbb31",
            "ecsVersion": "8.6.1",
            "errorCount": 0,
            "ilmPhase": "hot",
            "indexId": "hjnJ8WyPR5uTLw3fBISMmA",
            "indexName": ".ds-packetbeat-8.8.0-2023.08.14-000001",
            "isCheckAll": true,
            "numberOfDocuments": 318749,
            "numberOfIncompatibleFields": 0,
            "numberOfIndices": 1,
            "numberOfIndicesChecked": 1,
            "sizeInBytes": 165604512,
            "timeConsumedMs": 157,
            "unallowedMappingFields": [],
            "unallowedValueFields": []
        }
    }
    
    
    {
        "timestamp": "2023-08-15T13:39:37.013Z",
        "event_type": "Data Quality Check All Completed",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "5d0d6127-4b9b-47af-8bb1-96e90fcdbb31",
            "ecsVersion": "8.6.1",
            "isCheckAll": true,
            "numberOfDocuments": 340180,
            "numberOfIncompatibleFields": 3,
            "numberOfIndices": 4,
            "numberOfIndicesChecked": 4,
            "sizeInBytes": 191318810,
            "timeConsumedMs": 9651
        }
    }
    ```
    
    
    
    
    https://github.com/elastic/kibana/assets/6295984/5c977f60-e78d-426e-a682-46f7b1de4138
    
    ```
    {
        "timestamp": "2023-08-15T13:42:47.777Z",
        "event_type": "Data Quality Index Checked",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "cb8c7d1d-d84c-41a3-8e9b-cb3991817df0",
            "ecsVersion": "8.6.1",
            "errorCount": 0,
            "ilmPhase": "hot",
            "indexId": "WxZsLLXbR9qeroNaFeY1wg",
            "indexName": ".internal.alerts-security.alerts-default-000001",
            "isCheckAll": false,
            "numberOfDocuments": 7834,
            "numberOfIncompatibleFields": 0,
            "numberOfIndices": 1,
            "numberOfIndicesChecked": 1,
            "sizeInBytes": 15097503,
            "timeConsumedMs": 121,
            "unallowedMappingFields": [],
            "unallowedValueFields": []
        }
    }
    
    
    {
        "timestamp": "2023-08-15T13:43:00.076Z",
        "event_type": "Data Quality Index Checked",
        "context": {
            "isDev": true,
            "isDistributable": false,
            "version": "8.10.0",
            "branch": "main",
            "buildNum": 9007199254740991,
            "buildSha": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "session_id": "99ed0d92-71f7-4e48-bdbb-a03bb8ac31e3",
            "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
            "preferred_language": "en-US",
            "preferred_languages": [
                "en-US",
                "en"
            ],
            "viewport_width": 2560,
            "viewport_height": 934,
            "cluster_name": "elasticsearch",
            "cluster_uuid": "efIxsMivQne1nV2Y44MW5A",
            "cluster_version": "8.10.0-SNAPSHOT",
            "pageName": "application:securitySolutionUI:/data_quality",
            "applicationId": "securitySolutionUI",
            "page": "/data_quality",
            "entityId": "new",
            "page_title": "Elastic",
            "page_url": "/app/security/data_quality#?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:security-solution-default,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))",
            "license_id": "d8d531da-1994-4e24-a4cc-13d7ea30c339",
            "license_status": "active",
            "license_type": "trial",
            "labels": {
                "serverless": "security"
            },
            "userId": "986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391",
            "isElasticCloudUser": false
        },
        "properties": {
            "batchId": "ca4e6e41-0025-47c6-ab46-e4a7b6911b4f",
            "ecsVersion": "8.6.1",
            "errorCount": 0,
            "ilmPhase": "unmanaged",
            "indexId": "AoyctcRqTKG8HvUVmpuzEA",
            "indexName": "auditbeat-custom-index-1",
            "isCheckAll": false,
            "numberOfDocuments": 4,
            "numberOfIncompatibleFields": 3,
            "numberOfIndices": 1,
            "numberOfIndicesChecked": 1,
            "sizeInBytes": 28417,
            "timeConsumedMs": 91,
            "unallowedMappingFields": [
                "host.name",
                "source.ip"
            ],
            "unallowedValueFields": [
                "event.category"
            ]
        }
    }
    ```
    angorayc authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9c17de6 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    b5af8c8 View commit details
    Browse the repository at this point in the history
  30. [Asset Manager] services endpoint (#164181)

    Closes #159641
    
    Implements `/assets/services` endpoint that returns service assets found
    in the configured source (signals or assets indices). Consumer can
    provide a `parent` query to filter the returned services. While the
    _assets_ mode supports any kind of parent/depth thanks to its common
    interface, the _signals_ mode only supports host parent for the moment.
    
    1. pull this branch and point it at an oblt-cli created cluster that
    uses cross-cluster search to read from the edge cluster
    2. add the following[1] to your kibana.yml file
    3. hit
    `/api/asset-manager/assets/services?from=<from>&to=<to>&(parent=<host>)?`.
    services should be returned. Add/remove parent query string to filter
    services only running on specific host.
    
    [1]
    ```
    xpack.assetManager:
      alphaEnabled: true
      sourceIndices:
        metrics: remote_cluster:metricbeat*,remote_cluster:metrics-*
        logs: remote_cluster:filebeat*,remote_cluster:logs-*
        traces: remote_cluster:traces-*
        serviceMetrics: remote_cluster:metrics-apm*
        serviceLogs: remote_cluster:logs-apm*
      lockedSource: signals
    ```
    
    Co-authored-by: Kibana Machine <[email protected]>
    klacabane and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0d63919 View commit details
    Browse the repository at this point in the history
  31. Update core architecture docs (#164120)

    Co-authored-by: Kibana Machine <[email protected]>
    Co-authored-by: amyjtechwriter <[email protected]>
    3 people authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    5a68f70 View commit details
    Browse the repository at this point in the history
  32. Add threat indicator fields to prebuilt rule filterlist. (#164275)

    ## Summary
    
    Adds a filterlist entry for threat indicator match rules to the prebuilt
    rule alert filterlist.
    I will open an OOB artifact separately.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    pjhampton authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    fcf838e View commit details
    Browse the repository at this point in the history
  33. [Security Solution] Enable Detections Coverage Overview dashboard by …

    …default (#164343)
    
    **Epic:** elastic/security-team#2905
    (internal)
    
    ## Summary
    
    Enables the Detections Coverage Overview dashboard feature flag by
    default. We're aiming to release this feature in 8.10.
    
    Before the last BC, we will:
    
    - remove the flag if we're confident that we should release the feature
    in 8.10
    - otherwise, revert the flag back to `false` by default
    banderror authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    43135b6 View commit details
    Browse the repository at this point in the history
  34. [Security Solution] Update CODEOWNERS for the Detection Engine team (#…

    …164359)
    
    ## Summary
    
    This PR updates the COEOWNERS file by adding missing Cypress tests
    folders owned by the @elastic/security-detection-engine team.
    banderror authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8238900 View commit details
    Browse the repository at this point in the history
  35. Update dependency @elastic/apm-rum-react to v2 (main) (#163973)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Kibana Machine <[email protected]>
    renovate[bot] and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8a6dfb8 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    05a8ce1 View commit details
    Browse the repository at this point in the history
  37. [RAM] Use ruletype to determine alert indices (#163574)

    ## Summary
    
    We were using the feature Id to determine the alert indices, but we
    realized that we should use the rule type id instead. Meaning that we
    check which rule type does the user have access and then we get the
    indices related to this rule type.
    
    We also took advantage of the new suggestion abstraction of the search
    bar components to remove the toaster of hell ->
    #163003
    
    
    ### Checklist
    
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    XavierM and kibanamachine authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d7bf7ef View commit details
    Browse the repository at this point in the history
  38. Upgrade EUI to v87.1.0 (#163961)

    `v86.0.0`⏩`v87.1.0`
    
    ⚠️ The biggest set of type changes in this PR come from the breaking
    change that makes `pageSize` and `pageSizeOptions` now optional props
    for `EuiBasicTable.pagination`, `EuiInMemoryTable.pagination` and
    `EuiDataGrid.pagination`.
    
    This caused several other components that were cloning EUI's pagination
    type to start throwing type warnings about `pageSize` being optional.
    Where I came across these errors, I modified the extended types to
    require `pageSize`. These types and their usages may end up changing
    again in any case once the Shared UX team looks into
    #56406.
    
    ---
    
    ## [`87.1.0`](https://github.com/elastic/eui/tree/v87.1.0)
    
    - Updated the underlying library powering `EuiAutoSizer`. This primarily
    affects typing around the `disableHeight` and `disableWidth` props
    ([#6798](elastic/eui#6798))
    - Added new `EuiAutoSize`, `EuiAutoSizeHorizontal`, and
    `EuiAutoSizeVertical` types to support `EuiAutoSizer`'s now-stricter
    typing ([#6798](elastic/eui#6798))
    - Updated `EuiDatePickerRange` to support `compressed` display
    ([#7058](elastic/eui#7058))
    - Updated `EuiFlyoutBody` with a new `scrollableTabIndex` prop
    ([#7061](elastic/eui#7061))
    - Added a new `panelMinWidth` prop to `EuiInputPopover`
    ([#7071](elastic/eui#7071))
    - Added a new `inputPopoverProps` prop for `EuiRange`s and
    `EuiDualRange`s with `showInput="inputWithPopover"` set
    ([#7082](elastic/eui#7082))
    
    **Bug fixes**
    
    - Fixed `EuiToolTip` overriding instead of merging its
    `aria-describedby` tooltip ID with any existing `aria-describedby`s
    ([#7055](elastic/eui#7055))
    - Fixed `EuiSuperDatePicker`'s `compressed` display
    ([#7058](elastic/eui#7058))
    - Fixed `EuiAccordion` to remove tabbable children from sequential
    keyboard navigation when the accordion is closed
    ([#7064](elastic/eui#7064))
    - Fixed `EuiFlyout`s to accept custom `aria-describedby` IDs
    ([#7065](elastic/eui#7065))
    
    **Accessibility**
    
    - Removed the default `dialog` role and `tabIndex` from push
    `EuiFlyout`s. Push flyouts, compared to overlay flyouts, require manual
    accessibility management.
    ([#7065](elastic/eui#7065))
    
    ## [`87.0.0`](https://github.com/elastic/eui/tree/v87.0.0)
    
    - Added beta `componentDefaults` prop to `EuiProvider`, which will allow
    configuring certain default props globally. This list of components and
    defaults is still under consideration.
    ([#6923](elastic/eui#6923))
    - `EuiPortal`'s `insert` prop can now be configured globally via
    `EuiProvider.componentDefaults`
    ([#6941](elastic/eui#6941))
    - `EuiFocusTrap`'s `crossFrame` and `gapMode` props can now be
    configured globally via `EuiProvider.componentDefaults`
    ([#6942](elastic/eui#6942))
    - `EuiTablePagination`'s `itemsPerPage`, `itemsPerPageOptions`, and
    `showPerPageOptions` props can now be configured globally via
    `EuiProvider.componentDefaults`
    ([#6951](elastic/eui#6951))
    - `EuiBasicTable`, `EuiInMemoryTable`, and `EuiDataGrid` now allow
    `pagination.pageSize` to be undefined. If undefined, `pageSize` defaults
    to `EuiTablePagination`'s `itemsPerPage` component default.
    ([#6993](elastic/eui#6993))
    - `EuiBasicTable`, `EuiInMemoryTable`, and `EuiDataGrid`'s
    `pagination.pageSizeOptions` will now fall back to
    `EuiTablePagination`'s `itemsPerPageOptions` component default.
    ([#6993](elastic/eui#6993))
    - Updated `EuiHeaderLinks`'s `gutterSize` spacings
    ([#7005](elastic/eui#7005))
    - Updated `EuiHeaderAlert`'s stacking styles
    ([#7005](elastic/eui#7005))
    - Added `toolTipProps` to `EuiListGroupItem` that allows customizing
    item tooltips. ([#7018](elastic/eui#7018))
    - Updated `EuiBreadcrumbs` to support breadcrumbs that toggle popovers
    via `popoverContent` and `popoverProps`
    ([#7031](elastic/eui#7031))
    - Improved the contrast ratio of disabled titles within `EuiSteps` and
    `EuiStepsHorizontal` to meet WCAG AA guidelines.
    ([#7032](elastic/eui#7032))
    - Updated `EuiSteps` and `EuiStepsHorizontal` to highlight and provide a
    more clear visual indication of the current step
    ([#7048](elastic/eui#7048))
    
    **Bug fixes**
    
    - Single uses of `<EuiHeaderSectionItem side="right" />` now align right
    as expected without needing a previous `side="left"` sibling.
    ([#7005](elastic/eui#7005))
    - `EuiPageTemplate` now correctly displays `panelled={true}`
    ([#7044](elastic/eui#7044))
    
    **Breaking changes**
    
    - `EuiTablePagination`'s default `itemsPerPage` is now `10` (was
    previously `50`). This can be configured through
    `EuiProvider.componentDefaults`.
    ([#6993](elastic/eui#6993))
    - `EuiTablePagination`'s default `itemsPerPageOptions` is now `[10, 25,
    50]` (was previously `[10, 20, 50, 100]`). This can be configured
    through `EuiProvider.componentDefaults`.
    ([#6993](elastic/eui#6993))
    - Removed `border` prop from `EuiHeaderSectionItem` (unused since
    Amsterdam theme) ([#7005](elastic/eui#7005))
    - Removed `borders` object configuration from `EuiHeader.sections`
    ([#7005](elastic/eui#7005))
    
    **CSS-in-JS conversions**
    
    - Converted `EuiHeaderAlert` to Emotion; Removed unused
    `.euiHeaderAlert__dismiss` CSS
    ([#7005](elastic/eui#7005))
    - Converted `EuiHeaderSection`, `EuiHeaderSectionItem`, and
    `EuiHeaderSectionItemButton` to Emotion
    ([#7005](elastic/eui#7005))
    - Converted `EuiHeaderLinks` and `EuiHeaderLink` to Emotion; Removed
    `$euiHeaderLinksGutterSizes` Sass variables
    ([#7005](elastic/eui#7005))
    - Removed `$euiHeaderBackgroundColor` Sass variable; use
    `$euiColorEmptyShade` instead
    ([#7005](elastic/eui#7005))
    - Removed `$euiHeaderChildSize` Sass variable; use `$euiSizeXXL` instead
    ([#7005](elastic/eui#7005))
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    Co-authored-by: Patryk Kopyciński <[email protected]>
    3 people authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    84ca85d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. skip flaky suite (#164313)

    mistic committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a85c8df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31eed02 View commit details
    Browse the repository at this point in the history
  3. [DOCS] Change deep link to ES book for CCS privileges (#164165)

    ## Summary
    
    Relates to elastic/elasticsearch#98330
    
    8.10 introduces a new method to configure remote clusters (API key
    based), which will live next to the existing method (certificate based).
    As a result, the ES remote cluster docs will be restructured. The deep
    link from "[Alerting set
    up](https://www.elastic.co/guide/en/kibana/current/alerting-setup.html#alerting-ccs-setup)"
    to the setting up CCS privileges section in the ES docs will break (and
    would potentially bring folks to the wrong page anyway).
    
    This PR changes the link into a link to the higher-level remote cluster
    docs, from where folks can click through to the section that is relevant
    to them.
    abdonpijpelink authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4b1d833 View commit details
    Browse the repository at this point in the history
  4. [Fleet] Add ability to set a proxy for agent binary source (#164168)

    ## Summary
    
    Closes #162862 
    
    Add a proxy selector for agent download sources. 
    
    Selecting a proxy will set the agent.download.proxy_url field on the
    agent policy (this can be checked in the "view full agent policy"
    flyout). I have marked this functionality as beta as we currently can
    only use the URL of the proxy, not the certificates or headers.
    
    Editing a proxy should automatically update all associated policies
    which use download sources with that proxy.
    
    Deleting a proxy should remove the proxy from all associated policies. 
    
    <img width="1789" alt="Screenshot 2023-08-17 at 14 41 58"
    src="https://github.com/elastic/kibana/assets/3315046/7b1afb40-4b89-4509-89df-9850627d7257">
    
    
    Verifying the field is set...
    
    
    <img width="1788" alt="Screenshot 2023-08-17 at 14 43 38"
    src="https://github.com/elastic/kibana/assets/3315046/81316dd1-dc8f-4120-9bbc-9e96e522ceda">
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    hop-dev and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ce93a1f View commit details
    Browse the repository at this point in the history
  5. [Cloud Security] wait for action button to be present before clicking…

    … to fix flacky FTR tests (#164054)
    
    ## Summary
    
    Fixing flaky FTR test where we need to navigate to the integrations page
    from our onboarding views. Confirmed in the flaky test runner that with
    the fix tests are not flaky anymore
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2901
    
    fixes:
    - #163950
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    maxcold and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9aba253 View commit details
    Browse the repository at this point in the history
  6. [Security Solutions] Align global menu with security solutions menu (#…

    …164268)
    
    issue: #163458
    
    ## Summary
    
    Update the global menu to reflect the latest changes to the security
    solution menu.
    
    
    ## How to test it?
    * start ESS kibana
    * Open security solution
    * Compare the global menu and the security solutions menu
    * It should display the same item order
    
    
    <img width="234" alt="Screenshot 2023-08-21 at 10 48 56"
    src="https://github.com/elastic/kibana/assets/1490444/84716392-e15c-4377-9c55-51d8109afd40">
    <img width="242" alt="Screenshot 2023-08-21 at 10 49 05"
    src="https://github.com/elastic/kibana/assets/1490444/89f7516e-48f1-4f61-8272-2f6dd662b53e">
    machadoum authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9760862 View commit details
    Browse the repository at this point in the history
  7. [main] Sync bundled packages with Package Storage (#163852)

    Automated by
    https://internal-ci.elastic.co/job/package_storage/job/sync-bundled-packages-job/job/main/6309/
    
    Co-authored-by: apmmachine <[email protected]>
    Co-authored-by: Julia Bardi <[email protected]>
    Co-authored-by: Kibana Machine <[email protected]>
    4 people authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    90c1a4a View commit details
    Browse the repository at this point in the history
  8. [APM] Add data access plugin (#162367)

    Closes #161906
    Related to:
    elastic/observability-dev#2787
    (_internal_)
    
    This add a new plugin `apm_data_access` that contains the APM query
    targets (indices to query for APM data).
    This plugin can be consumed by apm and any other plugin, making it
    possible for other plugins to know about the configured APM query
    targets.
    
    
    
    ## Example:
    
    APM query targets can be specified in kibana[.dev].yml using
    `xpack.apm.indices.{dataset}: some-index-*` for instances:
    
    ```yml
    xpack.apm.indices.transaction: apm-*
    ```
    
    See all config options on:
    https://www.elastic.co/guide/en/kibana/current/apm-settings-kb.html#general-apm-settings-kb
    
    Query targets can also be specified via the UI (and persisted in a saved
    object) via the settings page: `/app/apm/settings/apm-indices`
    
    **Retrieving the query targets**
    Query targets can be retrieved from other plugins via `getApmIndices`:
    ```ts
    const apmIndices = await plugins.apmDataAccess.setup.getApmIndices(savedObjects.client); 
    ```
    
    TODO:
    
    - [x] Add SO client and fetch space aware index config (see
    https://github.com/sqren/kibana/blob/4d7f626da020c156500f8bf52bf8861cde54b4f1/x-pack/plugins/apm/server/routes/settings/apm_indices/get_apm_indices.ts#L32-L44)
    - [ ] Add simple APM client for querying apm data
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    sorenlouv and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7df1cee View commit details
    Browse the repository at this point in the history
  9. [Ops] Upgrade to axios 1.4 (#163732)

    ## Summary
    upgrade `axios` to 1.4
    
    - adjust to header usage, and config optionality
    - Axios' adapters are now resolved from a string key by axios, no need
    to import/instantiate adapters
    - most of the changed code stems from changes in Axios' types
      - `response.config` is now optional
    - there was a change in the type of AxiosHeaders <->
    InternalAxiosHeaders
    
    Closes: #162661 
    Closes: #162414
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    delanni and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9d2696b View commit details
    Browse the repository at this point in the history
  10. [Profiling] More realistic CO2 and $ calculations (#164282)

    This PR amends two constants for the CO2 emission and dollar cost
    calculations to get more realistic results for the year 2023.
    rockdaboot authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    826633c View commit details
    Browse the repository at this point in the history
  11. [Profiling] checking viewer resources in the admin check (#164086)

    We identified a bug in the set up check where for admin users we should
    also include the checks that were made in the step above.
    
    We also decided to revert the changes in the package names.
    
    ---------
    
    Co-authored-by: Francesco Gualazzi <[email protected]>
    cauemarcondes and inge4pres authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2e854d6 View commit details
    Browse the repository at this point in the history
  12. [Infra UI] Node Details using Asset Details component (#164077)

    part of [#162898](#162898)
    
    ## Summary
    
    This PR implements the new node details page for hosts. It uses the
    Asset Details component, which is the same used in the Hosts View
    flyout.
    
    
    https://github.com/elastic/kibana/assets/2767137/0d3d2b2d-ed82-4275-b424-ddae82cdbddc
    
    It **does not** change the behaviour of other asset types (kubernetes,
    container, aws...). The main change this PR introduces is internalizing
    the Data Views logic so that clients don't have to worry about passing
    it to the Asset Details.
    
    The fundamental change between flyout and page is the template.
    Everything else is shared.
    
    Functional tests will be added in a separate PR.
    
    ### How to test this PR
    - Setup a local Kibana instance
    - Navigate to `Infrastructure` > `Hosts`
      - Click on a host name and check if the new Node Details page opened
      - Return to the hosts page and open a flyout
    - Click on `Open as page` and check if the new Node Details page opened
    - Navigate to `Infrastructure` > `Inventory`
    - With `Show: Host` selected, click on a waffle item to open the flyout,
    click on `Open as page` and check if the new Node Details page opened
    - Select another asset type in `Show` , open the flyout and check if the
    old version of the Node Details Page will show
    
    #### Storybook
    `yarn storybook infra`
    
    
    ### For reviewers
    
    Errors in the new page will be handled differently from what the current
    Node Details page. i.e: accessing the page with invalid asset id, won't
    show this page
    
    <img width="1443" alt="image"
    src="https://github.com/elastic/kibana/assets/2767137/93de3caf-ac63-4a34-a90d-226b212096fe">
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    crespocarlos and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2ca1081 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a8c28d9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9591264 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    be32a39 View commit details
    Browse the repository at this point in the history
  16. [config-schema] offeringBasedSchema helper (#163786)

    Co-authored-by: Kibana Machine <[email protected]>
    afharo and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e98b4b3 View commit details
    Browse the repository at this point in the history
  17. Add warning for max alerts circuit breaker (#164217)

    In this PR, I'm adding a warning message to the docs for the
    `xpack.alerting.rules.run.alerts.max` setting that indicates the
    consequences when setting a value higher than the default, while also
    indicating it's not supported.
    
    <img width="862" alt="Screenshot 2023-08-21 at 5 03 52 PM"
    src="https://github.com/elastic/kibana/assets/3694571/46a7f5d6-f6d5-475a-ab93-edf256eb9141">
    
    cc @lcawl
    
    ---------
    
    Co-authored-by: Lisa Cawley <[email protected]>
    mikecote and lcawl authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    327af6c View commit details
    Browse the repository at this point in the history
  18. Fleet - Turn some error messages in info (#164333)

    ## Summary
    
    Proposal to fix #164270
    
    ### Checklist
    
    - [ ] Possibly evaluate the "verbosity" vs "troubleshoot-ability"
    - [ ] Backport
    
    Co-authored-by: Julia Bardi <[email protected]>
    lucabelluccini and juliaElastic authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    79f8dcd View commit details
    Browse the repository at this point in the history
  19. Unskip Serverless Observability Tests / serverless observability UI n…

    …avigation active sidenav section is auto opened on load (#162323)
    
    ## Summary
    
    close #162781
    Simulating flaky test run with for loop:
    #162323 (comment)
    Dosant authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3458d7b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    e5f6c1a View commit details
    Browse the repository at this point in the history
  21. [Enterprise Search] Fix styling for product selector. (#164307)

    ## Summary
    
    Fixes a visual bug on product selector
    ![Screenshot 2023-08-21 at 15 24
    23](https://github.com/elastic/kibana/assets/1410658/a51114a8-531f-46b4-aa0c-b027ff86c723)
    
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    efegurkan authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e042882 View commit details
    Browse the repository at this point in the history
  22. [ML] AIOps: Update assertion for the change point detection tests (#1…

    …64404)
    
    ## Summary
    
    Closes #158851
    
    Updates assertion for the split field test.
    darnautov authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    546a3cb View commit details
    Browse the repository at this point in the history
  23. [FTR] Move serverless tests depending on feature flag to its own conf…

    …ig file (#163929)
    
    ## Summary
    
    It seems beneficial to have feature flag tests in a separate test config
    file
     - tests are still run on Kibana CI automatically
    - tests are not run on MKI projects automatically, but you can deploy
    custom project and run tests via feature flags config
    
    All the feature flags within the same project should be places in the
    same config to make sure there is no arguments conflict.
    When the flag is moved to the yml configuration, we can rely on Kibana
    CI and manually triggered deployment to make sure projects are
    functioning correctly.
    
    ---------
    
    Co-authored-by: Robert Oskamp <[email protected]>
    dmlemeshko and pheyos authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7ece4e5 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    635eedb View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    5eeb3f7 View commit details
    Browse the repository at this point in the history
  26. Kibana QualityGate Scaffold (#163831)

    The main question is here did I get the github team names correct for
    fleet and security? Are there any other groups I am missing who will
    have quality gates they want to see execute on every kibana release?
    
    - The PR which registered the repo and controls who can write secrets to
    vault was merged
    [here](https://github.com/elastic/catalog-info/pull/488/files)
    - Quality gate registration with argo deploy pipeline
    [here](https://github.com/elastic/serverless-gitops/pull/586). Should
    merge after this and pipelines are working.
    - [this one](https://github.com/elastic/catalog-info/pull/485/files)
    merges last and tells terrazzo about the catalog-info.yaml file with our
    pipeline. Other pipelines should be migrated over but are not included
    here.
    
    
    Rel: https://github.com/elastic/ingest-dev/issues/2201
    Rel: https://elasticco.atlassian.net/browse/QX-282
    
    ---------
    
    Co-authored-by: Ramon Butter <[email protected]>
    imkarrer and ramonbutter authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    58334b5 View commit details
    Browse the repository at this point in the history
  27. skip flaky suite (#164381)

    mistic committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    83a0eec View commit details
    Browse the repository at this point in the history
  28. [Search Relevance] Move error handler to selector (#164113)

    This change is related to this issue:
    elastic/search-team#4440
    
     In this PR, we are moving error handler to selectors.
    
    <img width="1249" alt="Screenshot 2023-08-16 at 6 04 38 PM"
    src="https://github.com/elastic/kibana/assets/132922331/df2d4a6e-d677-4f61-952e-207cbc5c5955">
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    saikatsarkar056 and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    dd8239f View commit details
    Browse the repository at this point in the history
  29. [Watcher] Migrate all usages of EuiPage*_Deprecated (#163128)

    ## What does this PR do?
     *  Migrate all usages of EuiPage*_Deprecated in Watcher
     
    ## Issue References
     * #163070
     
    ## Video/Screenshot Demo
    
    
    ---
    This code was written and reviewed by GitStart Community. Growing great
    engineers, one PR at a time.
    
    ---------
    
    Co-authored-by: LuisChiej <[email protected]>
    Co-authored-by: gitstart_bot <[email protected]>
    Co-authored-by: Yulia Cech <[email protected]>
    4 people authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    34733be View commit details
    Browse the repository at this point in the history
  30. [Infra UI] Add functional test for Node Details page (#164174)

    part of #162898
    
    ## Summary
    
    This PR adds a functional test for the Node Details page using the Asset
    Details component. It also refactors the Hosts View flyout test cases,
    limiting them to high-level checks. The focus of Hosts View test focuses
    on the page's own functionalities
    
    Detailed Asset Details-related tests will be implemented in the Node
    Details test suite.
    
    
    ### How to test
    
     ```bash
    yarn test:ftr:server --config
    x-pack/test/functional/apps/infra/config.ts
    ```
    
    
    ```bash
    node scripts/functional_test_runner
    --config=x-pack/test/functional/apps/infra/config.ts --include
    x-pack/test/functional/apps/infra/hosts_view.ts
    ```
    
    ```bash
    node scripts/functional_test_runner
    --config=x-pack/test/functional/apps/infra/config.ts --include
    x-pack/test/functional/apps/infra/node_details.ts
    ```
    crespocarlos authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b5ef8a6 View commit details
    Browse the repository at this point in the history
  31. [ML] Fix anomaly detection module manifest queries for kibana sample …

    …data sets (#164332)
    
    Follow up to #119635
    All modules which contain a query in their manifest file should have a
    filter to avoid querying cold and frozen tiers.
    The original PR did not include the sample data sets as it was assumed
    it was not necessary due to these data sets never being added to cold or
    frozen tiers.
    However it was overlooked that these queries will be run on any index
    pattern passed to the `/internal/ml/modules/recognize` endpoint and so
    has the potential to negatively impact the speed of all calls to this
    endpoint, especially if the index pattern contains multiple indices and
    wildcards.
    jgowdyelastic authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    cd21994 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    03e2ba9 View commit details
    Browse the repository at this point in the history
  33. [Security Solutions] Add telemetry to the side navigation tracking fo…

    …r serverless pages (#164309)
    
    issue: #164306
    
    ## Summary
    Add <TrackApplicationView> telemetry to serverless-specific Security
    pages
    Pages: Investigations, Assets, ML, Project Settings.
    
    ## How to test it
    * Visit Investigations, Assets, ML, and Project Settings.
    When you navigate between pages the app should log "Reporting
    application usage for securitySolutionUI, {PAGE}" like it does for the
    other pages
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    machadoum and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    813eebe View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    9c83d2e View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    c2a552e View commit details
    Browse the repository at this point in the history
  36. [Security Solution] [Timeline] Open a timeline to any tab from a url …

    …without a saved object id (#163033)
    
    ## Summary
    
    This change enables the timeline to be opened to any specific tab on
    page load without needing a saved object id, normally generated when a
    user creates some sort of state that is either auto saved or explicitly
    saved by a user action. The video below is just a hard coded
    window.location = security url redirect in the discover plugin, the
    discover part will come in a follow up pr.
    
    
    ![open_timeline_discover_tab](https://github.com/elastic/kibana/assets/56408403/ef834d72-c42e-4584-bf98-1d8ef29dd530)
    
    
    ### Checklist
    
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    kqualters-elastic and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    209e775 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    c90e6d1 View commit details
    Browse the repository at this point in the history
  38. Remove several @ts-ignore/@ts-expect-errors around EUI imports (#…

    …163984)
    
    ## Summary
    
    There's a few EUI imports out there that folks are reaching into
    `@elastic/eui/lib/` for (which doesn't contain any types - something I'm
    looking into separately) that could instead be imported at the top
    `@elastic/eui` level, which is properly typed.
    
    ### Checklist
    
    N/A - types only
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    cee-chen and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7c89621 View commit details
    Browse the repository at this point in the history
  39. Reporting/fix visual warning test (#164383)

    ## Summary
    
    Closes #135309
    
    This PR eliminates a skipped functional test by replacing the test
    coverage with unit tests.
    
    *
    `x-pack/plugins/screenshotting/server/screenshots/screenshots.test.ts`:
    ensures that waiting too long for the URL to open will return the
    expected error message
    *
    `x-pack/plugins/screenshotting/server/browsers/chromium/driver.test.ts`:
    ensures that when the screenshot capture method is passed an error
    message, that error message is injected into the screenshot
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    tsullivan and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    deb64c1 View commit details
    Browse the repository at this point in the history
  40. Change i18n.translate() to return string type instead of leaving …

    …it up to Typescript parser (#164464)
    
    ## Summary
    
    While researching why we had so many `ANY`s in our "Any counts by team"
    quality report, I noticed that all of the `i18n.translate` in our
    `uiSettings` we being reported as `any` even though Typescript says that
    function returns a `string`. When I explicitly define the return value,
    our `any` count drops from `46` to `2`.
    
    This is the command I ran for the report: `node scripts/build_api_docs
    --plugin observability --stats any`
    
    ### Before
    ```
    ┌─────────┬─────────────────────────────────────────────────────────────────────────────────────────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
    │ (index) │                                             id                                              │                                                                      link                                                                       │
    ├─────────┼─────────────────────────────────────────────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
    │    0    │                        'def-server.getInspectResponse.$1.esResponse'                        │       'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/common/utils/get_inspect_response.ts#:~:text=esResponse'        │
    │    1    │                     'def-server.uiSettings.enableInspectEsQueries.name'                     │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │    2    │                 'def-server.uiSettings.enableInspectEsQueries.description'                  │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │    3    │                         'def-server.uiSettings.maxSuggestions.name'                         │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │    4    │                     'def-server.uiSettings.maxSuggestions.description'                      │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │    5    │                   'def-server.uiSettings.enableComparisonByDefault.name'                    │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │    6    │                'def-server.uiSettings.enableComparisonByDefault.description'                │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │    7    │                  'def-server.uiSettings.defaultApmServiceEnvironment.name'                  │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │    8    │              'def-server.uiSettings.defaultApmServiceEnvironment.description'               │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │    9    │                     'def-server.uiSettings.apmProgressiveLoading.name'                      │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   10    │                  'def-server.uiSettings.apmProgressiveLoading.description'                  │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   11    │  'def-server.uiSettings.apmProgressiveLoading.optionLabels.ProgressiveLoadingQuality.off'   │  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=%5BProgressiveLoadingQuality.off%5D'   │
    │   12    │  'def-server.uiSettings.apmProgressiveLoading.optionLabels.ProgressiveLoadingQuality.low'   │  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=%5BProgressiveLoadingQuality.low%5D'   │
    │   13    │ 'def-server.uiSettings.apmProgressiveLoading.optionLabels.ProgressiveLoadingQuality.medium' │ 'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=%5BProgressiveLoadingQuality.medium%5D' │
    │   14    │  'def-server.uiSettings.apmProgressiveLoading.optionLabels.ProgressiveLoadingQuality.high'  │  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=%5BProgressiveLoadingQuality.high%5D'  │
    │   15    │              'def-server.uiSettings.apmServiceInventoryOptimizedSorting.name'               │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   16    │           'def-server.uiSettings.apmServiceInventoryOptimizedSorting.description'           │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   17    │               'def-server.uiSettings.apmServiceGroupMaxNumberOfServices.name'               │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   18    │           'def-server.uiSettings.apmServiceGroupMaxNumberOfServices.description'            │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   19    │                      'def-server.uiSettings.apmTraceExplorerTab.name'                       │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   20    │                   'def-server.uiSettings.apmTraceExplorerTab.description'                   │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   21    │                         'def-server.uiSettings.apmLabsButton.name'                          │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   22    │                      'def-server.uiSettings.apmLabsButton.description'                      │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   23    │                 'def-server.uiSettings.enableInfrastructureHostsView.name'                  │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   24    │              'def-server.uiSettings.enableInfrastructureHostsView.description'              │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   25    │                     'def-server.uiSettings.enableAwsLambdaMetrics.name'                     │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   26    │                 'def-server.uiSettings.enableAwsLambdaMetrics.description'                  │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   27    │                    'def-server.uiSettings.enableAgentExplorerView.name'                     │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   28    │                 'def-server.uiSettings.enableAgentExplorerView.description'                 │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   29    │                    'def-server.uiSettings.apmAWSLambdaPriceFactor.name'                     │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   30    │                 'def-server.uiSettings.apmAWSLambdaPriceFactor.description'                 │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   31    │               'def-server.uiSettings.apmAWSLambdaRequestCostPerMillion.name'                │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   32    │                    'def-server.uiSettings.apmEnableServiceMetrics.name'                     │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   33    │                 'def-server.uiSettings.apmEnableServiceMetrics.description'                 │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   34    │                   'def-server.uiSettings.apmEnableContinuousRollups.name'                   │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   35    │               'def-server.uiSettings.apmEnableContinuousRollups.description'                │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   36    │                       'def-server.uiSettings.enableCriticalPath.name'                       │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   37    │                   'def-server.uiSettings.enableCriticalPath.description'                    │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   38    │                  'def-server.uiSettings.syntheticsThrottlingEnabled.name'                   │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   39    │               'def-server.uiSettings.syntheticsThrottlingEnabled.description'               │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   40    │                     'def-server.uiSettings.enableLegacyUptimeApp.name'                      │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   41    │                  'def-server.uiSettings.enableLegacyUptimeApp.description'                  │              'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=description'               │
    │   42    │                 'def-server.uiSettings.apmEnableProfilingIntegration.name'                  │                  'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/server/ui_settings.ts#:~:text=name'                  │
    │   43    │                                  'def-common.AsPercent.$3'                                  │     'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/common/utils/formatters/formatters.ts#:~:text=fallbackResult'     │
    │   44    │                                  'def-common.asPercent.$3'                                  │     'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/common/utils/formatters/formatters.ts#:~:text=fallbackResult'     │
    │   45    │                        'def-common.getInspectResponse.$1.esResponse'                        │       'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/common/utils/get_inspect_response.ts#:~:text=esResponse'        │
    └─────────┴─────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
    
    ```
    
    ### After
    ```
    ┌─────────┬───────────────────────────────────────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
    │ (index) │                      id                       │                                                                link                                                                │
    ├─────────┼───────────────────────────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
    │    0    │ 'def-server.getInspectResponse.$1.esResponse' │ 'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/common/utils/get_inspect_response.ts#:~:text=esResponse' │
    │    1    │ 'def-common.getInspectResponse.$1.esResponse' │ 'https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability/common/utils/get_inspect_response.ts#:~:text=esResponse' │
    └─────────┴───────────────────────────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
    ```
    simianhacker authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a518276 View commit details
    Browse the repository at this point in the history
  41. [Reporting] Implement successful csv download in serverless (#164320)

    ## Summary
    
    PR #163796 provided the
    `?elasticInternalOrigin=true` parameter to permit internal routes such
    as is the case with csv download in serverless. This PR implements this
    parameter in the url for csv downloads in the places that csv downloads
    can occur (mainly the toast download report success button and the
    reporting management page)
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    rshen91 authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8a331e0 View commit details
    Browse the repository at this point in the history
  42. [SecuritySolution] Hide loading icon when the user has no permission …

    …to read Security dashboard (#164439)
    
    ## Summary
    
    Original issue and **Steps to reproduce**:
    #164405
    
    
    
    **Before** - User without SecuritySolution read permission saw the
    loading icon spinning.
    
    <img width="1726" alt="Screenshot 2023-08-22 at 11 10 38"
    src="https://github.com/elastic/kibana/assets/17427073/49cd1902-4266-418a-b464-1fc67198f6ca">
    
    
    **After** - User without SecuritySolution read permission cannot see the
    dashboard list.
    
    <img width="2544" alt="Screenshot 2023-08-22 at 13 27 24"
    src="https://github.com/elastic/kibana/assets/6295984/12de393b-363c-4aa6-97f1-8f0462da8b06">
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    angorayc authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    db4ffd0 View commit details
    Browse the repository at this point in the history
  43. [Fleet] Fix index patterns being recreated in default space, fix migr…

    …ation version setting (#164456)
    
    ## Summary
    
    Closes #164243
    Added a `typeMigrationVersion: '8.0.0'` to index patterns until
    #164454 is fixed.
    
    Related to #161969
    Feedback from kibana core team, we should always set the migration
    version fields, even if `migrationVersion` is not set.
    
    It would be good to backport this to 8.9 too.
    
    How to test locally:
    
    - create a test space
    - install system integration in test space
    - restart kibana
    - verify that the index patterns `logs-*`, `metrics-*` are still in test
    space in Data Views UI
    
    ### Checklist
    
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    juliaElastic authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    433d4f2 View commit details
    Browse the repository at this point in the history
  44. [Security Selection][Detection engine] fixes rule preview performance…

    … issues (#164207)
    
    ## Summary
    
    On every single keyboard type on query input, the whole preview part was
    re-rendering. If there are too many alerts, it could take ~150ms-200ms,
    for its re-render. Ultimately, making form almost unusable
    So, in this PR I'm adding memoization for 2 Preview components, to
    resolve this issue
    
    
    ### Before
    
    <img width="2529" alt="Screenshot 2023-08-17 at 17 13 07"
    src="https://github.com/elastic/kibana/assets/92328789/c0b137e6-828b-4068-b061-85a5b5ca99f1">
    
    ### After
    
    <img width="2523" alt="Screenshot 2023-08-17 at 17 07 56"
    src="https://github.com/elastic/kibana/assets/92328789/06a0983c-d8e0-40c1-9b48-fd4bc106e922">
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    vitaliidm and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    cd8a94b View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    6cf8598 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    2b8fcab View commit details
    Browse the repository at this point in the history
  47. [Security Solution] expandable flyout - Opt in to data anonymization …

    …for the Elastic AI Assistant (#164384)
    
    ## [Security Solution] expandable flyout - Opt in to data anonymization for the Elastic AI Assistant
    
    This PR fixes an issue where the new expandable flyout wasn't opting in to data anonymization when passing alerts as context to the Elastic AI Assistant.
    
    As a result:
    
    - A stat that reads `0 Anonymized` indicates the alert data will NOT be anonymized
    - NO toggle buttons to allow specific fields and enable / disable anonymization are displayed
    
    ### Reproduction steps
    
    To reproduce:
    
    1. Navigate to Security > Alerts
    
    2. Click the `View details` action on any row in the Alerts table to view the new expandable flyout
    
    3. Click the `Chat` button, which appears next to the `Expand details` button in the flyout
    
    4. Expand the `Alert (from summary)` context
    
    **Expected results**
    
    - Stats for the number of fields that will be `Allowed`, `Anonymized`, and the total number of fields `Available` are displayed
    - Toggle buttons to allow specific fields and enable / disable anonymization on each field are displayed
    
    **Actual results**
    
    - A stat that reads `0 Anonymized` indicates the alert data will NOT be anonymized
    - NO toggle buttons to allow specific fields and enable / disable anonymization are displayed
    - The plain-text, non-anonymized context data is displayed in the preview, per the screenshot below:
    
    ![0_anonymized](https://github.com/elastic/kibana/assets/4459398/e881bb4a-caa4-43c4-8b31-cf3deb354cf7)
    
    ## Desk testing
    
    1. Reproduce the issue per the steps above
    
    2. Verify the expected results are displayed when testing the fix, per the screenshot below:
    
    ![anonymization-opt-in](https://github.com/elastic/kibana/assets/4459398/79a8228d-c5a6-4ea5-a6ab-4bd992e6b7ef)
    
    _Above: After the fix, the expected stats and field level anonymization toggles are displayed_
    andrew-goldstein authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c1fde76 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    10ab426 View commit details
    Browse the repository at this point in the history
  49. [Embeddable] Clientside migration system (#162986)

    Changes the versioning scheme used by Dashboard Panels and by value Embeddables, and introduces a new clientside system that can migrate Embeddable Inputs to their latest versions.
    ThomThomson authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    26389e5 View commit details
    Browse the repository at this point in the history
  50. [Security Solution] Fix the rules coverage overview API contract (#16…

    …3838)
    
    **Epic:** elastic/security-team#2905
    (internal)
    
    ## Summary
    
    In our API endpoints, we shouldn't expose parameters for features we
    don't support yet.
    
    This PR:
    
    - Removes the `CoverageOverviewRuleActivity.Available` and
    `CoverageOverviewRuleSource.Customized` enum values from the coverage
    endpoint's request schema.
    - Does some additional cleanup.
    
    We will add the removed parameters back when we add the corresponding
    enhancements to the feature.
    banderror authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9b489ed View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    1caac7d View commit details
    Browse the repository at this point in the history
  52. Update error handling for saved query service (#163904)

    ## Summary
    
    Resolves #153497.
    
    Updates the saved query service to properly handle & return errors from
    the saved object client. Instead of displaying "internal server error"
    and returning 500, specific error messages occur for corresponding saved
    object client errors.
    
    After:
    
    
    ![image](https://github.com/elastic/kibana/assets/1178348/f8ba7b90-77fe-4db9-8377-0a1f878fe3a0)
    
    ### To do
    
    - [x] API integration tests
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    lukasolson and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    57b7efc View commit details
    Browse the repository at this point in the history
  53. Openapi spec timeline (#163083)

    ## Summary
    
    We are working to implement our public api's in the openapi standard
    format
    
    ## Testing
    
    Either:
    1. Install an editor extension such as:
    https://marketplace.visualstudio.com/items?itemName=42Crunch.vscode-openapi
    and preview as is
    
    <img width="1715" alt="image"
    src="https://github.com/elastic/kibana/assets/17211684/23f7ebcc-f10c-452f-8456-1f8e8e38545e">
    
    
    Or if you would rather look online: https://editor-next.swagger.io/
    - The only issue is the reference to the `components.yaml`. To get
    around this, copy the entire components yaml to the bottom of any of the
    route_schema.yaml files and update the references by removing the first
    path reference of `'../model/components.yaml` as such:
    - `$ref: '../model/components.yaml#/components/schemas/TimelineStatus'`
    =>
        - `$ref: '#/components/schemas/TimelineStatus'`
    
    ### Notes
    
    - `resolve/` api. I wonder if this should remain internal as the point
    of this api was to resolve 7.x savedObjectIds to their 8.x counterparts
    after the upgrade. This is primarily used for maintaining the
    functionality for links with so id references copied in 7.x, so that
    when a user clicks it, it will resolve properly to the 8.x SO.
    
    ### Questions
    - Should underscored paths actually just be made private?
    i.e. `import | export | draft | favorite | prepackaged` @angorayc or
    @XavierM may have insight here
    
    ### Tracking
    
    | Done? | Method | Endpoint |
    | ----- | ------ |
    ------------------------------------------------------- |
    | yes | POST    | /api/timeline       |
    | yes | PATCH    | /api/timeline       |
    | yes | POST    | /api/timeline/_import       |
    | yes | POST    | /api/timeline/_export       |
    | yes | GET    | /api/timeline/_draft       |
    | yes | GET    | /api/timeline       |
    | TODO? | GET    | /api/timeline/resolve       |
    | yes | GET    | /api/timelines       |
    | yes | POST    | /api/timeline/_draft       |
    | yes | DELETE    | /api/timeline       |
    | yes | PATCH    | /api/timeline/_favorite       |
    | yes | POST    | /api/timeline/_prepackaged       |
    | yes | PATCH    | /api/note       |
    | yes | DELETE    | /api/note       |
    | yes | PATCH    | /api/pinned_event       |
    michaelolo24 authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2c77415 View commit details
    Browse the repository at this point in the history
  54. [Security Solution] Re-enable file operations tests (#164315)

    ## Summary
    
    Re-enable tests after this bug was fixed:
    #162760
    
    
    ### Checklist
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    Co-authored-by: Kibana Machine <[email protected]>
    kevinlog and kibanamachine authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1e9282f View commit details
    Browse the repository at this point in the history
  55. Update catalog-info.yaml (#164498)

    Adds the Kibana UI and Kibana Background Tasks services to the Backstage
    configuration.
    
    ## Summary
    
    Summarize your PR. If it involves visual changes include a screenshot or
    gif.
    
    ### For maintainers
    
    - [x] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: Petr Klapka <[email protected]>
    Co-authored-by: Jon <[email protected]>
    3 people authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    5ab3d27 View commit details
    Browse the repository at this point in the history
  56. [Reporting] Fix - show diagnostic only when image reporting is enabled (

    #164336)
    
    ## Summary
    Closes [#164363](#164363)
    In serverless, pdf and png reports are not possible. I don't think it
    makes a lot of sense for the screenshotting diagnostic to appear to
    users since it's misleading.
    
    ![Screenshot 2023-08-21 at 10 20 05
    AM](https://github.com/elastic/kibana/assets/20343860/2d36cd9d-d9eb-4099-ac3c-bbf6dbd350e7)
    
    
    If pdf and pngs are disabled by the config then the screenshotting
    diagnostic link will not be shown on the reporting management page like
    in serverless:
    ![Screenshot 2023-08-21 at 10 22 01
    AM](https://github.com/elastic/kibana/assets/20343860/d767b543-5d3f-435a-ab92-73d68f72fcda)
    
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    rshen91 authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    af45072 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. [data views] Disable scripted fields in serverless environment (#163228)

    ## Summary
    
    Disables scripted fields in serverless environments. Data view defined
    scripted fields are ignored and the scripted fields tab in data view
    management is hidden.
    
    scriptedFieldsEnabled is defined via conditional config that's only
    available in serverless environments.
    
    ---------
    
    Co-authored-by: Julia Rechkunova <[email protected]>
    mattkime and jughosta authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2b47e4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7c9175 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c39cc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a95f4f8 View commit details
    Browse the repository at this point in the history
  5. Remove 'Create Rule' button from Rule Group page (#164167)

    issue: #163462
    
    ## Summary
    
    Change of plan. We are going to delete the button.
    
    ~Disable the 'Create Rule' button on the Rule Group page and add the
    read icon to the topbar when the user is on read mode.~
    Delete 'Create Rule' button on the Rule Group page
    
    ### How to reproduce it
    * ~Create a role with read access to the security solution feature~
    * ~Login with a user that has the created role~
    * Open the rule group page
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    machadoum authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9aafd1f View commit details
    Browse the repository at this point in the history
  6. [DOCS] Saved objects - resolve import errors API (#162825)

    ## Summary
    
    Relates to #137240
    
    This PR aims to draft openAPI specifications for [Resolve import errors
    API](https://www.elastic.co/guide/en/kibana/current/saved-objects-api-resolve-import-errors.html).
    
    ---------
    
    Co-authored-by: Alejandro Fernández Haro <[email protected]>
    Co-authored-by: Kibana Machine <[email protected]>
    3 people authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f7e36a9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    227fc09 View commit details
    Browse the repository at this point in the history
  8. [Fleet] Only show agent dashboard links if there is more than one non…

    …-server agent and if the dashboards exist (#164469)
    
    ## Summary
    
    Closes #161827
    
    These buttons were showing in cloud when there was only the cloud agent
    added:
    
    <img width="647" alt="Screenshot 2023-08-22 at 16 18 51"
    src="https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15">
    
    The ingest dashboard links will now only show if:
    
    - the user has one agent that is not part of a policy containing fleet
    server (I have re-used an existing hook we have to check this here)
    - the agent ingest metrics dashaboard exists in the current space
    
    Test Scenarios
    
    1. Setup fleet with ONLY a fleet server connected, the dashboard links
    should not show
    2. Setup fleet with fleet server and another non-fleet server agent, the
    dashboard links should show
    3. With the same setup as test case 2, now create another space, visit
    fleet in the new space, the links should not show as the dashboards are
    not installed in the current space.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [x] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    hop-dev and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    805c974 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    054cdba View commit details
    Browse the repository at this point in the history
  10. [Security Solution] Fix flaky Event Filters test (#164473)

    ## Summary
    
    Fix flaky test for Event Filters and re-enable. Also, needed to adjust a
    Blocklist test for a previous bugfix that was missed because the suite
    was skipped.
    
    Flaky test runner:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2952
    
    Closes: #163140
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    kevinlog authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2dc4e43 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f4f286f View commit details
    Browse the repository at this point in the history
  12. Prepare the Security domain HTTP APIs for Serverless (#162087)

    Closes #161337
    
    ## Summary
    
    Uses build flavor(see #161930) to disable specific Kibana security,
    spaces, and encrypted saved objects HTTP API routes in serverless (see
    details in #161337). HTTP APIs that will be public in serverless have
    been handled in #162523.
    
    **IMPORTANT: This PR leaves login, user, and role routes enabled. The
    primary reason for this is due to several testing mechanisms that rely
    on basic authentication and custom roles (UI, Cypress). These tests will
    be modified to use SAML authentication and serverless roles in the
    immediate future. Once this occurs, we will disable these routes.**
    
    ### Testing
    This PR also implements testing API access in serverless.
    - The testing strategy for disabled routes in serverless is to verify a
    `404 not found `response.
    - The testing strategy for internal access routes in serverless is to
    verify that without the internal request header
    (`x-elastic-internal-origin`), a `400 bad request response` is received,
    then verify that with the internal request header, a `200 ok response`
    is received.
    - The strategy for public routes in serverless is to verify a `200 ok`
    or `203 redirect` is received.
    
    ~~blocked by #161930~~
    ~~blocked by #162149 for test implementation~~
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    Co-authored-by: Aleh Zasypkin <[email protected]>
    Co-authored-by: Aleh Zasypkin <[email protected]>
    4 people authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fe0ffab View commit details
    Browse the repository at this point in the history
  13. [Security Solution][Endpoint] Fixes kibana crash when going back to p…

    …olicy details page (#164329)
    
    Fixes: #164295
    Fixes: #164190
    
    ## Summary
    There was a Kibana crash when using back link buttons to go back to the
    policy details page from Trusted Apps / Event Filters / Host Isolation
    exceptions / Blocklists page. Route state can be null depending on the
    previous action so it has to be conditional.
    
    The error occurs when it tries to access the `backLink` prop on
    `routeState` when it's not defined.
    
    Co-authored-by: Kibana Machine <[email protected]>
    dasansol92 and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fb79e3e View commit details
    Browse the repository at this point in the history
  14. [Defend Workflows]Changes to policy settings are not persistent until…

    … a refresh (#164403)
    
    Closes elastic/security-team#7386
    
    Dispatch an action that will update the stored policy upon successful
    saving of Policy Settings. This should occur only when no 'routeState'
    is being set, as in such a scenario, a page change triggers a refetch on
    its own.
    
    Even though redux was removed from Policy Settings in
    #161511 , the policy object that
    feeds the view is being fetched as a result of onUrlChange action and
    stored in the redux store. This should be addressed in the future.
    
    
    https://github.com/elastic/kibana/assets/29123534/cf008d0e-804a-49f9-a2f7-9bb7d1162b28
    szwarckonrad authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5eca861 View commit details
    Browse the repository at this point in the history
  15. [ML] Fixes dark mode in flyouts and modals (#164399)

    A recent EUI change has caused a problem with the theme when using the
    deprecated `toMountPoint` inside `overlays.openFlyout` to create
    flyouts.
    This causes the contents of the rendered flyout to not know the current
    theme, this is obvious when running in dark mode.
    
    The fix is to switch to the non-deprecated version of `toMountPoint`.
    
    Flyouts:
    Create anomaly detection job from Lens flyout in Dashboard.
    Anomaly swim lane and anomaly chart job embeddables job selection flyout
    in Dashboard.
    Log pattern analysis flyout in Discover.
    
    Modals:
    Trained models start deployment modal.
    Trained models force stop deployment modal.
    Trained models stop deployment modal when there are multiple
    deployments.
    
    Misc:
    Page not found banner.
    Jobs list header, which contains the settings button.
    DFA clone job warning toast when the original data view no longer
    exists.
    Components in ml's date picker package
    
    Fixes #164379
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    Co-authored-by: Dima Arnautov <[email protected]>
    3 people authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    af440aa View commit details
    Browse the repository at this point in the history
  16. Fix 7.17 forward compatibility with 8.2+ (#164274)

    ## Summary
    
    Forward-ports #164043 to `main`
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    rudolf authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9a77123 View commit details
    Browse the repository at this point in the history
  17. [Fleet] copy inactivity_timeout when duplicating agent policy (#164544

    )
    
    ## Summary
    
    Closes #164532 
    
    `inactivity_timeout` and a lot of other properties on the agent policy
    saved object were not being copied over when duplicating an agent
    policy.
    
    The other properties that are now duplicated when cloning an agent
    policy are :
    
    - `inactivity_timeout` 
    - `unenroll_timeout` 
    - `agent_features` - this contains the hostname mode 
    - `overrides` 
    - `data_output_id` 
    - `monitoring_output_id` 
    - `download_source_id` 
    - `fleet_server_host_id`
    
    Automated test added.
    hop-dev authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ce2c18d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    9d909cd View commit details
    Browse the repository at this point in the history
  19. Fixes unnecessary autocompletes on HTTP methods (#163233)

    ## Summary
    
    This PR,,,
    1. fixes #156254
    2. fixes #120606 differently from
    #121033
    3. fixes #19961 differently from
    #121033
    
    #### [1] left=PR / right=8.9.0
    
    
    ![fix-156254](https://github.com/elastic/kibana/assets/721858/d3340ed9-44a1-4862-a48c-4548d69090dc)
    
    #### [2] left=PR / right=8.9.0
    
    
    ![fix-120606](https://github.com/elastic/kibana/assets/721858/2d282392-e280-44d8-aa5c-2cb042f32e14)
    
    #### [3] left=PR / right=8.9.0
    
    
    ![fix-19961](https://github.com/elastic/kibana/assets/721858/9d9808d6-727d-4637-a48f-6dda520b38b0)
    
    <details>
    <summary>Original description</summary>
    
    1. fixes #156254
    2. refixes #120606 - which should stay closed
    3. unfixes #19961 - which must be reopened or duplicated after merging
    this PR
    
    #### [1] left=PR / right=8.9.0
    
    
    ![fix-156254](https://github.com/elastic/kibana/assets/721858/5ec5162e-7942-4068-ace3-65592f3fe8da)
    
    #### [2] left=PR / right=8.9.0
    
    
    ![refix-120606](https://github.com/elastic/kibana/assets/721858/fddd3212-5c57-4c6a-af01-f70e9f7ec644)
    
    _Autocomplete starts if the method is all uppercase or all lowercase; it
    doesn't with mixed cases such as `Get`, `gET`, etc. anymore._
    
    #### [3] left=PR / right=8.9.0
    
    
    ![unfix-19961](https://github.com/elastic/kibana/assets/721858/32562ca4-bfc0-4803-9a38-009d8dc6bc45)
    
    _Autocomplete no longer starts on first typing `_` after `url.slash`. No
    simple solution makes me leave this issue unfixed._
    
    </details>
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    
    ### For maintainers
    
    - [x] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ### Other notes
    
    - `backport:skip` because #156254 is not applicable to 7.x.
    - ~~The release note doesn't need to mention the unfix of #19961 because
    #121033 mentioned it as `other related bug` only.~~
    
    ### Release note
    
    Fixes unnecessary autocompletes on HTTP methods
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    sakurai-youhei and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fade57d View commit details
    Browse the repository at this point in the history
  20. [Security Solution] [Endpoint] Convert hash values to lower case for …

    …Blocklist (#164472)
    
    Fixes: #164373
    ## Summary
    
    - Converts Blocklist hash values to lower case in UI (same thing we
    already do for Trusted Apps).
    - Fixes test cases (FTR and Cypress).
    dasansol92 authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1cdcb84 View commit details
    Browse the repository at this point in the history
  21. [RAM] fix find with the post endpoint supertests (#164528)

    Solve this issue: #148660
    
    Fix flaky 'find with post' rule endpoint supertests.
    
    Tested using this tool:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2963
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    guskovaue and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    615c450 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    a14f76d View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    58b4104 View commit details
    Browse the repository at this point in the history
  24. [Fleet] Make fetch installed packages test assertions more granular (#…

    …164567)
    
    ## Summary
    
    For investigating #163203 I want
    to double check which package is not being returned.
    hop-dev authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    40ba6b6 View commit details
    Browse the repository at this point in the history
  25. Allow Kibana to restrict the usage of JWT for a predefined set of rou…

    …tes only. (#163806)
    
    ## Summary
    
    Allow Kibana to restrict the usage of JWT for a predefined set of routes
    only in Serverless environment by default. This capability is not
    available in non-Serverless environment.
    
    Any route that needs to be accessed in Serverless environemnt using JWT
    as a means of authentication should include `security:acceptJWT` tag.
    
    ## How to test
    
    If you'd like to generate your own JWT to test the PR, please follow the
    steps outlined in
    #159117 (comment) or just
    run functional test server and use static JWT from the Serverless test.
    
    This PR also generated a Serverless Docker image that you can use in
    your Dev/QA MKI cluster.
    
    - [x] Implementation functionality and add unit tests
    - [x] Update metrics/status routes to include new `security:acceptJWT`
    tag
    - [x] Update serverless test suite to include a test for
    `security:acceptJWT`
    
    __Fixes: https://github.com/elastic/kibana/issues/162632__
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    azasypkin and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5aee5da View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    eda1406 View commit details
    Browse the repository at this point in the history
  27. [Search] Add missing salesforce connector tile and docs link (#164543)

    ## Summary
    
    Add connector tile and docs link for Salesforce connector.
    Salesforce already exists as a connector type so only adding the tile
    seems to be required.
    Documentation link goes to
    https://www.elastic.co/guide/en/enterprise-search/8.10/connectors-salesforce.html
    navarone-feekery authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    dd0938b View commit details
    Browse the repository at this point in the history
  28. [RAM] Type safety for RegistryRuleType (#164516)

    ## Summary
    
    RegisterRuleType was not representing its definition correctly and the
    type was not safe. So updated the code/type to avoid missing attribute
    and functionality. Now summary alert is back
      
    
    ![image](https://github.com/elastic/kibana/assets/189600/95cb786a-7ab9-4d40-a65c-ecbe59a0fbd3)
    
    
    ### Checklist
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    XavierM authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0d85af2 View commit details
    Browse the repository at this point in the history
  29. Prepare the connector GetAll API for versioning (#162799)

    Part of: elastic/response-ops-team#125
    
    This PR intends to prepare the `GET ${BASE_ACTION_API_PATH}/connectors`
    API for versioning as shown in the above issue.
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    ersin-erdal and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d65b02c View commit details
    Browse the repository at this point in the history
  30. [Cloud Security] do not filter out vulnerabilities without the score …

    …field (#163949)
    
    ## Summary
    
    as a part of an effort to remove the vulnerability documents filter in
    elastic/security-team#7146 this PR removes the
    filter for missing `vulnerabiltiy.score.*` fields.
    
    Here is how the CNVM features look like when documents without these
    fields are present
    
    <img width="1728" alt="Screenshot 2023-08-15 at 17 54 28"
    src="https://github.com/elastic/kibana/assets/478762/0cec1eae-7429-4752-a573-34fcd73fcfed">
    <img width="1728" alt="Screenshot 2023-08-15 at 17 53 54"
    src="https://github.com/elastic/kibana/assets/478762/775569c5-118d-42dd-8ab1-9974996b3613">
    <img width="1439" alt="Screenshot 2023-08-15 at 17 54 56"
    src="https://github.com/elastic/kibana/assets/478762/0e98d51f-1732-408f-bffa-758295e953e6">
    <img width="719" alt="Screenshot 2023-08-15 at 17 54 49"
    src="https://github.com/elastic/kibana/assets/478762/ebd3b24b-45a5-47e4-a11b-181a415df9aa">
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    maxcold and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    443283c View commit details
    Browse the repository at this point in the history
  31. [Security Solution] Expandable flyout - update flyout header (#164514)

    ## Summary
    
    This PR addresses a name mismatch mentioned in
    #164398.
    
    - Flyout header in non-alerts page are updated to "Event details" to
    match previous flyout header
    - Fixed timestamp position to align with header
    
    Before
    
    ![image](https://github.com/elastic/kibana/assets/18648970/b718beac-74d2-40fd-baf9-9c59aad6a46a)
    
    After
    
    
    ![image](https://github.com/elastic/kibana/assets/18648970/1e9b4e5a-ac18-4d8a-a732-458811942d1a)
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    christineweng authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3b6c2c2 View commit details
    Browse the repository at this point in the history
  32. [Security Solution] Reduce Rules Management e2e flakiness (#164099)

    **Relates to: #161507
    **Fixes: #163704
    **Fixes: #163182
    **Fixes: #163558
    **Fixes: #163974
    **Fixes: #153914
    **Fixes: #164079
    **Fixes: #164279
    
    ## Summary
    
    While working on fixing Rules Management flaky tests I've noticed similar fails in different tests. This PR addresses common pitfalls to reduce a number of reasons causing e2e tests flakiness and as a result reduce a number of flaky tests.
    
    ## Details
    
    The common reasons causing e2e tests flakiness for the rules tables are
    
    - Auto-refresh
    
    Auto-refresh functionality is enabled by default and the table gets auto-refreshed every 60 seconds. If a test takes more than 60 seconds the table fetches updated rules. Having rules enabled by default and sorted by `Enabled` column makes the sorting order undetermined and as rules get updated due to execution ES return them in undetermined order. This update can happen between commands working on the same element and indexed access like `eq()` would access different elements. 
    
    - Missing selectors
    
    Some tests or helper functions have expectations for an element absence like `should('not.exist')` without checking an element is visible before like `should('be.visible')`. This way a referenced element may disappear from the codebase after refactoring and the expectation still fulfils.
    
    - Checking for `should('not.visible')` while an element is removed from the DOM
    
    It most applicable to popovers as it first animates to be hidden and then removed from the DOM. Cypress first need to find an element to check its visibility. Replacing `should('not.visible')` with `should('not.exist')` and taking into concern from the account previous bullet fixes the problem.
    
    - Modifying ES data without refreshing (`_delete_by_query` in particular)
    
    Due to high performance ES architecture data isn't updated instantly. Having such behavior in tests leads to undetermined state depending on a number of environmental factors. As UI doesn't always auto-refreshes to fetch the recent updates in short period of time test fail. `_delete_by_query` may take some time to update the data but it doesn't support `refresh=wait_for` as it stated in [docs](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#_refreshing_shards). Adding `?refresh=true` or just `?refresh` to `_delete_by_query` ES request urls fixes the problem.
    
    ### What was done to address mentioned reasons above?
    
    - Auto-refresh functionality disabled in tests where it's not necessary.
    - `enabled: false` field was added to rule creators to have disabled rules as the majority of tests don't need enabled rules.
    - `waitForRulesTableToBeLoaded` was removed and replaced with `expectManagementTableRules` at some tests.
    - `should('not.visible')` replaced with `should('not.exist')` in `deleteRuleFromDetailsPage()`
    - `?refresh` added to `_delete_by_query` ES data update requests
    
    The other changes get rid of global constants and improve readability.
    
    ## Flaky test runs
    
    [All Cypress tests under `detection_response` folder (100 runs)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2920) (value lists export is flaky but it's out of scope of this PR)
    maximpn authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    40df521 View commit details
    Browse the repository at this point in the history
  33. [Index Management] Index details page: loading index data (#163955)

    ## Summary
    Follow up to #163521
    
    - A new internal api endpoint to load index data for a single index
    specified by the index name
    - An api service to send a request to the new endpoint
    - A loading and an error state on the new index details page
    - A "back to all indices" button
    - A button with the link to Discover
    - A context menu with index actions (only popover with options is
    displayed, but the actions are not implemented yet)
    
    ### Screenshots 
    
    <img width="1143" alt="Screenshot 2023-08-23 at 14 31 26"
    src="https://github.com/elastic/kibana/assets/6585477/06c3eea5-8d35-4c09-9274-fe545bde60ae">
    
    
    <img width="740" alt="Screenshot 2023-08-22 at 17 43 13"
    src="https://github.com/elastic/kibana/assets/6585477/11433e81-ef21-43b8-83b4-9c6b4c1c7579">
    
    <img width="644" alt="Screenshot 2023-08-22 at 17 42 30"
    src="https://github.com/elastic/kibana/assets/6585477/f6649029-af31-47d2-ba6d-4632c0c5b146">
    
    
    ### How to test
    1. Add `xpack.index_management.dev.enableIndexDetailsPage: true` to your
    `/config/kibana.dev.yml` file
    2. Start ES and Kibana with `yarn es snapshot` and `yarn start`
    3. Add at least 1 sample data test
    4. Navigate to Index Management and click the name of any index
    5. Check that the button "back to indices" works (navigates back to the
    indices list)
    6. Check that the button "discover index" works (navigates to Discover)
    7. Check that the button "manage index" opens the context menu (_note:
    index actions are not implemented yet_)
    8. Check that there is a loading indicator (by adding throttle in the
    Network tab of Chrome Dev tools)
    9. Check that the error section is displayed and the "reload" button
    resends a request (by blocking the request in the Network tab of Chrome
    Dev Tools)
    
    ### Checklist
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    yuliacech and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    79178ca View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    bd24560 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    03efa64 View commit details
    Browse the repository at this point in the history
  36. [RAM] Make Global Event Log Shareable (#163668)

    ## Summary
    Resolves: #161788
    
    Makes the global event log shareable. Plus some refactors like
    converting the `rule_event_log_list_table` fetch to use React Query.
    
    Also, fixed a bug with the `rule_status_panel` where we did not refresh
    if the parent component refreshed.
    
    ### Checklist
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    JiaweiWu and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ba96a72 View commit details
    Browse the repository at this point in the history
  37. [Discover] Unskip SQL functional tests (#164396)

    ## Summary
    
    Unskipping these tests after running flaky test runner 150x:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2964
    kertal authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1f00484 View commit details
    Browse the repository at this point in the history
  38. [RAM] Fix flaky legacy alerts test suite (#164515)

    ## Summary
    
    Closes #159124
    Closes #159123
    
    It looks like removing an `async` from a function that didn't actually
    `await` anything fixed a flaky Promise execution. Flaky test runner
    succeeds on this branch:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2957#018a1ef8-6514-4abe-a55c-cbe646bf64a2
    
    ### Checklist
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    Zacqary authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    83d27aa View commit details
    Browse the repository at this point in the history
  39. [Cloud Security] CODEOWNERS update (#164522)

    ## Summary
    
    This fixes some missed spots when I changed CODEOWNERS in this PR:
    #164122
    
    Forgot to update all the kibana.jsonc files, so CI overwrote my changes
    in CODEOWNERS :)
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    mitodrummer and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a95abde View commit details
    Browse the repository at this point in the history
  40. [Serverless Search] Updating doc links (#164354)

    ## Summary
    
    - Updating serverless search doc links, specifically replacing client
    links to the upcoming serverless client docs.
    - Updated the github repo links for clients to the language definition
    and set them to the serverless client repos
    - Removed the "Advanced Configuration" links from the getting started
    page, we wont have these pages for M0
    - Used the cloud urls for invite users and billing
    TattdCodeMonkey authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    da394f9 View commit details
    Browse the repository at this point in the history
  41. skip flaky suite (#164584)

    mistic committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c207694 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    841c56c View commit details
    Browse the repository at this point in the history
  43. skip flaky suite (#163195)

    mistic committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8b1d5f6 View commit details
    Browse the repository at this point in the history
  44. unskip flaky feature registry test for kibana_overview page (#164116)

    ## Summary
    
    Closes #135182
    
    Test config: `test/functional/apps/kibana_overview/config.ts`
    Test runner: 
    *
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2960
    *
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2968
    (after code review feedback)
    
    This PR updates the FeatureCatalogue registry class with the addition of
    a `getFeatures$()` method. This helps the Analytics Overview app receive
    the latest state of the registry, after multiple updates:
    
    * Graph app waits until the license information is available before
    removing its feature from the registry if the license is not Platinum
    * ML app also waits until the license information is available before
    registering its feature into the registry.
    
    ---------
    
    Co-authored-by: Sébastien Loix <[email protected]>
    tsullivan and sebelga authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f029a67 View commit details
    Browse the repository at this point in the history
  45. skip flaky suite (#163194)

    mistic committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0c39bc8 View commit details
    Browse the repository at this point in the history
  46. skip flaky suite (#163193)

    mistic committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bf2a826 View commit details
    Browse the repository at this point in the history
  47. skip flaky suite (#163192)

    mistic committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    44f87a4 View commit details
    Browse the repository at this point in the history
  48. Exclude disabled tasks from task manager health API and Stack Monitor…

    …ing (#164444)
    
    Resolves #163958.
    Resolves #163023.
    
    In this PR, I'm modifying the task store's aggregate function to exclude
    tasks that are disabled. This function is only used by the monitoring
    functionality of alerting and actions plugin and the Task Manager's
    health API which all experienced bugs where they shouldn't be
    considering disabled task types.
    
    ## To verify
    
    1. Create 20 alerting rules running every 1s
    2. Call the `/api/task_manager/_health` endpoint
    3. Notice capacity_estimation stats are changing to accomodate 20 rules
    constantly running
    4. Disable all the alerting rules
    5. Call the `/api/task_manager/_health` endpoint (wait for runtime and
    workload stats to update by looking at their timestamp and ensuring it's
    after the time you disabled the rules)
    6. Notice capacity_estimation stats no longer consider the 20 rules that
    use to run constantly
    mikecote authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    140c71a View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    2564be1 View commit details
    Browse the repository at this point in the history
  50. Make saved queries shareable between spaces (#163436)

    ## Summary
    
    See #127027. Makes saved queries
    shareable.
    
    Still to do (see
    https://www.elastic.co/guide/en/kibana/master/sharing-saved-objects.html#sharing-saved-objects-phase-2):
    
    - [x] Since saved queries can be deleted from the search bar (outside of
    management), we need to make sure to warn the end user if it is shared
    between spaces and send the `force: true` parameter.
    
    ### Release note
    
    Saved queries can now be shared between multiple spaces.
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    lukasolson and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d29f7f5 View commit details
    Browse the repository at this point in the history
  51. [Security Solution] Notify user is always the text for notify checkbox (

    #164357)
    
    ## Summary
    
    Reverts a change to keep the text for `user notification` checkbox in
    Policy to be the same regardless of value.
    
    In the screenshot below, see how "Notify user" text will always be the
    same instead of changing to "Don't notify user" when unchecked.
    
    <img width="1724" alt="image"
    src="https://github.com/elastic/kibana/assets/56395104/bcb588b5-cb4d-4061-9068-42de80a5101f">
    
    <img width="1728" alt="image"
    src="https://github.com/elastic/kibana/assets/56395104/fce984c3-3ebe-4261-b823-4621b16bc094">
    
    Before, the text would change to "Don't notify user"
    
    <img width="1040" alt="image"
    src="https://github.com/elastic/kibana/assets/56395104/da43b55e-5d25-4422-8a27-12263d57df8a">
    
    ### Checklist
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    kevinlog and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b181e48 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    154ca40 View commit details
    Browse the repository at this point in the history
  53. [Security Solution][Detection Engine] move lists to data stream (#162508

    )
    
    ## Summary
    
    - addresses elastic/security-team#7198
    - moves list/items indices to data stream
      - adds `@timestamp` mapping to indices mappings
    - migrate to data stream if indices already exist(for customers < 8.11)
    or create data stream(for customers 8.11+ or serverless)
    - adds
    [DLM](https://www.elastic.co/guide/en/elasticsearch/reference/8.9/data-streams-put-lifecycle.html)
    to index templates
    - replaces update/delete queries with update_by_query/delete_by_query
    which supported in data streams
      - fixes existing issues with update/patch APIs for lists/items
        - update/patch for lists didn't save `version` parameter in ES
    - update and patch APIs for lists/items were identical, i.e. for both
    routes was called the same `update` method w/o any changes
    
    <details>
    
    <summary>Technical detail on moving API to
    (update/delete)_by_query</summary>
    
    
    `update_by_query`, `delete_by_query` do not support refresh=wait_for,
    [only false/true
    values](https://www.elastic.co/guide/en/elasticsearch/reference/8.9/docs-update-by-query.html#_refreshing_shards_2).
    Which might break some of the use cases on UI(when list is removed, we
    refetch all lists. Deleted list will be returned for some time. [Default
    refresh time is
    1s](https://www.elastic.co/guide/en/elasticsearch/reference/8.9/docs-refresh.html)).
    So, we retry refetching deleted/updated document before finishing
    request, to return reindexed document
    
    `update_by_query` does not support OCC [as update
    API](https://www.elastic.co/guide/en/elasticsearch/reference/8.9/optimistic-concurrency-control.html).
    Which is supported in both
    [list](https://www.elastic.co/guide/en/security/current/lists-api-update-container.html)/[list
    item
    ](https://www.elastic.co/guide/en/security/current/lists-api-update-item.html)updates
    through _version parameter.
    _version is base64 encoded "_seq_no", "_primary_term" props used for OCC
    
    So, to keep it without breaking changes: implemented check for version
    conflict within update method
    </details>
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    vitaliidm and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    505d826 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    4686472 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    e651a6f View commit details
    Browse the repository at this point in the history
  56. Add support for geo_shape fields as the entity geospatial field when …

    …creating tracking containment alerts (#164100)
    
    Closes #163996
    
    ### To test
    1) Checkout [fake tracks geo_shape
    branch](https://github.com/nreese/faketracks/tree/geo_shape)
    2) run npm install
    3) run `node ./generate_tracks.js`
    4) in kibana, create `tracks*` data view
    5) create map, use "create index" and draw boundaries that intersect
    tracks. See screen shot
    <img width="500" alt="Screen Shot 2023-08-17 at 2 49 52 PM"
    src="https://github.com/elastic/kibana/assets/373691/5f1444d7-2e12-4dd2-99c1-c730c2157e04">
    6) create geo containment alert where entity index is `tracks*` and
    boundaries index is `boundaries`.
    7) Verify alerts get generated with entity geo_shape locations
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    nreese and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3393d87 View commit details
    Browse the repository at this point in the history
  57. [Search] Set up empty connectors page (#164340)

    This adds an empty connectors page to the Elasticsearch project. The
    Enterprise Search plugin exports relevant connectors data and functions,
    the Search plugin simply consumes these.
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    sphilipse and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7df5672 View commit details
    Browse the repository at this point in the history
  58. [Discover] Removing large string truncation from doc viewer (#164236)

    ## Summary
    
    Closes #62920
    
    
    ![image](https://github.com/elastic/kibana/assets/1280964/a1f07fe3-be6c-47c8-81e3-4ee8767ed426)
    
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [x] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    timductive and kibanamachine authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d12b2b7 View commit details
    Browse the repository at this point in the history
  59. [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#…

    …164382)
    
    ## Summary
    
    Resolves #159374 by ensuring
    that if a user doesn't have the appropriate `Connectors & Actions`
    privileges, they will be shown the appropriate messaging and any UI
    controls for adding Connectors will be disabled or unavailable.
    
    #### Connectors and Actions `NONE` or Connectors and Actions `READ` if
    *NO* existing connectors exist:
    
    <p align="center">
    <img width="500"
    src="https://github.com/elastic/kibana/assets/2946766/d9535ae9-a31e-499b-9b18-6004e3db64de"
    />
    </p> 
    
    #### Connectors and Actions `READ` if existing connector count > 0:
    
    `Add Connector...` option isn't available:
    
    <p align="center">
    <img width="500"
    src="https://github.com/elastic/kibana/assets/2946766/bd6a06a7-ffa2-4cfc-a2b7-844da99cb171"
    />
    </p> 
    
    <p align="center">
    <img width="500"
    src="https://github.com/elastic/kibana/assets/2946766/4681086e-1015-45b9-9afb-ff604c52cd38"
    />
    </p> 
    
    
    
    Also addresses:
    
    * Fixes disabled state of header connector selector for setup flows.
    * Adds `AssistantAvailability` interface to `AssistantContext` for
    exposing ui feature controls like `Connectors & Actions` privileges.
    * Hides `Add new connector...` option if user doesn't have `ALL`
    `Connectors & Actions` privileges.
    * Hoists dependencies from `assistant/index.tsx` to `connector_setup` as
    it was already fetching dependencies from `useAssistantContext`.
    
    Note: `ConnectorButton` and `ConnectorMissingCallout` should probably be
    combined into a single component and show appropriate messaging given
    the user's `Connectors & Actions` privileges. I kept them separate for
    now as to not modify the control flow around the two components (till we
    can further refactor `assistant/index.tsx`), which means the missing
    connector callout is sort of doing double duty at the moment.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [X] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [X] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    spong authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    db7ac1b View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    a3f6403 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    fb0d022 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    5d5ac37 View commit details
    Browse the repository at this point in the history
  63. Upgrade EUI to 87.2.0 (#164385)

    `87.1.0` ➡️ `87.2.0`
    
    ## [`87.2.0`](https://github.com/elastic/eui/tree/v87.2.0)
    
    - `EuiResizableButton` is now available as a generic top-level export
    ([#7087](elastic/eui#7087))
    - Added new `alignIndicator` prop to `EuiResizableButton`. Defaults to
    `center`, and can now additionally be configured to `start` and `end`
    ([#7087](elastic/eui#7087))
    - Updated `useGeneratedHtmlId` hook to use `React.useId` as the source
    of unique identifiers when available
    ([#7095](elastic/eui#7095))
    
    **CSS-in-JS conversions**
    
    - Converted `EuiResizableButton` to Emotion; Removed
    `$euiResizableButtonTransitionSpeed` and `$euiResizableButtonSize`
    ([#7081](elastic/eui#7081))
    - Converted `EuiResizableCollapseButton` to Emotion
    ([#7091](elastic/eui#7091))
    
    ---------
    
    Co-authored-by: Cee Chen <[email protected]>
    breehall and cee-chen authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    950ac6e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. [APM] Cleanup alerting api tests (#164438)

    This PR cleans up and refactors the APM API tests for rules and
    alerting.
    
    - introduces some new helper methods like `deleteRuleById`
    - removes dependency on index actions to test alerts (we can just use
    the alert index)
    - improve flaky tests and ensure that tests can be run in isolation and
    in any order
    sorenlouv authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d440288 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    656e783 View commit details
    Browse the repository at this point in the history
  3. [Security Solution] Modal says "duplicating 0 rules" when you duplica…

    …te an individual rule (#163908)
    
     ## What does this PR do?
     * It fixes the count on the duplicate modal when duplicating an individual rule.
     
     ## Issue References
    Fixes #162035
     
     ## Video/Screenshot Demo
     ##### Steps to reproduce & Fix:
    https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9
    
    ___
     
     This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.
    gitstart authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    59f2058 View commit details
    Browse the repository at this point in the history
  4. [Fleet] Fix security solution tag id (#164582)

    Related to #152814
    
    ## Summary
    
    Fix for a bug found in #162643 :
    The security solution tag is actually created with "Security Solution"
    name and "security-solution-default" id (instead of `SecuritySolution`):
    
    ```
       {
            "id": "security-solution-default",
            "name": "Security Solution",
            "description": "",
            "color": "#D36086"
        }
    ```
    
    I found that in same cases the tag is duplicated, since[ is not created
    with an unique
    id](https://github.com/elastic/kibana/blob/dd0938bea3ebd745a49ac164a7a5f053ba6a138b/x-pack/plugins/security_solution/public/dashboards/containers/use_fetch_security_tags.ts#L44-L51):
    
    <img width="3079" alt="Screenshot 2023-08-23 at 15 07 09"
    src="https://github.com/elastic/kibana/assets/16084106/ef885d8f-2e68-4695-aa14-1adc2e326ab0">
    
    I think it's acceptable to use the "security-solution-default", at least
    it will create the correct tag name.
    
    ### Test
    For testing I used a package built locally that uses the `Security
    Solution` tag
    The steps are the same as described in
    #162643
    
    - Additionally, check that the `tags` endpoint in the Tags page has name
    and id as described above:
    <img width="2521" alt="Screenshot 2023-08-23 at 14 55 05"
    src="https://github.com/elastic/kibana/assets/16084106/48b3ddd0-3d04-4ff6-8a24-946902687b13">
    criamico authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    da8d3b2 View commit details
    Browse the repository at this point in the history
  5. [Fleet] Add secrets package API integration test (#164583)

    ## Summary
    
    Closes #162045
    
    This PR adds an API integration test for the following scenario:
    - Given an integration with some non secret (plain text) vars that
    become secret in a newer version;
    - When Fleet has an agent policy with this integration and upgrades from
    the old to the newer version;
    - Then the vars that have become secrets should correctly be stored as
    secret values.
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Julia Bardi <[email protected]>
    jillguyonnet and juliaElastic authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    766ff8f View commit details
    Browse the repository at this point in the history
  6. [ML] Removing token list from text expansion model testing (#164560)

    The tokens listed could contain sensitive words which we do not want to
    display to the user, in case they cause offence.
    For now we can just hide this list, in case a future version of the API
    contains a sanitised list of tokens.
    jgowdyelastic authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    323878e View commit details
    Browse the repository at this point in the history
  7. [Cases] Show warning when all cases table reaches 10k cases message (#…

    …164323)
    
    ## Summary
    
    Fixes #154625
    
    _**Note:**_ Cases max limit is set as 40 for below recording:
    
    
    https://github.com/elastic/kibana/assets/117571355/2dda5460-2f6d-4d83-acf6-13ea93b11bac
    
    
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    
    ### For maintainers
    
    - [x] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ### Release Note:
    
    Show a warning message to inform user that navigating after the 10Kth
    case is not possible.
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    js-jankisalvi and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c00fc42 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    57a5824 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ad55946 View commit details
    Browse the repository at this point in the history
  10. [IndexManagement] Use internal base path for API (#164665)

    ## Summary
    
    The current API is returning 404 as the correct path is internal. This
    PR fixes this problem.
    dej611 authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    86224d4 View commit details
    Browse the repository at this point in the history
  11. [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (

    …#164673)
    
    ## Summary
    
    Closes #164575.
    
    Bonus: also fix the bug where the warning goes under the policy revision
    I thought that looked a bit weird.
    
    Double bonus: Updated the create agent test script to be able to create
    outdated agents + to use nicer policy names so the table doesnt get
    messy
    
    Before:
    
    <img width="1237" alt="Screenshot 2023-08-24 at 10 10 58"
    src="https://github.com/elastic/kibana/assets/3315046/86a88ad6-a2c7-4f17-82bb-fe026d05d937">
    
    
    After:
    
    <img width="1244" alt="Screenshot 2023-08-24 at 10 09 53"
    src="https://github.com/elastic/kibana/assets/3315046/1cf76dd3-2e6a-4aa9-a004-109797f54c52">
    hop-dev authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1610e32 View commit details
    Browse the repository at this point in the history
  12. Create upselling package and implement EntityAnalytics serverless ups…

    …elling (#164136)
    
    UX: elastic/security-team#7310
    
    ## Summary
    
    * It creates an Upselling package to share the service and components
    between ESS and Serverless plugins
    * It implements upselling for entity analytics on serverless by
    replicating the ESS approach
    
    ESS
    <img width="1520" alt="Screenshot 2023-08-17 at 13 34 59"
    src="https://github.com/elastic/kibana/assets/1490444/95c2c94e-7ab3-4d9f-aa24-b3e9c00eb3ed">
    
    Serverless
    <img width="1523" alt="Screenshot 2023-08-17 at 13 39 25"
    src="https://github.com/elastic/kibana/assets/1490444/618ce9dc-ef4e-469d-884a-dfb09834d0b0">
    
    We are not displaying the upgrade button because we still don't know how
    to link to the cloud settings page.
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    machadoum and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7564479 View commit details
    Browse the repository at this point in the history
  13. [SavedObjects] Create serverless roots for jest integration tests (#1…

    …64157)
    
    ## Summary
    
    Introduce basic utils for instantiating serverless servers ;). Also adds
    a simple smoke test (that is currently skipped) demonstrating usage.
    
    ## How to test
    
    Check this branch out locally, un`skip` the smoke test and run:
    
    ```
    yarn test:jest_integration ./src/core/server/integration_tests/saved_objects/serverless/migrations
    ```
    
    Note: the test cannot be unskipped as we are blocking on
    #162673 but we would like to
    prepare our tests so long --- they can be locally executed.
    
    ## Follow up
    
    * Create Jest integration tests using these helpers for all migration
    actions (see
    `packages/core/saved-objects/core-saved-objects-migration-server-internal/src/zdt/actions`
    and
    `packages/core/saved-objects/core-saved-objects-migration-server-internal/src/actions`).
    * Migrate our existing ZDT tests to run against serverless Elasticsearch
    
    ## Related
    
    #162673
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    jloleysens and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    178e201 View commit details
    Browse the repository at this point in the history
  14. [Security Solution][Detection Engine] fixes 410 error on index legacy…

    … template call (#164682)
    
    ## Summary
    
    `_template` API is [blocked on
    Serverless](https://docs.google.com/spreadsheets/d/16173D0-FP1UcSHKmZmhB7TbF_TyKtXrdiNWMjq5ASdM/edit#gid=0),
    causing 410 error when creating list index.
    
    This `_template` API is used to check existing legacy index templates
    for `lists` and `items` indices
    
    So, in this PR, we won't be throwing error if any of `_template` APIs
    called in Serverless environement and return `410` code error(Gone)
    vitaliidm authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7ee14bc View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b270602 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    631d9c2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    65573fc View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    37efbf3 View commit details
    Browse the repository at this point in the history
  19. [Security Solution][Endpoint] Split blocklist entry in multiple entri…

    …es when different hash types (#164599)
    
    Fixes: #164374
    ## Summary
    
    During fleet artifact generation, we split those blocklist entries that
    contains multiple hash types in it, so the resulting artifact contains
    an entry for each hash type. This is done for each blocklist if they
    contain multiple hash types in it.
    
    It also updates ftr test to ensure the resulting artifact is generated
    correctly.
    
    For a blocklist containing these hashes: 
    ```
    ['741462ab431a22233c787baab9b653c7', 'aedb279e378bed6c2db3c9dc9e12ba635e0b391c',  'a4370c0cf81686c0b696fa6261c9d3e0d810ae704ab8301839dffd5d5112f476']
    ```
    
    The artifact generated is:
    
    ```
    {
            entries: [
              {
                type: 'simple',
                entries: [
                  {
                    field: 'file.hash.md5',
                    operator: 'included',
                    type: 'exact_cased_any',
                    value: ['741462ab431a22233c787baab9b653c7'],
                  },
                ],
              },
              {
                type: 'simple',
                entries: [
                  {
                    field: 'file.hash.sha1',
                    operator: 'included',
                    type: 'exact_cased_any',
                    value: ['aedb279e378bed6c2db3c9dc9e12ba635e0b391c'],
                  },
                ],
              },
              {
                type: 'simple',
                entries: [
                  {
                    field: 'file.hash.sha256',
                    operator: 'included',
                    type: 'exact_cased_any',
                    value: ['a4370c0cf81686c0b696fa6261c9d3e0d810ae704ab8301839dffd5d5112f476'],
                  },
                ],
              },
            ]
    }
    ```
    
    Co-authored-by: Kibana Machine <[email protected]>
    dasansol92 and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6659376 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    0cfa3e2 View commit details
    Browse the repository at this point in the history
  21. [Flaky test #90578] Unskip test (#163696)

    Co-authored-by: Kibana Machine <[email protected]>
    afharo and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ba84388 View commit details
    Browse the repository at this point in the history
  22. [ci] Fix on-merge labels (#164459)

    Currently some on merge steps fetch labels from the merged pull request
    by parsing the first line of the commit message. This convention usually
    works, but it overlaps with the convention of skipping test suites
    linking to an issue instead of a pull request. Errors are thrown when a
    step attempts to pull metadata from an unset value.
    
    This sets a default value of an empty string if the label metadata is
    unset and cleans up the log message when an error occurs.
    
    Example error:
    https://buildkite.com/elastic/kibana-on-merge-unsupported-ftrs/builds/5821#018a1d62-fbd2-486d-afe3-9a448449bbf7/257-258
    jbudz authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    464f908 View commit details
    Browse the repository at this point in the history
  23. Fix Kibana fail to startup in Cypress (#164480)

    ## Summary
     
    - remove duplicated buildkite pipeline steps
    - remove concurrency from parallel that was causing flakiness
    - cleanup package.json scripts
    
    ---------
    
    Co-authored-by: Tiago Costa <[email protected]>
    patrykkopycinski and mistic authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    05cfa1a View commit details
    Browse the repository at this point in the history
  24. [DOCS] Saved objects - rotate key API (#162566)

    Co-authored-by: James Rodewig <[email protected]>
    Co-authored-by: lcawl <[email protected]>
    3 people authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ec84ce6 View commit details
    Browse the repository at this point in the history
  25. [Security Solution] Expandable flyout - add data view title and query…

    … bar to rule preview panel (#164650)
    
    ## Summary
    
    This PR adds `dataViewTitle` to rule preview panel -> define section
    when data view is available in a rule. This addresses
    #164529.
    
    **How to test**
    - Create a rule with data view
    - Generate some alerts, go to alerts page, pick a alert and open
    expandable flyout
    - Go to About, open `Rule summary`
    - Expand `Define` section, the content should match the define section
    in rule details page for that rule
    
    
    ![image](https://github.com/elastic/kibana/assets/18648970/30aeff6b-547a-4b68-be87-9b52ab58501b)
    
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    christineweng authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1bb4a52 View commit details
    Browse the repository at this point in the history
  26. RollingFileAppender: fix file moving mechanism (#164688)

    ## Summary
    
    On some file systems or volume mounts, `rename` is not supported and
    throws a `EXDEV` error, which breaks our file rolling.
    
    This PR addresses it by defaulting to `copy` + `unlink` if the `rename`
    calls fails with an `EXDEV` error.
    
    Co-authored-by: Kibana Machine <[email protected]>
    pgayvallet and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d16594f View commit details
    Browse the repository at this point in the history
  27. Qx 282 touchup qg (#164643)

    ## Summary
    
    The wrong file path was being given for the pipeline, this fixes that.  
    
    Also, the [serverless release end to end
    workflow](https://docs.google.com/document/d/15rx2Z-soL20An0nBUcXX0o_HHf1OU_IgrHXgz20NndI/edit)
    calls out some things that I missed on the first pass. Please refer to
    the "Kibana Release required testing" table.
    imkarrer authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f10b15a View commit details
    Browse the repository at this point in the history
  28. [Security Solution] Expandable flyout - exclude rule creation from us…

    …ing new flyout (#164653)
    
    ## Summary
    
    The alert flyout (expand button in data table) is available in a lot of
    places in the security app. When creating a new rule, in the rule
    preview section, there is an alert table where the flyout is present. In
    this scenario, the rule is not yet set up, sections like the rule
    summary and hover actions are not applicable in this state.
    
    This PR reverts the use of the new expandable flyout in the rule
    creation page -> rule preview section. This will revert the flyout to
    the older version and address bugs such as
    #164397
    
    
    **How to test**
    - First generate some alerts
    - Create a new rule and finish the first section
    - Click continue to go to the right (rule preview section)
    - Pick an alert and click expand
    - The old flyout should appear
    
    
    ![image](https://github.com/elastic/kibana/assets/18648970/7a025dd2-dc75-44ef-a13c-25e44b2502ed)
    
    
    ![image](https://github.com/elastic/kibana/assets/18648970/33d47eb1-6b6b-4314-8dae-cfff2956b1c4)
    christineweng authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c0ce046 View commit details
    Browse the repository at this point in the history
  29. [DOCS] Adds documentation for data comparison view (#164297)

    ## Summary
    
    Related PR: #161365
    Related issue: elastic/platform-docs-team#153
    
    This PR drafts documentation for the new data comparison feature under
    the Data Visualizer in Kibana.
    szabosteve authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e911038 View commit details
    Browse the repository at this point in the history
  30. [Fleet] set typeMigrationVersion instead of migrationVersion (#164712)

    ## Summary
    
    Fix #164690
    
    `migrationVersion` was removed from es mapping in 8.8:
    #154246
    Replacing it with `typeMigrationVersion` using the same logic as in
    kibana core:
    
    https://github.com/elastic/kibana/blob/ba843882a7bb35aa3062efd6562ed85d5db157f4/packages/core/saved-objects/core-saved-objects-migration-server-internal/src/document_migrator/migrations/transform_migration_version.ts#L17
    
    
    To verify:
    - add Kubernetes integration to a new policy
    - verify that it is added successfully
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    juliaElastic authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0146dc8 View commit details
    Browse the repository at this point in the history
  31. [Security Solution] Migrate rules management API to versioned router (#…

    …163628)
    
    **Resolves:**
    [elastic/security-team#6949](elastic/security-team#6949)
    
    ## Summary
    
    This PR migrates all HTTP Endpoints under the ownership of
    @elastic/security-detection-rule-management to the [versioned
    router](https://docs.elastic.dev/kibana-dev-docs/versioning-http-apis#use-the-versioned-router).
    
    - Endpoints that are documented and start with `/api` were marked as
    `access: 'public'`. So in production, if accessed without the version
    header, they will be automatically resolved to the latest available
    version.
    - Endpoints that start with `/internal` are now flagged as `access:
    'internal'`, implying a special origin header is needed to access them
    in a Serverless environment. The version header (`'elastic-api-version':
    '1'`) should always be provided for these endpoints to work.
    
    ### Migrated endpoints:
    
    - [x] Prebuilt Rules
    - [x] Rule Management
    - [x] Rule Monitoring
    - [x] Health
    
    For further reference, here's the [complete list of Security Solution
    APIs](https://docs.google.com/spreadsheets/d/1VCoJ74EkyGuj59VwWj_3v2ecB84pNCpzGqkYnS0SUKw/edit?pli=1#gid=0).
    xcrzx authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0759c86 View commit details
    Browse the repository at this point in the history
  32. [Security Solution] expandable flyout - hide visualize tab in left se…

    …ction and open session view and analyzer in timeline (#164111)
    PhilippeOberti authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    acedd23 View commit details
    Browse the repository at this point in the history
  33. Initialize session index even if the legacy template API is not avail…

    …able. (#164714)
    
    ## Summary
    
    Elasticsearch [legacy template
    API](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-templates-v1.html)
    isn't available in the Serverless offering (returns 410), but it
    shouldn't prevent session index initialization.
    
    ## How to test
    1. Run ES Serverless with `./gradlew :run`
    2. Run Kibana with `yarn start --serverless
    --elasticsearch.serviceAccountToken=AAEAAWVsYXN0aWMva2liYW5hL2tpYmFuYS1kZXY6VVVVVVVVTEstKiBaNA
    --no-dev-credentials`
    azasypkin authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e83cfab View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    ec1b885 View commit details
    Browse the repository at this point in the history
  35. [Cloud Security] updates to move from doc_root.vulnerability.package …

    …-> doc_root.package (ECS) (#164651)
    
    ## Summary
    
    Issue: #157674
    
    This updates all instances of vulnerability.package to the ECS standard
    package fieldset.
    
    The new field has been populated by cloudbeat since 8.8
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    mitodrummer and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    fda98b0 View commit details
    Browse the repository at this point in the history
  36. [Fleet] Increase number of attempts on flaky unenroll test (#164734)

    ## Summary
    
    Closes #157205 
    
    Add an extra attempt to this flky test.
    
    bonus: we were rejecting with strings which was giving us this funny
    error:
    
    ```
    [Error: the string "action timed out" was thrown, throw an Error :)]
    ```
    hop-dev authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f2c6998 View commit details
    Browse the repository at this point in the history
  37. chore(NA): upgrade typescript into v4.7.4 (#162738)

    This PR bumps the Typescript version used on Kibana into v4.7.4.
    
    During the upgrade I got the impression the majority of the failures
    were too specific to the codebase so instead of making assumptions I
    choose to marked a lot of them with `@ts-expect-error` and let each team
    decide how to handle it.
    
    Next you can find a list of files with those comments and the teams to
    who they belong to. I would appreciate the collaboration from each team
    on fixing those. I'm not opposed on fixing those in subsequent PRs after
    this one have been merged, just wanted to elaborate that list for a good
    follow up:
    
    @elastic/kibana-core 
    - [x]
    [packages/core/http/core-http-router-server-internal/src/request.ts](https://github.com/elastic/kibana/pull/162738/files#diff-c1f4a8c013c6ff9c5170803322414cb002f70331b23e45c55f075258c678410a)
    
    @elastic/kibana-data-discovery  
    - [x]
    [src/plugins/discover/public/components/doc_table/components/table_row.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-9106b254a57e73fc6f0b2e01f9aff1abbd26f1a0999e6fa998f1b45d3013038f)
    
    @elastic/kibana-visualizations   
    - [x]
    [src/plugins/expressions/common/execution/execution.ts](https://github.com/elastic/kibana/pull/162738/files#diff-47bf3af7472c08ede90f86575ee7db4b8a2c949b1fb61400410ed16a8d819667)
    - [x]
    [src/plugins/expressions/common/expression_functions/expression_function_parameter.ts](https://github.com/elastic/kibana/pull/162738/files#diff-3bcaa3c50f2297ff990c7ac83a1c2d36a79e6706a09082c3c48a911713afe950)
    - [x]
    [src/plugins/vis_types/heatmap/public/editor/components/labels_panel.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-345db24d53f4158414480b890fa43d1f8a454b67313de79602fda081279cbc4f)
    - [x]
    [src/plugins/vis_types/xy/public/editor/components/options/metrics_axes/label_options.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-1c346b41cf025ff4f4e07b6d6dcdd1451cbaa758f9a9e8c72a9801d3fbbdfda2)
    
    @elastic/kibana-presentation 
    - [x]
    [x-pack/plugins/canvas/public/components/workpad_page/workpad_interactive_page/event_handlers.ts](https://github.com/elastic/kibana/pull/162738/files#diff-56858ed9be77830ab218eab1960337240926609c5a1593b3960b35660ef81359)
    
    @elastic/response-ops  
    - [x]
    [x-pack/plugins/cases/public/components/create/form.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-c5c415f1f56ca986f4bb59e65490b5e0fc77a86092240c0c1a26c141dba07818)
    - [x]
    [x-pack/plugins/cases/public/components/markdown_editor/editable_markdown_renderer.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-ab038916f6fed59e18b0a72ce8e823e88d115afdb2704010d0fa8656b66702df)
    - [x]
    [x-pack/plugins/rule_registry/server/alert_data_client/browser_fields/index.ts](https://github.com/elastic/kibana/pull/162738/files#diff-3f91aa93f7e6514c0479a37a76d6e9a53646d4eaf5dcd0db64437eadf1eee6b6)
    - [x]
    [x-pack/plugins/triggers_actions_ui/.storybook/decorator.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-fbf1d6d0104c11c3f3690d29edf06000b5a63a858bb22b7d04d1f96a45133b07)
    - [x]
    [x-pack/plugins/triggers_actions_ui/common/experimental_features.ts](https://github.com/elastic/kibana/pull/162738/files#diff-8e2ca70700895b17125532779945a1d0ab9076b4d4db304c065b47f82b6628a5)
    - [x]
    [x-pack/plugins/triggers_actions_ui/public/common/get_experimental_features.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-8e2ca70700895b17125532779945a1d0ab9076b4d4db304c065b47f82b6628a5)
    
    @elastic/fleet 
    - [x]
    [x-pack/plugins/fleet/common/experimental_features.ts](https://github.com/elastic/kibana/pull/162738/files#diff-a852b157b5ff1d6dbf321ea8a25f0020d8f88cd458378cc9de8ef25ce28c9414)
    - [x]
    [x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/index.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-9eea0be0f9341dd6369720ce7b11bff69dda51230337ebbae921f6abde187bd2)
    - [x]
    [x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-844d5f9707b739d25f2b73bd34c45c21e2e5d573b3238c13130a0d1c1db092dc)
    - [x]
    [x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-f88d92abbc549ddc95d693bf3a3bc9752613cf74f1e859a01ca61d572e031b11)
    - [x]
    [x-pack/plugins/fleet/server/mocks/index.ts](https://github.com/elastic/kibana/pull/162738/files#diff-d3f3e436b158ac2d877b7be9d57642855f89b0149cc28735811443da45bb079f)
    
    @elastic/security-detection-engine
    - [x]
    [x-pack/plugins/lists/server/services/extension_points/extension_point_storage_client.ts](https://github.com/elastic/kibana/pull/162738/files#diff-dbbf5a8541e06fd977c66e44d9ef59f738d953bdfda679ac838e098742c92f50)
    - [x]
    [x-pack/plugins/lists/server/services/extension_points/types.ts](https://github.com/elastic/kibana/pull/162738/files#diff-31186826bea8fdb286a25878fa06eeacad8f7a6c384d617fed905d4625821eef)
    
    @elastic/security-defend-workflows @gergoabraham 
    - [x]
    [x-pack/plugins/security_solution/public/detection_engine/rule_response_actions/osquery/osquery_response_action.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-049eeedef2a403ade7c636418e17fc9a3ffc7030eec2f3e013f459721c076470)
    
    @elastic/infra-monitoring-ui 
    - [x]
    [x-pack/plugins/monitoring/public/application/pages/apm/overview.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-4ab4fa150247d8f522741ae5ea1ea71c102c72f5439410ea869ec1c9dc9878ad)
    - [x]
    [x-pack/plugins/monitoring/public/application/pages/enterprise_search/overview.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-285a67d9ec93651206608d308e5d1d20ccc98ccccb9bcbf3ee31fe35c1844b42)
    
    @elastic/kibana-security 
    - [x]
    [x-pack/plugins/security/server/authentication/authenticator.ts](https://github.com/elastic/kibana/pull/162738/files#diff-bd369002fdfd0986f1ce3bf16263fb8b765e01a86832ccf5b4e521811d502038)
    - [x]
    [x-pack/plugins/security/server/session_management/session_index.ts](https://github.com/elastic/kibana/pull/162738/files#diff-10b76eb52a0e17564ad864def8270bb84a4eb87eb35851309bc36601086cbcd7)
    
    @elastic/security-threat-hunting-explore @gergoabraham 
    - [x]
    [x-pack/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-7f130bdc9a954330d188aa25324910cf2f72baf76d1329bd36584f5bb153856b)
    
    @elastic/security-solution @gergoabraham 
    - [x]
    [x-pack/plugins/security_solution/public/management/components/page_overlay/page_overlay.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-e68a2799df17238257a86ce965369c525be901f6f882e518bde9e8c9bd7cd2c8)
    - [x]
    [x-pack/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/components/event_collection_card.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-edc756f655792f7dcaca0c707f35c6c022981be1873712f460ccb1d611e42568)
    - [x]
    [x-pack/plugins/security_solution/tsconfig.json](https://github.com/elastic/kibana/pull/162738/files#diff-844dde79a96b9e6c2bfdf21f8c80feb8b687577e21326da6bd15c6b95d8ec918)
    
    @elastic/uptime 
    - [x]
    [x-pack/plugins/uptime/server/legacy_uptime/lib/alerts/duration_anomaly.test.ts](https://github.com/elastic/kibana/pull/162738/files#diff-6c7b63ce65aa17a2fe3219e1747ae051be88fb02edbe2f198ad6fd418a2bcc57)
    
    @elastic/security-detections-response-alerts @gergoabraham 
    - [x]
    [x-pack/test/detection_engine_api_integration/security_and_spaces/group8/exception_operators_data_types/keyword_array.ts](https://github.com/elastic/kibana/pull/162738/files#diff-472ba2c7fe43448c8a4d04406703f755f71f6e60146bb2f090b4ca0f19ad0a0f)
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    Co-authored-by: Michael Dokolin <[email protected]>
    Co-authored-by: Stratoula Kalafateli <[email protected]>
    Co-authored-by: Rudolf Meijering <[email protected]>
    Co-authored-by: Devon Thomson <[email protected]>
    6 people authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2d652e1 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    30872c4 View commit details
    Browse the repository at this point in the history
  39. [Fleet] Make failing secrets test more robust (#164740)

    ## Summary
    
    Closes #163901
    
    Instead of one sleep lets try 3 times.
    hop-dev authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    67958a1 View commit details
    Browse the repository at this point in the history
  40. [ML] Fixing memory usage serverless check (#164732)

    The check which decides what is shown on the memory usage page for
    serverless or stack versions of kibana is the wrong way round.
    The node list should be shown in non-serverless environments.
    jgowdyelastic authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b33effa View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    13701d3 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    b3f036b View commit details
    Browse the repository at this point in the history
  43. [Cloud Security][CIS GCP] Add Agent flyout updates for CIS GCP (#163910)

    ## Summary
    This PR is for changing how Cloud Shell flyout looks when adding agent.
    Previously it shows tabs for other installation method, now it no longer
    shows that (similar to what we have we Cloud Formation)
    We also updated the steps and command to copy.
    <img width="836" alt="Screenshot 2023-08-22 at 10 28 05 AM"
    src="https://github.com/elastic/kibana/assets/8703149/f312431a-e0fa-470e-896b-04324a160fdb">
    <img width="857" alt="Screenshot 2023-08-22 at 10 29 12 AM"
    src="https://github.com/elastic/kibana/assets/8703149/51b33fcd-11b9-4691-946c-83cab6fd4f5a">
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    animehart and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c66f58a View commit details
    Browse the repository at this point in the history
  44. Fixing duration field formatter showing 0 seconds instead of "few sec…

    …onds" (#164659)
    
    This PR solves the issue when a user is formatting fields that are "0"
    to be Human Friendly, then it shows "a few seconds" instead of "0.00
    seconds"
    
    This PR changes it to say: "0.00 seconds". 
    
    I have also updated the test-case for it. 
    
    Video of the issue - tested on 8.11 snapshot: 
    
    
    https://github.com/elastic/kibana/assets/108192783/082329bf-6c62-4eb5-b28e-212a848f6f65
    
    Screenshot of the fix: 
    
    <img width="1361" alt="Skærmbillede 2023-08-24 kl 10 36 15"
    src="https://github.com/elastic/kibana/assets/108192783/cc9a4490-e8b3-48a6-952e-61e9cd0aff81">
    
    
    Fixes  #101000
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    Co-authored-by: Matthias Wilhelm <[email protected]>
    Co-authored-by: Davis McPhee <[email protected]>
    4 people authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2d9b46d View commit details
    Browse the repository at this point in the history
  45. [ML] Data Frame Analytics trained models: adds functional tests for '…

    …Deploy Model' action (#163886)
    
    ## Summary
    
    Adds functional tests for deploy model action for DFA trained models
    with default config and with custom config.
    
    Part of #160712
    
    Flaky test run:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2961
    (updated)
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Kibana Machine <[email protected]>
    alvarezmelissa87 and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b2308a9 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    9e89a96 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    8e66122 View commit details
    Browse the repository at this point in the history
  48. [RAM] Fix Failing test: X-Pack Alerting API Integration Tests - Alert…

    …ing - group1.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/get_alert_summary·ts (#164759)
    
    ## Summary
    
    Fix: #156792
    
    
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2987
    XavierM authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6c2cd60 View commit details
    Browse the repository at this point in the history
  49. [Entity Analytics][Risk Engine] Risk Scoring Task (#163216)

    ## What this PR does
    * Adds a new Task Manager task, `risk_engine:risk_scoring`, responsible
    for invoking the `calculateAndPersistRiskScores` API defined in the risk
    scoring service.
    * Unlike an alerting task, we do not encrypt/persist an API key for the
    user. Instead, we use the internal kibana user to query all alerts in
    the current space.
    * The task configuration is stored as part of the existing
    `risk-engine-configuration` Saved Object
    * Extends the `risk-engine-configuration` SO to include more
    configuration fields
    * Management of this configuration is not currently exposed to the user.
    They can only enable/disable the entire "Risk Engine" on the `Settings
    -> Entity Risk Score` page
    * The settings currently serve mainly as the "default" values for task
    execution, but also as a way for a customer/SA to modify task execution
    if necessary.
    * We expect to be modifying these default values before release, as part
    of our planned "tuning" stage.
    
    ### How to Review
    * Setup:
    * The risk engine acts on Detection engine alerts, and so you will need
    to create:
          1. some "source" data (logs, filebeat, auditbeat, etc)
    2. Rules looking for the above "source" data, and generating alerts
    * The risk engine requires two feature flags, currently:
    `riskScoringPersistence` and `riskScoringRoutesEnabled`
      * You will also need a Platinum or greater license.
    1. Test that the task executes correctly
    1. With the above data set up, navigate to `Settings -> Entity Risk
    Score` page, and enable the task by toggling `Entity risk scoring` to
    `On`
    1. Within a few minutes, risk scores should be written to the risk score
    datastream:
            * `GET risk-score.risk-score-default/_search`
    * Replace `default` with the name of your current space, as necessary.
    1. Disabling/re-enabling the risk engine should trigger another
    execution of the task (similar to disabling/enabling a DE rule)
    1. Enable the risk engine in another space
        * The engine (and task) can be enabled/executed in any kibana space.
    * Because the engine only acts upon alerts in the current space, you
    will need to first ensure alerts exist in that space.
    1. Validate the data/mappings of persisted risk scores
    * Scores are based on the Stage 1 [ECS
    RFC](elastic/ecs#2236)
    * There is no UI reading from these scores, currently (but that is
    introduced in #163237)
      
      
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    rylnd and kibanamachine authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    43b0fab View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. [EventLog] don't use legacy template APIs during initialization (#164747

    )
    
    resolves #164731
    
    ## Summary
    
    This removes the check for a legacy index template for the event log for
    the current version it wants to create. This was presumably done this
    way, to allow for the switch from legacy to component templates.
    
    But it's not really needed, since each stack version creates new index
    templates. So, removing the check should be fine.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    Co-authored-by: Tiago Costa <[email protected]>
    Co-authored-by: Kibana Machine <[email protected]>
    3 people authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bcb9982 View commit details
    Browse the repository at this point in the history