[pull] main from elastic:main #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
## Summary This PR: - Enables Inference Management in ES3 - Fixes small issues to make sure it works in ES3. - Added FTR tests. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
…accessible via keyboard (#201193) Closes: #199760 Popovers, dialogs which are accessible with mouse, should also be accessible with keyboard. Otherwise users using only keyboard will miss the information present in popover, dialog. Closes: #199749 User reaches the same button two times when navigating using only keyboard and it can get confusing. Better for element to get focus only one time when navigating in sequence from one element to another and for the user only to hear one announcement of the element. ## What was changed: 1. `CreateSearchApplicationButton` component: - `EuiPopover` was replaced to more a11y-friendly `EuiToolTip` - extra `div` element with `tabindex` was removed. ## Screen https://github.com/user-attachments/assets/fbb62841-6f2f-45d0-bee3-39a11a4fc777
Simple updates mocha in buildkite dependencies.
This PR simply bumps and updates the mentioned dependencies.
) ## Summary Closes [#200162](#200162) Long data view names weren't truncated on mobile view. Also noticed the "X" icon to go on the second row - fixed it within the same PR. Before:  After: <img width="471" alt="Screenshot 2024-11-22 at 11 55 47" src="https://github.com/user-attachments/assets/c047c8f6-cace-4b99-814f-038bbc595572"> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [x] No risks identified
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@testing-library/jest-dom](https://togithub.com/testing-library/jest-dom) | devDependencies | minor | [`^6.5.0` -> `^6.6.3`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/6.5.0/6.6.3) | --- ### Release Notes <details> <summary>testing-library/jest-dom (@​testing-library/jest-dom)</summary> ### [`v6.6.3`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.6.3) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.6.2...v6.6.3) ##### Bug Fixes - add vitest import when extending vitest matchers ([#​646](https://togithub.com/testing-library/jest-dom/issues/646)) ([5ba0156](https://togithub.com/testing-library/jest-dom/commit/5ba015651c7b10c154e5a4ae54f85df6010c5295)) ### [`v6.6.2`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.6.2) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.6.1...v6.6.2) ##### Bug Fixes - remove recursive type reference in vitest types ([#​636](https://togithub.com/testing-library/jest-dom/issues/636)) ([4468378](https://togithub.com/testing-library/jest-dom/commit/4468378fb4986018e0bacdebd02244decb9f0718)) ### [`v6.6.1`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.6.1) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.6.0...v6.6.1) ##### Bug Fixes - fix lodash import in to-have-selection.js ([#​642](https://togithub.com/testing-library/jest-dom/issues/642)) ([ced792e](https://togithub.com/testing-library/jest-dom/commit/ced792e2f2773f16c249c6ce59fa8df968d28a20)) ### [`v6.6.0`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.6.0) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.5.0...v6.6.0) ##### Features - implement toHaveSelection ([#​637](https://togithub.com/testing-library/jest-dom/issues/637)) ([9b14804](https://togithub.com/testing-library/jest-dom/commit/9b148043d082a83f0ae5cdc03cdfc6a7c4573e6e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOk9wZXJhdGlvbnMiLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Brad White <[email protected]>
## Summary This PR is to remove unused KSPM option <img width="938" alt="Screenshot 2024-11-22 at 11 07 06 AM" src="https://github.com/user-attachments/assets/347be69b-5811-4e54-a15f-f7c90504dc68">
…keyword (#201473) ## Summary When formatting elasticsearch responses for the frontend, the timelines search strategies will treat unmapped fields as type: keyword. If the underlying field is actually an object, but is seen as a string in the code, this for (key in source) loop will fail, as it's trying to loop over a string. Fix below should have minimal effect as the data is accessible at the further nested keys. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )