Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] main from elastic:main #748

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[pull] main from elastic:main #748

merged 3 commits into from
Nov 27, 2024

Commits on Nov 27, 2024

  1. [ci] Disable step commit status (#199073) 

    The number of steps in pull request builds has been causing GitHub API
rate limit issues. In particular, scenarios that cause all steps to fail
have proven to quickly trigger the rate limit.

The disables step statuses on pull requests. We will still have our
required kibana-ci check for the overall build, and the pull request
comment can be used as the source of individual step failures.
    @jbudz
    jbudz authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2775089 View commit details
    Browse the repository at this point in the history

  2. Revert "[dashboard] fix Reset dashboard breaks panel state when ran a… 

    …fter editor edits (#201687)" (#201902)

This reverts commit 289bb16.
    @jbudz
    jbudz authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a0f88d9 View commit details
    Browse the repository at this point in the history

  3. Handle both JSON and XJSON in processor editor (#200692) 

    Closes [#175753](#175753)

## Summary
When a user creates a pipeline with a processor that has an JSON editor
field [Foreach, Grok, Inference, Redact and Script], our editor convert
the input to XJSON. This can be confused to the user, who see their
input modified without understanding the reason. For that, this PR
creates a new editor that handles both XJSON and JSON format and does
not changes the content that the user introduced while editing. Once the
pipeline is saved, it will always retrieve the parsed data.

I've created a whole new editor instead of modifying `XJsonEditor`
because the original one is still in use in the `Custom processor`. This
is because I've created [a
list](https://github.com/SoniaSanzV/kibana/blob/d7d5ecafa7dbae96fe52c2e37394520b6353bd92/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/utils.ts#L151-L157)
of the processor fields that needs to be serialized in
`convertProcessorInternalToProcessor`. Since we don't know the name of
the custom processor, we can't apply this workflow. I'm not super happy
with the idea of adding manually the names of the processors to a list.
I would like to have something more agnostic but I haven't come up with
a solution that allows me to do that without breaking other fields. So,
any suggestions are super welcome!

### How to test
Create one of the following processors: Foreach, Grok, Inference, Redact
or Script. In the JSON field, add a JSON with both with and without
escaped strings. While you are editing the processor before saving the
pipeline, you should see the processor as you typed it. In the `Show
Request` flyout, you should see the properly parsed JSON.

The pipeline should save with the correct parsed values and, once saved,
if you click update, you only will get parsed values.

### Demo


https://github.com/user-attachments/assets/1f9681df-2fb4-4ed5-ac30-03f2937abfe9
    @SoniaSanzV
    SoniaSanzV authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    8839894 View commit details
    Browse the repository at this point in the history