[pull] main from elastic:main #752
Merged
Commits on Nov 28, 2024
-
-
-
-
-
[Stack Monitoring] Do not add empty include array when retrieving log…
…stash pipelines (#202039) ## Summary This PR fixes the query that retrieves Logstash pipeline stats and metrics to be displayed in Stack Monitoring. The problem with the existing query is that a `terms` aggregation contains an empty `"include": []` filtering array, but that has the nasty effect of excluding everything and not returning anything, hence the screen is empty. The fix is to only add the `include` array if it's not empty. The PR also fixes a wrong field name used in a cardinality aggregation: `logstash.node.stats.logstash.uuid` instead of `logstash_stats.logstash.uuid` Closes #202020 ### Checklist - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: Chris Earle <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.