Test for adding commits with the same hash as gced one #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icristescu
changed the title
Ngoguey42
reviewed
Sep 6, 2022
test/irmin-pack/test_gc.ml
Outdated
| let* t, c2_again = commit_2 t in | ||
| Alcotest.check_repr S.Hash.t "added commit has the same hash as gced one" | ||
| (S.Commit.hash c2_again) (S.Commit.hash c2); | ||
| let* () = check_2 t c2 in |
There was a problem hiding this comment.
Suggested change
| let* () = check_2 t c2 in | |
| let* () = check_2 t c2_again in |
@icristescu do you validate this?
Closed
icristescu
force-pushed
the
test_index
branch
from
3b4f4cc to
4b8e02b
Compare
|
Merge just after #2070 . No need to rebase, no need for green CI |
icristescu
force-pushed
the
test_index
branch
from
4b8e02b to
2ba59a0
Compare
irmaTS
added
tezos-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test for #2067. The test fails at line 514 - the key for
c1_againreturned by the index is the one ofc1, which is not longer in the pack file.