Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: Split gc file #2109

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

Ngoguey42
Copy link
Contributor

On top of #2105

  • Gc.Worker.Make to Gc_worker.Make
  • Gc.Main_stats.Make to Gc_stats.Main.Make
  • Gc.Worker_stats to Gc_stats.Worker
  • Gc_intf.Args to Gc_args.S
  • Gc_ints.S to gc.mli
  • Gc.Make stays there

@Ngoguey42 Ngoguey42 added the no-changelog-needed No changelog is needed here label Oct 6, 2022
@samoht
Copy link
Member

samoht commented Oct 6, 2022

Would be nice to also add the corresponding mli files.

@codecov-commenter
Copy link

Codecov Report

Merging #2109 (3b9e698) into main (396e01c) will increase coverage by 0.05%.
The diff coverage is 20.45%.

@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
+ Coverage   64.78%   64.84%   +0.05%     
==========================================
  Files         131      133       +2     
  Lines       15855    15850       -5     
==========================================
+ Hits        10272    10278       +6     
+ Misses       5583     5572      -11     
Impacted Files Coverage Δ
src/irmin-pack/unix/gc_worker.ml 4.00% <4.00%> (ø)
src/irmin-pack/unix/gc_stats.ml 30.64% <30.64%> (ø)
src/irmin-pack/unix/dispatcher.ml 80.00% <60.00%> (+0.79%) ⬆️
src/irmin-pack/unix/gc.ml 81.65% <100.00%> (+42.42%) ⬆️
src/irmin-test/store.ml 94.95% <0.00%> (+0.05%) ⬆️
src/irmin-fs/unix/irmin_fs_unix.ml 67.74% <0.00%> (+3.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@icristescu icristescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- `Gc.Worker.Make` to `Gc_worker.Make`
- `Gc.Main_stats.Make` to `Gc_stats.Main.Make`
- `Gc.Worker_stats` to `Gc_stats.Worker`
- `Gc_intf.Args` to `Gc_args.S`
- `Gc_ints.S` to `gc.mli`
- `Gc.Make` stays there
@Ngoguey42
Copy link
Contributor Author

Merge when green

@Ngoguey42
Copy link
Contributor Author

Ngoguey42 commented Oct 7, 2022

Don't merge -_-' False alarm, can be merged

@Ngoguey42 Ngoguey42 merged commit 0c30d38 into mirage:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants