irmin-pack: add chunked suffix fields to control file #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icristescu
reviewed
Oct 14, 2022
icristescu
reviewed
Oct 17, 2022
icristescu
reviewed
Oct 17, 2022
metanivek
force-pushed
the
chunked_suffix_cf
branch
from
4e892f1 to
6abfcde
Compare
Codecov Report
@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
+ Coverage 64.79% 64.89% +0.09%
==========================================
Files 133 134 +1
Lines 15890 15952 +62
==========================================
+ Hits 10296 10352 +56
- Misses 5594 5600 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
metanivek
force-pushed
the
chunked_suffix_cf
branch
6 times, most recently
from
7cb94d2 to
c7f88e7
Compare
Ngoguey42
reviewed
Oct 20, 2022
metanivek
force-pushed
the
chunked_suffix_cf
branch
from
c7f88e7 to
c7c9b6d
Compare
Ngoguey42
approved these changes
Oct 21, 2022
metanivek
force-pushed
the
chunked_suffix_cf
branch
from
c7c9b6d to
3956110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #2115 by adding fields to
V4of the control file needed for a chunked suffix. This is a part of #2096.The following fields are added:
chunk_start_idxto indicate the starting index for the chunkschunk_numto indicate the number of chunksThe following field is added to the
Gcedstatus:suffix_dead_bytesto indicate bytes that could not be reclaimed during a GC (because of a suboptimal commit placement or during the time before an existing store has migrated to an optimally chunked suffix) but should be considered dead/unreachable in the suffix. In a future PR, the dispatcher will use this when constructing accessors. It is worth noting that the chunked suffix abstraction can read these bytes still but we would like to enforce reading these bytes from the prefix instead.