irmin-pack: use supplied ppf for integrity check #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix integrity check command to use supplied ppf when printing successful results. Errors are still printed to stderr.
art-w
reviewed
Mar 29, 2023
| match Sys.os_type with | ||
| | "Unix" | "Cygwin" -> "/dev/null" | ||
| | "Win32" -> "NUL" | ||
| | _ -> invalid_arg "invalid os type" |
There was a problem hiding this comment.
Perhaps we can use https://ocaml.org/p/ocaml-variants/4.12.0%2Bdomains/doc/Stdlib/Format/index.html#val-make_formatter to define a generic "null" formatter that doesn't depend on the OS?
There was a problem hiding this comment.
Hmm, yeah I can look into it. This code is just copy-pasta of what already existed. 😅
There was a problem hiding this comment.
haha yeah I saw that but it still looks icky :P
There was a problem hiding this comment.
Maybe using Logs directly could be what you want ? (and use the associated cli to determine where to print)
There was a problem hiding this comment.
Since this isn't the goal of this current PR, I opened an issue for future enhancement. #2231
art-w
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix integrity check command to use supplied ppf when printing successful results. Errors are still printed to stderr.
Closes #2211