Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stream Proofs #2275

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Remove Stream Proofs #2275

merged 2 commits into from
Oct 2, 2023

Conversation

samoht
Copy link
Member

@samoht samoht commented Sep 27, 2023

They are hard to maintain and nobdy use those anymore.

Note: probably more code could be simplified, I've done the "easy" bits first.

They are hard to maintain and nobdy use those anymore.
@codecov-commenter
Copy link

Codecov Report

Merging #2275 (2c6a9ef) into main (3f88570) will decrease coverage by 0.71%.
The diff coverage is 93.33%.

❗ Current head 2c6a9ef differs from pull request most recent head 4a191e7. Consider uploading reports for the commit 4a191e7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   68.83%   68.13%   -0.71%     
==========================================
  Files         133      133              
  Lines       16211    15982     -229     
==========================================
- Hits        11159    10889     -270     
- Misses       5052     5093      +41     
Files Coverage Δ
src/irmin-test/store.ml 95.15% <100.00%> (+0.02%) ⬆️
src/irmin/proof.ml 86.58% <100.00%> (-2.31%) ⬇️
src/irmin/tree.ml 81.39% <80.00%> (-0.10%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@metanivek metanivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's always nice to get rid of unused code, especially if it is complicated to maintain.

If CI is happy, I'm happy. Thanks! 🎉

@samoht samoht merged commit 2e7a6a2 into mirage:main Oct 2, 2023
4 checks passed
art-w added a commit to art-w/opam-repository that referenced this pull request Oct 9, 2023
CHANGES:

### Added

- **irmin-server**
  - Added `irmin-server` package (mirage/irmin#2031, @zshipko)
- **irmin-client**
  - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031,
    @zshipko)
- **irmin**
  - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when
    using `utop` (@metanivek, mirage/irmin#1839)

### Fixed

- **irmin-pack**
  - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek)

### Removed

- **irmin-http**
  - Removed `irmin-http` since it is not compatible with generic keys.
    `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko)
- **irmin**
  - Removed stream proofs. We now only have Merkle tree proofs. This simplifies
    the maintenance of that part of the code, as ensuring the correct order of
    cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht)

### Changed

- **irmin-git**
  - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

### Added

- **irmin-server**
  - Added `irmin-server` package (mirage/irmin#2031, @zshipko)
- **irmin-client**
  - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031,
    @zshipko)
- **irmin**
  - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when
    using `utop` (@metanivek, mirage/irmin#1839)

### Fixed

- **irmin-pack**
  - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek)

### Removed

- **irmin-http**
  - Removed `irmin-http` since it is not compatible with generic keys.
    `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko)
- **irmin**
  - Removed stream proofs. We now only have Merkle tree proofs. This simplifies
    the maintenance of that part of the code, as ensuring the correct order of
    cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht)

### Changed

- **irmin-git**
  - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants