irmin-client: do not duplicate connections on clone #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is (1) not needed to work properly as clone doesn't need to hold any special state in the connection; and (2) this is opening another file descriptor that is usually never closed.
art-w
approved these changes
Aug 30, 2024
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Dec 11, 2024
CHANGES: ### Added - **irmin-git** - Expose `Content_addressable` type (mirage/irmin#2329, @art-w) ### Changed - **irmin** - Rename `Node.S.effect` to `read_effect` for OCaml 5.3 compatibility (mirage/irmin#2347, @art-w) ### Fixed - **irmin-client** - Fix a fd leak when using `clone` (mirage/irmin#2322, @samoht) - **irmin-git** - Fix git sync example (mirage/irmin#2327, @art-w) - Fixed issue with two subsequent `Irmin-git` repos, where one repo would lose the ability to find its root path (mirage/irmin#2326, @zazedd) - **irmin** - Fix CI, update dependencies (mirage/irmin#2321, @smorimoto) - Update documentation (mirage/irmin#2323, mirage/irmin#2324, mirage/irmin#2325, @christinerose) - **irmin-cli** - Fix uncaught exception (mirage/irmin#2326, @art-w) ### Removed - **irmin** - Removed `?allow_duplicate` parameter from the `Conf.key` function (mirage/irmin#2326, @zazedd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (1) not needed to work properly as clone doesn't need to hold any special state in the connection; and (2) this is opening another file descriptor that is usually never closed.