Fix root path issue with Irmin-git
, and remove allow_duplicate
for root spec key
#2326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the repository root path in an
Irmin-git
repo that follows a precedingIrmin-git
repo. Additionally, it eliminates the potential for duplicate root entries in an Irmin config.Irmin-git
issueThe issue arose when trying to create two
Irmin-git
repos one after the other:After creating
pipeline_cfg
, theusers
repository is unable to find its root, as whenIrmin-git
creates a "fresh root key", it overrides theUniv
function that was able to decode the root directory string forusers
from the config'sUniv
map.This results in a new git repo being created in the project's current working directory, which isn't the expected behavior and can even break an existing git repository.
Duplicate
root
entryAfter fixing the issue with
Irmin-git
, I noticed it was only possible because of theallow_duplicates
flag.I believe that it allows for a dangerous operation that should not be performed.