Speed up Store.last-modified
by comparing hashes instead of file contents
#2335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
Store.last_modified
function to compare the precomputed file hashes instead of their contents, as the latter is significantly (~10 to 20x) slower. :)(More specifically,
Tree.find
is way slower thanTree.find_tree
)It also changes the documentation of the function where variable
n
is wrongly referred to asnumber
.