Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to lower_layer.md #2343

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Edits to lower_layer.md #2343

merged 6 commits into from
Sep 30, 2024

Conversation

christinerose
Copy link
Contributor

@christinerose christinerose commented Sep 19, 2024

A lot of tightening syntax (removing unnecessary prepositional phrases, etc.) for clarity and flow. Please check for accuracy. Also grammar and formatting fixes.

Some questions are below as well.

Copy link
Contributor

@clecat clecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks a lot

doc/irmin-pack/design/lower_layer.md Outdated Show resolved Hide resolved
doc/irmin-pack/design/lower_layer.md Show resolved Hide resolved
doc/irmin-pack/design/lower_layer.md Show resolved Hide resolved
doc/irmin-pack/design/lower_layer.md Outdated Show resolved Hide resolved
@christinerose
Copy link
Contributor Author

My pleasure! Always happy to help. 😊

Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just some minor suggestions :)

doc/irmin-pack/design/lower_layer.md Outdated Show resolved Hide resolved
doc/irmin-pack/design/lower_layer.md Outdated Show resolved Hide resolved
Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@art-w art-w merged commit 517f133 into mirage:main Sep 30, 2024
3 of 4 checks passed
art-w pushed a commit to art-w/irmin that referenced this pull request Oct 10, 2024
* Edits to lower_layer.md
* syntax for flow lower_layer.md
* typo
* Update lower_layer.md
* revert to accurate code term
* reverting to "its index of the commit hash"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants