Update to latest mirage

[samoht]

To be tested with mirage/mirage#1442

[hannesm]

that looks nice, but would you mind to separate the ocamlformat changes (whitespaces, new lines) from the actual changes?

[samoht]

Rebased on top of #365 - see 40231d0 for the related changes.

[samoht]

Rebased on top of master.

[hannesm]

Unfortunately this broke mirage-skeleton on main branch with the latest released mirage tool.

It seems like we're still lacking documentation thereof (and I've no clue how the CI system is configured / working), but I'd really like to have:

• main branch of mirage-skeleton works with latest opam-released mirage
• dev branch of mirage-skeleton works with main branch of mirage

this allows people passing by to just use mirage & mirage-skeleton as documented. It would be great to have mirage/mirage#1381 / #338 in place very soon to get nice error messages to the users instead of confusing them with errors such as:

(hello-key unikernel)
776.935s:# File "unikernel.ml", line 7, characters 2-20:
776.935s:# 7 |   Mirage_runtime.key key
776.935s:#       ^^^^^^^^^^^^^^^^^^
776.935s:# Error: Unbound value Mirage_runtime.key

(static-website-tls)
581.409s:+ mirage configure -t hvt --http 80 --https 443 '--allocation-policy=best-fit' --context ./mirage/context --no-extra-repo
582.639s:mirage: unknown option '--http', did you mean '--help'?
582.639s:        unknown option '--https'.
582.639s:Usage: mirage configure [OPTION]…
582.639s:Try 'mirage configure --help' or 'mirage --help' for more information.

what do you think?

[hannesm]

^^ @samoht. In a nice world, the mirage-CI would actually enforce this -- so testing pushes/PRs to the main branch with the released mirage, while testing pushes/PRs to the dev branch with mirage pinned to its main branch. and also, testing PRs to mirage with the dev branch of mirage-skeleton (+to test with PR comment thingy).

[samoht]

woops, I should have opened this PR against dev. Let me try to fix this...

And yes your scheme makes sense (and corresponds to my understanding of our current worfklows) but the current CI doesn't test this: https://github.com/ocurrent/mirage-ci/blob/main/src/pipelines/PR.ml#L585-L589. Let me try to fix this (bis).

[samoht]

I've reverted this PR: #375 and merged it to unbreak the compilation of mirage-skeleton main's branch with the latest released version of mirage.

[hannesm]

see ocurrent/mirage-ci#37 which may do the thing we're interested in!?