Fix python cmdline parser for variants #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
force-pushed
the
variant-cmdparse
branch
from
0e4b7c2 to
0327f71
Compare
|
Hmm the CI seems to be broken |
Given ``` type operation = Copy of string | Mirror of string ``` Represented as `["Copy", "arg"]` we need to parse that as JSON when given on the cmdline. Otherwise it'd do `operation[0]`, where `operation` is a string, which is not what we want. This doesn't affect usage from xapi-storage-script (which always calls it with --json), but it affects testing the python code by hand, because you can't supply the correct cmdline arguments (unless you construct an entire JSON by hand and pass it on stdin which is a bit tedious) Signed-off-by: Edwin Török <[email protected]>
Looks like it is running 4.08.1 on macos, is it supposed to do that? |
|
I think we should probably update setup-ocaml to the latest version ocaml-rpc/.github/workflows/test.yml Line 32 in bdd3ab5 |
|
The previous issue was due to pylint complaining about the possibly uninitialised variable |
|
We've migrated XAPI and everything to Python3 recently, so I'm fine with dropping python2 support. |
edwintorok
approved these changes
Sep 25, 2024
Since we are not testing it in the CI anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
Represented as
["Copy", "arg"]we need to parse that as JSON when given on the cmdline.Otherwise it'd do
operation[0], whereoperationis a string, which is not what we want.This doesn't affect usage from xapi-storage-script (which always calls it with --json),
but it affects testing the python code by hand, because you can't supply the correct cmdline arguments
(unless you construct an entire JSON by hand and pass it on stdin which is a bit tedious)