Mirego-base-setup 5 of X: Navigation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyling' into feature/mirego-base-setup-navigation
…tyling' into feature/mirego-base-setup-navigation
…tyling' into feature/mirego-base-setup-navigation
|
🦀 Requesting reviewers for this pull request:
🦀 Mentionning users for this pull request:
|
OlivierPineau
changed the base branch from
feature/mirego-base-setup-mvvm
to
feature/mirego-base-setup-view-styling
OlivierPineau
changed the title
|
Just realised that the lifecycle modifiers have not been implemented. So onAppear and onDisappear are not called |
* Analytics stuff * Analytics tracking * killswitch integration * pr comment * fixes * fix mock item in test * killswitch qa env * Revert qa killswitch url * add possibility to use maven local dependencies * Dummy firebase initialization * update killswitch version * Mirego-base-setup 8 of X: CI tasks + lint (#40) * fix * Test fix * Format * disable enum rule * fix permissions * add task to ci * Add checkCommon * android ktlint * oups * Mirego-base-setup 9 of X: App Center (#47) * setup appcenter * add init on Android * base setup for fastlane (#48) --------- Co-authored-by: Christophe Tremblay <[email protected]> --------- Co-authored-by: Olivier Pineau <[email protected]> Co-authored-by: Olivier Pineau <[email protected]>
* Analytics stuff * Analytics tracking * Dummy firebase initialization * fix * oups * remove comment --------- Co-authored-by: Steven de Tilly <[email protected]>
sdetilly
merged commit 78141b4
into
feature/mirego-base-setup-view-styling
1 check passed
sdetilly
added a commit
that referenced
this pull request
Nov 27, 2023
* Trikot + Kword + Koin/KSP * oups * common + iOS * Android wip * Android stuff + remove stuff * datasource + preview stuff * Fix loading state * Fix build * Gorgeous stuff * lint fix * viewmodel + usecase tests * Locale flow * Locale repository * Concrete flow for iOS * Android locale * Add Android UI * Update Android views * Create better placeholder and loading state on Android * Mirego-base-setup 5 of X: Navigation (#42) * Base nav * navigation viewmodels * open details * add close icon * iOS nav * For the font * override navigaiton type * fix stuff * Add navigation and UI on Android * Mirego-base-setup 7 of X: Killswitch (#39) * Analytics stuff * Analytics tracking * killswitch integration * pr comment * fixes * fix mock item in test * killswitch qa env * Revert qa killswitch url * add possibility to use maven local dependencies * Dummy firebase initialization * update killswitch version * Mirego-base-setup 8 of X: CI tasks + lint (#40) * fix * Test fix * Format * disable enum rule * fix permissions * add task to ci * Add checkCommon * android ktlint * oups * Mirego-base-setup 9 of X: App Center (#47) * setup appcenter * add init on Android * base setup for fastlane (#48) --------- Co-authored-by: Christophe Tremblay <[email protected]> --------- Co-authored-by: Olivier Pineau <[email protected]> Co-authored-by: Olivier Pineau <[email protected]> * Mirego-base-setup 6 of X: Analytics (#41) * Analytics stuff * Analytics tracking * Dummy firebase initialization * fix * oups * remove comment --------- Co-authored-by: Steven de Tilly <[email protected]> --------- Co-authored-by: Francis Pepin <[email protected]> Co-authored-by: Christophe Tremblay <[email protected]> Co-authored-by: Steven de Tilly <[email protected]> * Merge branch 'mirego' into feature/mirego-base-setup-view-styling # Conflicts: # androidApp/build.gradle.kts # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/AndroidApplication.kt # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/bootstrap/AndroidBootstrap.kt # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/bootstrap/AppInformationImpl.kt # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/resources/AndroidImageProvider.kt # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/ui/application/ApplicationView.kt # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/ui/preview/PreviewProvider.kt # androidApp/src/main/java/com/mirego/kmp/boilerplate/app/ui/root/RootView.kt # gradle/libs.versions.toml # ios/.swiftlint.yml # ios/Podfile # ios/Podfile.lock # ios/iosApp.xcodeproj/project.pbxproj # ios/iosApp/AppInitializer.swift # ios/iosApp/Domain/AppInformationImpl.swift # ios/iosApp/Domain/ImageProvider.swift # ios/iosApp/UI/Application/ApplicationView.swift # ios/iosApp/UI/Root/RootView.swift # shared/build.gradle.kts # shared/src/commonMain/generated/com/mirego/kmp/boilerplate/localization/KWordTranslation.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/StateDataExtensions.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/bootstrap/AppEnvironment.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/bootstrap/AppInformation.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/bootstrap/Module.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/datasource/DataSourceUtils.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/datasource/apollo/ApolloGraphQLDataSource.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/datasource/generic/GenericDataSource.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/extension/StateDataExtensions.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/graphql/query/ProjectsQuery.graphql # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/repository/projects/ProjectsRepositoryImpl.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/usecase/preview/ProjectsUseCasePreview.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/usecase/projects/ProjectsUseCase.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/usecase/projects/ProjectsUseCaseImpl.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/utils/StateData.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/viewmodel/common/ErrorViewModelImpl.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/viewmodel/factory/ViewModelFactoryPreview.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/viewmodel/projects/ProjectsViewModel.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/viewmodel/projects/ProjectsViewModelImpl.kt # shared/src/commonMain/kotlin/com/mirego/kmp/boilerplate/viewmodel/root/RootViewModelImpl.kt # shared/src/commonMain/resources/translations/translation.en.json # shared/src/commonMain/resources/translations/translation.fr.json --------- Co-authored-by: Francis Pepin <[email protected]> Co-authored-by: Christophe Tremblay <[email protected]> Co-authored-by: Steven de Tilly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Add navigation mecanism to the shared code
Implement new details view to demonstrate the navigation usage
🦀 Dispatch
#dispatch/kmp