Hporutiu readme updates to node.js stickies CSV app #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
horeaporutiu
commented
Sep 4, 2023
•
horeaporutiu
commented
- add demo video
- add sample CSV data
- update folder structure with csv data file
- use README template
- added section to CONTRIBUTING.md to ensure all new app-examples which are submitted have the required sections
add demo video, and update the folder structure with sample csv data
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mettin
approved these changes
Sep 4, 2023
|
also added a new section in the contributing guide @mettin could you please check that when you get a chance? |
mettin
reviewed
Sep 4, 2023
| 9. [Contributing section](https://github.com/miroapp/app-examples/tree/main/examples/drag-and-drop#-contributing-). Here you | ||
| can just link to [Miro's contributing guide](https://github.com/miroapp/app-examples/blob/main/CONTRIBUTING.md). | ||
| 10. [License section](https://github.com/miroapp/app-examples/tree/main/examples/drag-and-drop#-license-). This should | ||
| indicate what license you want to use. |
There was a problem hiding this comment.
Can we create a README.template.md too? 🔥
There was a problem hiding this comment.
Yes, let me do that now :)
There was a problem hiding this comment.
Ok it's added now @mettin! What do you think?
mettin
reviewed
Sep 4, 2023
README.template.md
Outdated
| ``` | ||
| . | ||
| ├── src | ||
| │ └── styles |
There was a problem hiding this comment.
You can delete these lines since its too specific
There was a problem hiding this comment.
Good idea, just removed. Thank you!
| http://localhost:3000 | ||
| ``` | ||
| 3. Open the [app manifest editor](https://developers.miro.com/docs/manually-create-an-app#step-2-configure-your-app-in-miro) by clicking **Edit in Manifest**. \ | ||
| In the app manifest editor, configure the app as follows: |
There was a problem hiding this comment.
can't we have a copy/paste example?
There was a problem hiding this comment.
I added one, lmk if it is what you were thinking? @mettin
kirillsud
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.