Fix total_pages method fail on active_record model after calling merge with unscoped limit #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that using active record
.merge
can result in having.limit_value
asnil
. This can cause.total_entries
and.total_pages
to fail with the errorcomparison of Integer with nil failed
on the following line:will_paginate/lib/will_paginate/active_record.rb
Line 70 in 573df2d
Here is an example that demonstrates how you can get a
nil
value in thelimit_value
field:There are two places that require updates:
total_entries
method inactive_record.rb
fails whenlimit_value
isnil
and compared to the size https://github.com/allomov/will_paginate/blob/53e08fe99b4bbfa67213ac28734871bacb59e343/lib/will_paginate/active_record.rb#L70per_page
method,limit_value
can cause issues while computing.total_pages
https://github.com/allomov/will_paginate/blob/53e08fe99b4bbfa67213ac28734871bacb59e343/lib/will_paginate/active_record.rb#L27