Apply suggestions from code review

Co-authored-by: taiy <[email protected]>
misskey-dev · Jul 11, 2024 · 69abbd6 · 69abbd6
1 parent 565bcb5
commit 69abbd6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/frontend/src/components/MkNoteDetailed.vue b/packages/frontend/src/components/MkNoteDetailed.vue
@@ -395,11 +395,11 @@ if (appearNote.value.reactionAcceptance === 'likeOnly') {
 	});
 }
 
-async function renote() {
+function renote() {
 	pleaseLogin();
 	showMovedDialog();
 
-	const { menu } = await getRenoteMenu({ note: note.value, renoteButton, canRenote: canRenote.value });
+	const { menu } = getRenoteMenu({ note: note.value, renoteButton });
 	os.popupMenu(menu, renoteButton.value);
 }
 

diff --git a/packages/frontend/src/components/MkPagePreview.vue b/packages/frontend/src/components/MkPagePreview.vue
@@ -61,7 +61,7 @@ const props = defineProps<{
 		outline: none;
 
 		&::after {
-			content: '';
+			content: "";
 			position: absolute;
 			top: 0;
 			left: 0;

diff --git a/packages/frontend/src/os.ts b/packages/frontend/src/os.ts
@@ -680,7 +680,7 @@ export function post(props: Record<string, any> = {}): Promise<void> {
 		const { dispose } = popup(MkPostFormDialog, props, {
 			closed: () => {
 				resolve();
-				dispose?.();
+				dispose();
 			},
 		});
 	});