Apply suggestions from code review

Co-authored-by: taichan <[email protected]>
misskey-dev · Jun 9, 2024 · faf916d · faf916d
1 parent 1fad9a8
commit faf916d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/frontend/src/components/MkNote.vue b/packages/frontend/src/components/MkNote.vue
@@ -231,7 +231,7 @@ if (collapsingNoteCondition === 'seeRenderedSize') {
 		const limit = collapseSize * parseFloat(getComputedStyle(collapsibleArea.value).fontSize);
 		isLong.value = current > limit;
 		collapsed.value &&= isLong.value;
-	})
+	});
 }
 
 // plugin

diff --git a/packages/frontend/src/components/MkSubNoteContent.vue b/packages/frontend/src/components/MkSubNoteContent.vue
@@ -32,7 +32,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 </template>
 
 <script lang="ts" setup>
-import { ref, computed } from 'vue';
+import { ref, computed, onMounted } from 'vue';
 import * as Misskey from 'misskey-js';
 import * as mfm from 'mfm-js';
 import MkMediaList from '@/components/MkMediaList.vue';
@@ -57,7 +57,7 @@ if (collapsingNoteCondition === 'seeRenderedSize') {
 		const limit = collapseSize * parseFloat(getComputedStyle(collapsibleArea.value).fontSize);
 		isLong.value = current > limit;
 		collapsed.value &&= isLong.value;
-	})
+	});
 }
 const isLong = ref(true);
 switch (collapsingNoteCondition) {

diff --git a/packages/frontend/src/pages/settings/general.vue b/packages/frontend/src/pages/settings/general.vue
@@ -98,7 +98,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 				<option value="legacyCalculation">{{ i18n.ts.legacyCalculation }}</option>
 				<option value="seeRenderedSize">{{ i18n.ts.seeRenderedSize }}</option>
 			</MkRadios>
-			<MkRadios v-model="collapsingNoteSize" v-if="collapsingNoteCondition !== 'legacyCalculation'">
+			<MkRadios v-if="collapsingNoteCondition !== 'legacyCalculation'" v-model="collapsingNoteSize">
 				<template #label>{{ i18n.ts.collapsingNoteSize }}</template>
 				<option :value="18">{{ i18n.ts.large }}</option>
 				<option :value="13.5">{{ i18n.ts.medium }}</option>