Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable featured performance settings #13874

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented May 24, 2024

What

Featuredのランキングへ適用する割合を手動で設定できるようにしました。

Fixes #12516

Why

三割という確率が中小規模サーバーにとって低いためfeaturedの精度がいちじるしくひくい。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 39.68254% with 38 lines in your changes missing coverage. Please review.

Project coverage is 41.91%. Comparing base (8b4933c) to head (ef5ef29).

Files Patch % Lines
packages/backend/src/core/FeaturedService.ts 50.00% 15 Missing ⚠️
packages/frontend/src/pages/admin/settings.vue 0.00% 15 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts 20.00% 4 Missing ⚠️
packages/backend/src/core/NoteCreateService.ts 0.00% 2 Missing ⚠️
packages/backend/src/core/ReactionService.ts 0.00% 1 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13874      +/-   ##
===========================================
+ Coverage    40.16%   41.91%   +1.74%     
===========================================
  Files         1521     1525       +4     
  Lines       188552   194648    +6096     
  Branches      3509     2691     -818     
===========================================
+ Hits         75735    81578    +5843     
- Misses      112246   112527     +281     
+ Partials       571      543      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 24, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -549,6 +549,9 @@
                         "string",
                         "null"
                       ]
+                    },
+                    "featuredUpdateRatio": {
+                      "type": "number"
                     }
                   },
                   "required": [
@@ -656,7 +659,8 @@
                     "urlPreviewMaximumContentLength",
                     "urlPreviewRequireContentLength",
                     "urlPreviewUserAgent",
-                    "urlPreviewSummaryProxyUrl"
+                    "urlPreviewSummaryProxyUrl",
+                    "featuredUpdateRatio"
                   ]
                 }
               }
@@ -13888,6 +13892,9 @@
                       "string",
                       "null"
                     ]
+                  },
+                  "featuredUpdateRatio": {
+                    "type": "number"
                   }
                 }
               }

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented May 24, 2024

featuredに値する投稿かどうか判定するにはある程度のサンプル数が要ると思うから、そもそも小規模サーバー向けの機能ではないというのはあるわね

@Sayamame-beans
Copy link
Member

featuredに値する投稿かどうか判定するにはある程度のサンプル数が要ると思うから、そもそも小規模サーバー向けの機能ではないというのはあるわね

Related:

@syuilo
Copy link
Member

syuilo commented May 24, 2024

まあ設定できるようにしといて損は無さそう

@anatawa12
Copy link
Member Author

まぁ小規模だとそうですが中規模でも3割は結構悪影響あったので投げました。

うちのにりらでは100%にすると改善してたので

CHANGELOG.md Outdated Show resolved Hide resolved
@tai-cha
Copy link
Contributor

tai-cha commented Jul 16, 2024

上げ

@Sayamame-beans
Copy link
Member

conflict解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
4 participants