-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable featured performance settings #13874
base: develop
Are you sure you want to change the base?
Configurable featured performance settings #13874
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13874 +/- ##
===========================================
+ Coverage 40.16% 41.91% +1.74%
===========================================
Files 1521 1525 +4
Lines 188552 194648 +6096
Branches 3509 2691 -818
===========================================
+ Hits 75735 81578 +5843
- Misses 112246 112527 +281
+ Partials 571 543 -28 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -549,6 +549,9 @@
"string",
"null"
]
+ },
+ "featuredUpdateRatio": {
+ "type": "number"
}
},
"required": [
@@ -656,7 +659,8 @@
"urlPreviewMaximumContentLength",
"urlPreviewRequireContentLength",
"urlPreviewUserAgent",
- "urlPreviewSummaryProxyUrl"
+ "urlPreviewSummaryProxyUrl",
+ "featuredUpdateRatio"
]
}
}
@@ -13888,6 +13892,9 @@
"string",
"null"
]
+ },
+ "featuredUpdateRatio": {
+ "type": "number"
}
}
} |
featuredに値する投稿かどうか判定するにはある程度のサンプル数が要ると思うから、そもそも小規模サーバー向けの機能ではないというのはあるわね |
Related: |
まあ設定できるようにしといて損は無さそう |
まぁ小規模だとそうですが中規模でも3割は結構悪影響あったので投げました。 うちのにりらでは100%にすると改善してたので |
Co-authored-by: Sayamame-beans <[email protected]>
上げ |
conflict解消 |
What
Featuredのランキングへ適用する割合を手動で設定できるようにしました。
Fixes #12516
Why
三割という確率が中小規模サーバーにとって低いためfeaturedの精度がいちじるしくひくい。
Additional info (optional)
Checklist