Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Report renote abuse #11466

Merged
merged 12 commits into from
Sep 5, 2023

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Aug 5, 2023

What

Fixes #11285

Why

Renote自体に対しては通報する術が無いのがHTLとGTL等でルールが違う際に問題になるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #11466 (ce75a32) into develop (e82c2e7) will increase coverage by 0.20%.
The diff coverage is 55.73%.

@@             Coverage Diff             @@
##           develop   #11466      +/-   ##
===========================================
+ Coverage    78.64%   78.85%   +0.20%     
===========================================
  Files          923      175     -748     
  Lines        97475    22878   -74597     
  Branches      7747      520    -7227     
===========================================
- Hits         76662    18040   -58622     
+ Misses       20813     4838   -15975     
Files Changed Coverage Δ
packages/frontend/src/scripts/get-note-menu.ts 5.90% <12.90%> (+0.79%) ⬆️
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)

... and 750 files with indirect coverage changes

@anatawa12 anatawa12 marked this pull request as ready for review August 5, 2023 11:53
@github-actions github-actions bot requested review from EbiseLutica and syuilo August 5, 2023 11:54
@anatawa12 anatawa12 changed the title Report renote abuse feat(frontend): Report renote abuse Aug 5, 2023
@anatawa12
Copy link
Member Author

Conflictを解消しましたが、これに依存する形で実装したいので #11268 も一緒に実装していいですか? 1 pullreq 1機能のほうが適切ではあると思うのですが...

@anatawa12
Copy link
Member Author

CIおちはdevelopのもののもようです

@syuilo
Copy link
Member

syuilo commented Aug 22, 2023

Renote対象のノートのメニューにRenoteのリンクをコピーする項目があるのは不自然に感じます
image

@anatawa12
Copy link
Member Author

便利かなと思い追加してましたが削除しました

@syuilo syuilo merged commit 46b0eb4 into misskey-dev:develop Sep 5, 2023
@syuilo
Copy link
Member

syuilo commented Sep 5, 2023

👍🏻👍🏻

@anatawa12 anatawa12 deleted the report-renote-abuse branch September 5, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renote対象ではなくRenote自体も通報可能にして欲しい
3 participants