Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Webhook設定でsecretを空に出来るように #11784

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

Sayamame-beans
Copy link
Member

What

Webhook設定のsecretを空文字列に出来るようにしました。
また、パラメーターとして必須でないように(デフォルトが空文字となるように)しました。

Why

Resolve #11774

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e7d30c8) 78.64% compared to head (a7afbd2) 78.64%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #11784   +/-   ##
========================================
  Coverage    78.64%   78.64%           
========================================
  Files          923      923           
  Lines        97509    97509           
  Branches      7739     7740    +1     
========================================
+ Hits         76682    76685    +3     
+ Misses       20827    20824    -3     
Files Changed Coverage Δ
...kend/src/server/api/endpoints/i/webhooks/create.ts 73.75% <100.00%> (ø)
...kend/src/server/api/endpoints/i/webhooks/update.ts 71.60% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit bf30323 into misskey-dev:develop Sep 6, 2023
7 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 6, 2023

🙏

@Sayamame-beans Sayamame-beans deleted the issue-11774 branch September 22, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook設定でsecretを空に出来るようにする
2 participants