Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: センシティブチャンネルはユーザーのノート一覧から除外 #11797

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

EbiseLutica
Copy link
Contributor

@EbiseLutica EbiseLutica commented Sep 7, 2023

What

センシティブチャンネル内の投稿を users/notes のレスポンスから除外しました。
resolve #11376

Why

元issueを参照

Additional info (optional)

現状ではオプショナブルではありませんが、センシティブな投稿であることを考えるとこのままで良いかなと思っています。
場合によっては isSensitive ではない別のフラグをチャンネルに設定できるようにするのもありかもですが、やるなら別のIssueで。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (90b058e) 78.70% compared to head (2d1e1d4) 78.67%.
Report is 6 commits behind head on develop.

❗ Current head 2d1e1d4 differs from pull request most recent head 3727045. Consider uploading reports for the commit 3727045 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11797      +/-   ##
===========================================
- Coverage    78.70%   78.67%   -0.04%     
===========================================
  Files          926      924       -2     
  Lines        97860    97694     -166     
  Branches      7752     7751       -1     
===========================================
- Hits         77025    76856     -169     
- Misses       20835    20838       +3     
Files Changed Coverage Δ
...es/backend/src/server/api/endpoints/users/notes.ts 86.66% <100.00%> (+0.30%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 8749716 into develop Sep 10, 2023
2 checks passed
@syuilo syuilo deleted the makeSensitiveChannelsInvisibleFromUserPage branch September 10, 2023 06:14
@syuilo
Copy link
Member

syuilo commented Sep 10, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ユーザ詳細ページから特定のチャンネル投稿を見えなくしたい
2 participants