Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): プラグインのソースコードを確認・コピーできるように #11873

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 22, 2023

What

  • ソースコードの確認をMisskey Web上でできるようにした
  • プラグインの権限表示が壊れていたので修正した

image

Why

Fix #11872

プラグインの中身を編集できるようにすることも考えましたが、セキュリティ面の問題や、各プラグインに個別のIDが払い出されることもあって、敢えて実装しませんでした

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (3085739) 78.89% compared to head (f1d4469) 78.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11873      +/-   ##
===========================================
- Coverage    78.89%   78.86%   -0.04%     
===========================================
  Files          930      928       -2     
  Lines        98344    98175     -169     
  Branches      7819     7819              
===========================================
- Hits         77591    77422     -169     
  Misses       20753    20753              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 1924bd2 into misskey-dev:develop Sep 23, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 23, 2023

👍

@kakkokari-gtyih kakkokari-gtyih deleted the plugin-show-source branch September 23, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

導入済みのプラグインのソースコードをエクスポート(表示)できるようにする
2 participants