Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: leverage join misskey multilingual behaviour #11908

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

tassoman
Copy link
Contributor

What

Editing link to Join Misskey Instances page

Why

fixes #11907

Additional info (optional)

Well, didn't tested yet, because it's a very small edit.

Checklist

  • [x ] Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (440f314) 78.78% compared to head (a1e9ea4) 78.80%.
Report is 1 commits behind head on develop.

❗ Current head a1e9ea4 differs from pull request most recent head 329fd38. Consider uploading reports for the commit 329fd38 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11908      +/-   ##
===========================================
+ Coverage    78.78%   78.80%   +0.02%     
===========================================
  Files          928      929       +1     
  Lines        98670    98771     +101     
  Branches      7847     7848       +1     
===========================================
+ Hits         77734    77839     +105     
+ Misses       20936    20932       -4     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih merged commit 9d0c077 into misskey-dev:develop Sep 27, 2023
9 checks passed
@kakkokari-gtyih
Copy link
Contributor

🙏🙏🙏🙏

Kesefon pushed a commit to Kesefon/misskey that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page Button "find other instances" brings only to japanese servers
2 participants