Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

広告に関する修正(配信中の絞り込み、Create時にMiAdを返すように) #11913

Merged
merged 8 commits into from
Sep 29, 2023

Conversation

nenohi
Copy link
Contributor

@nenohi nenohi commented Sep 28, 2023

What

API(admin/ad/create)の変更
・応答でIDを返すことで管理ツール等でアップデートに使用することができる為
API(admin/ad/list)の修正
・publishingのプロパティを追加し、現在配信中の広告のみの絞り込みを行った

Why

上記

Additional info (optional)

ローカルにてテスト済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2438c04) 78.76% compared to head (5a580cf) 78.72%.
Report is 3 commits behind head on develop.

❗ Current head 5a580cf differs from pull request most recent head 7c348a8. Consider uploading reports for the commit 7c348a8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11913      +/-   ##
===========================================
- Coverage    78.76%   78.72%   -0.04%     
===========================================
  Files          931      929       -2     
  Lines        99074    98910     -164     
  Branches      7862     7862              
===========================================
- Hits         78037    77869     -168     
- Misses       21037    21041       +4     
Files Coverage Δ
...ackend/src/server/api/endpoints/admin/ad/create.ts 75.00% <0.00%> (-1.28%) ⬇️
.../backend/src/server/api/endpoints/admin/ad/list.ts 83.33% <25.00%> (-5.31%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 9c44805 into misskey-dev:develop Sep 29, 2023
9 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 29, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants