Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プライバシーポリシー・運営者情報のリンクを追加 #11925

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • プライバシーポリシー・運営者情報(Impressum)のリンクを追加できるようにした
  • 利用規約・プライバシーポリシー・運営者情報のリンクをサーバー情報メニューから参照できるようにした
  • プライバシーポリシーは利用規約と同様にサーバーへの登録時に同意を取るようにした

image

image

image

Why

Fix #11845

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d6ef28d) 79.22% compared to head (906bd0f) 78.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11925      +/-   ##
===========================================
- Coverage    79.22%   78.71%   -0.51%     
===========================================
  Files          930      176     -754     
  Lines        99557    23118   -76439     
  Branches      8050      510    -7540     
===========================================
- Hits         78872    18198   -60674     
+ Misses       20685     4920   -15765     

see 754 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 30, 2023

プライバシーポリシーは利用規約と同様にサーバーへの登録時に同意を取るようにした

利用規約とプライバシーポリシーは同じセクションにまとめても良いかもしれないわね

@kakkokari-gtyih
Copy link
Contributor Author

image

@kakkokari-gtyih
Copy link
Contributor Author

@/ThesiiNCey さん(Issue元)にドイツでこの形式のリンク表示が合法かどうか確かめてからReadyにします

@syuilo
Copy link
Member

syuilo commented Oct 4, 2023

現状よりベターなことは確実だからとりあえずマージしたい

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 7, 2023 02:13
@kakkokari-gtyih
Copy link
Contributor Author

サーバー情報ページをちょっと修正

image

@kakkokari-gtyih kakkokari-gtyih requested a review from syuilo October 7, 2023 03:42
@kakkokari-gtyih
Copy link
Contributor Author

プライバシーポリシー・運営者情報もnodeinfoに追記したほうかいいかも

@kakkokari-gtyih
Copy link
Contributor Author

プライバシーポリシー・運営者情報もnodeinfoに追記したほうかいいかも

した

@syuilo syuilo merged commit 5e8c0de into misskey-dev:develop Oct 7, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 7, 2023

👍👍👍

@kakkokari-gtyih kakkokari-gtyih deleted the add-impressum-privacypolicy branch October 7, 2023 05:23
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Oct 12, 2023
* 運営者情報・プライバシーポリシーリンクを追加

* Update Changelog

* Run api extractor

* プライバシーポリシー・利用規約の同意をまとめる

* Update Changelog

* fix lint

* fix

* api extractor

* improve design

* nodeinfoにプライバシーポリシー・運営者情報を追加
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imprint and data protection general regulation
2 participants