Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2023.9.3 #11926

Merged
merged 10 commits into from
Sep 30, 2023
Merged

Release: 2023.9.3 #11926

merged 10 commits into from
Sep 30, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 29, 2023

General

  • Enhance: ノートの翻訳機能の利用可否をロールで設定可能に

Client

  • Enhance: AiScriptでホストのアドレスを参照する定数SERVER_URLを追加
  • Enhance: モデレーションログ機能の強化
  • Enhance: ローカリゼーションの更新

Server

  • Fix: Redisに古いバージョンのキャッシュが残っている場合、キャッシュが消えるまでの間通知が届かなくなる問題を修正
  • Fix: 後方互換性の修正

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5edc885) 78.93% compared to head (d0917aa) 78.92%.
Report is 30 commits behind head on master.

❗ Current head d0917aa differs from pull request most recent head 09dfb9b. Consider uploading reports for the commit 09dfb9b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11926      +/-   ##
==========================================
- Coverage   78.93%   78.92%   -0.02%     
==========================================
  Files         928      928              
  Lines       99069    99089      +20     
  Branches     7888     7882       -6     
==========================================
+ Hits        78202    78205       +3     
- Misses      20867    20884      +17     
Files Coverage Δ
packages/backend/src/core/NotificationService.ts 88.94% <100.00%> (+0.16%) ⬆️
packages/backend/src/core/RoleService.ts 75.21% <100.00%> (+0.13%) ⬆️
...ges/backend/src/core/entities/UserEntityService.ts 95.25% <100.00%> (+<0.01%) ⬆️
packages/frontend/src/const.ts 100.00% <100.00%> (ø)
packages/frontend/src/scripts/get-note-menu.ts 6.06% <0.00%> (ø)
...ackend/src/server/api/endpoints/notes/translate.ts 52.17% <57.14%> (+0.71%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo marked this pull request as ready for review September 29, 2023 23:17
@tai-cha
Copy link
Contributor

tai-cha commented Sep 29, 2023

mutingNotificationTypesを復活させたのでテストの修正が必要そう

Copy link
Contributor

@tai-cha tai-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
テストさえ通れば良さそうに見えます

@syuilo
Copy link
Member Author

syuilo commented Sep 30, 2023

ランダムに失敗したから再走

* New translations ja-jp.yml (German)

* New translations ja-jp.yml (Korean)

* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (English)

* New translations ja-jp.yml (German)

* New translations ja-jp.yml (English)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (Chinese Simplified)
@syuilo
Copy link
Member Author

syuilo commented Sep 30, 2023

これだけ入れちゃお
#11924

* add HOST_URL

* Update CHANGELOG.md

* tweak

---------

Co-authored-by: syuilo <[email protected]>
@syuilo syuilo merged commit 0e6cd57 into master Sep 30, 2023
18 checks passed
@syuilo
Copy link
Member Author

syuilo commented Sep 30, 2023

🙏🏻🙏🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants