Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 連合なしアンケートのUpdateがリモートに配信されてしまうのを修正 #11977

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Oct 7, 2023

What

連合なしアンケートに投票をするとUpdateがリモートに配信されてしまうのを修正

Why

Fix #11974

Additional info (optional)

ローカルのみ投稿が配信されなくなるのは確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e537497) 78.94% compared to head (fbdb843) 79.23%.
Report is 66 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11977      +/-   ##
===========================================
+ Coverage    78.94%   79.23%   +0.28%     
===========================================
  Files          929      932       +3     
  Lines        99193    99700     +507     
  Branches      7883     8050     +167     
===========================================
+ Hits         78312    78999     +687     
+ Misses       20881    20701     -180     
Files Coverage Δ
packages/backend/src/core/PollService.ts 56.36% <100.00%> (+0.80%) ⬆️

... and 82 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mei23 mei23 changed the title 連合なしアンケートのUpdateがリモートに配信されてしまうのを修正 fix: 連合なしアンケートのUpdateがリモートに配信されてしまうのを修正 Oct 7, 2023
@syuilo syuilo merged commit c8d7a5a into misskey-dev:develop Oct 7, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 7, 2023

🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
2 participants