Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: タイムライン更新中に広告を挿入 #11989

Merged
merged 10 commits into from
Oct 8, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 8, 2023

What

  • タイムラインのリアルタイム更新中に広告を挿入できるようになりました
  • 広告の配信頻度はコントロールパネルから設定可能
    • あまりにも短い間隔を指定したら警告が出ます
  • デフォルトは無効0

image

Why

Fix #11808

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9240db3) 79.31% compared to head (4f15782) 79.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11989      +/-   ##
===========================================
- Coverage    79.31%   79.28%   -0.03%     
===========================================
  Files          930      929       -1     
  Lines        99381    99309      -72     
  Branches      8042     8042              
===========================================
- Hits         78820    78741      -79     
- Misses       20561    20568       +7     
Files Coverage Δ
packages/backend/src/models/Meta.ts 100.00% <100.00%> (ø)
packages/frontend/src/components/MkInput.vue 100.00% <100.00%> (ø)
...ges/backend/src/server/api/endpoints/admin/meta.ts 77.56% <80.00%> (+0.02%) ⬆️
packages/backend/src/server/api/endpoints/meta.ts 74.40% <83.33%> (+0.14%) ⬆️
...kend/src/server/api/endpoints/admin/update-meta.ts 64.96% <60.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Oct 8, 2023

API Extractorがミスってるのでちょっとお待ち下さいいけた

locales/ja-JP.yml Outdated Show resolved Hide resolved
@kakkokari-gtyih
Copy link
Contributor Author

image

@kakkokari-gtyih
Copy link
Contributor Author

変な値が突っ込まれてもバグらないようになった

@syuilo syuilo merged commit 4bbfc98 into misskey-dev:develop Oct 8, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 8, 2023

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the realtime-tl-ads branch October 8, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

タイムラインがリアルタイム更新されている間にも広告を挿入する
2 participants