Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): ダイレクト投稿がタイムライン上に正常に表示されない問題を修正 #11993

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

slofp
Copy link
Contributor

@slofp slofp commented Oct 8, 2023

What

redisForTimelinesにダイレクトの投稿をpushできるようにした。(具体的には2023.9.0時点の表示方式になるようにした)

Why

fix #11991

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (457b4cf) 79.29% compared to head (400e8d7) 93.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #11993       +/-   ##
============================================
+ Coverage    79.29%   93.93%   +14.64%     
============================================
  Files          929        2      -927     
  Lines        99318      462    -98856     
  Branches      8047       59     -7988     
============================================
- Hits         78756      434    -78322     
+ Misses       20562       28    -20534     

see 927 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Oct 9, 2023

これってフォローしていない人からのDMもHTLに含まれることになる?

@syuilo
Copy link
Member

syuilo commented Oct 9, 2023

フォローしていないユーザーからのDMはHTLに含まれないでほしいからちょっと変えてる

@syuilo syuilo self-assigned this Oct 9, 2023
@syuilo syuilo merged commit ca07459 into misskey-dev:develop Oct 9, 2023
9 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 9, 2023

🙏🏻🙏🏻

@slofp
Copy link
Contributor Author

slofp commented Oct 9, 2023

お手数おかけしてすいません!
ありがとうございます🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2023.10.0-beta.7] 投稿範囲がダイレクトのノートがタイムライン上に表示されない
2 participants