Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: admin/update-meta が保存できない #12057

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

privacyPolicyUrlimpressumUrl に nullable を追加

Why

Fix #12020

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5a3c657) 79.27% compared to head (27d5f2a) 79.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12057      +/-   ##
===========================================
- Coverage    79.27%   79.19%   -0.09%     
===========================================
  Files          930      175     -755     
  Lines        99260    22823   -76437     
  Branches      8067      485    -7582     
===========================================
- Hits         78691    18074   -60617     
+ Misses       20569     4749   -15820     

see 757 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih changed the title Fix: admin/update-meta が保存できない fix: admin/update-meta が保存できない Oct 17, 2023
@syuilo syuilo merged commit 53099ca into misskey-dev:develop Oct 18, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 18, 2023

🙏🏻

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Oct 18, 2023
* Fix: invalid param impressumUrl

* Update CHANGELOG.md
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
* Fix: invalid param impressumUrl

* Update CHANGELOG.md
@kakkokari-gtyih kakkokari-gtyih deleted the impressum-fix-1018 branch December 8, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid parameters on save in Control Panel → General
2 participants