enhance(frontend): ノートのリンクをリモートのサーバーのURLとしてコピーできるように #13566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13566 +/- ##
============================================
- Coverage 40.16% 20.45% -19.71%
============================================
Files 1521 701 -820
Lines 188552 98656 -89896
Branches 3509 1025 -2484
============================================
- Hits 75735 20185 -55550
+ Misses 112246 77950 -34296
+ Partials 571 521 -50 ☔ View full report in Codecov by Sentry. |
5 tasks
KisaragiEffective
changed the title
KisaragiEffective
changed the title
…n-remote # Conflicts: # CHANGELOG.md
|
コンフリクト解消 |
|
👀 |
anatawa12
reviewed
Jul 17, 2024
| getCopyNoteLinkMenu(appearNote, i18n.ts.copyLink), | ||
| ...((appearNote.url != null || appearNote.uri != null) ? [{ | ||
| icon: 'ti ti-link', | ||
| text: `${i18n.ts.copyLink} (${i18n.ts.remote})`, |
There was a problem hiding this comment.
別のローカライズ作るのとどっちがいいだろうか
リンクをコピー(リモート)よりリモートのリンクをコピーのほうが良いと思ったけど
Sayamame-beans
pushed a commit
to Sayamame-beans/misskey
that referenced
this pull request
Dec 3, 2024
5 tasks
Ruruke
pushed a commit
to Ruruke/misskey
that referenced
this pull request
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fix #13563
Why
同上
Additional info (optional)
Checklist