enhance(mfm): $[tada ] のフォントサイズは1段階しか大きくならないように
#13757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkokari-gtyih
changed the title
$[tada ] のフォントサイズは1段階しか大きくならないように$[tada ] のフォントサイズは1段階しか大きくならないように
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13757 +/- ##
============================================
+ Coverage 64.95% 77.66% +12.70%
============================================
Files 989 183 -806
Lines 112848 25408 -87440
Branches 5770 487 -5283
============================================
- Hits 73306 19734 -53572
+ Misses 38100 5667 -32433
+ Partials 1442 7 -1435 ☔ View full report in Codecov by Sentry. |
|
ちょっとbreaking change過ぎるので一旦なしで |
|
breakingではあるものの悪用例が発生したのを確認した(io)ので再オープン cc: @u1-liquid |
syuilo
reviewed
May 18, 2024
| font-size: 150%; | ||
| } | ||
|
|
||
| .mfm-tada:has(.mfm-tada) { |
There was a problem hiding this comment.
そもそも登場頻度（このクエリに引っかかること）は高くない気がするので大丈夫かも
There was a problem hiding this comment.
ブラウザが「このクエリに引っかかるかどうか」を判定すること自体のコストが高いという話だわね
|
related? #13266 |
|
tadaのネスト回数によってはx2やx3, x4同様に畳めばいいのでは？（普通にannoyingなので） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
$[tada ]で文字サイズが大きくなるのを最初の1段階のみに変更（tadaで文字サイズがデカくなる仕様自体は利用されているケースが多いので互換性のため1段階だけは大きくするようにしてある）
Why
$[tada ]をネストして巨大な文字を作れてしまう問題を修正Additional info (optional)
Checklist