Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(misskey-js): metaの型定義をパラメータで分岐できるように #13783

Closed

Conversation

kakkokari-gtyih
Copy link
Contributor

What

misskeyApiでmetaを呼び出す際に、パラメータのdetailがtrue/falseで動的に型をスイッチできるように

Why

うれしいため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (c530a46) to head (63adaca).

❗ Current head 63adaca differs from pull request most recent head a9f9c66. Consider uploading reports for the commit a9f9c66 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13783       +/-   ##
============================================
+ Coverage    65.15%   77.88%   +12.73%     
============================================
  Files          985      185      -800     
  Lines       112122    25541    -86581     
  Branches      5742      484     -5258     
============================================
- Hits         73050    19893    -53157     
+ Misses       37638     5641    -31997     
+ Partials      1434        7     -1427     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft May 2, 2024 07:13
@kakkokari-gtyih
Copy link
Contributor Author

余計なものが入ったのでやりなおす

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant