Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 時刻のミリ秒表示ができるように #13853

Closed

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 21, 2024

What

image

Why

時報ノートに使用できる

Additional info (optional)

locale-constがロードの初期段階で読み込まれる関係で通常のstoreが使用できなかったのでlocalStorage(miLocalStorage)に直書きしている

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.68%. Comparing base (6a637db) to head (58a079b).

Files Patch % Lines
packages/frontend/src/scripts/intl-const.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13853      +/-   ##
===========================================
- Coverage    77.76%   77.68%   -0.09%     
===========================================
  Files          184      183       -1     
  Lines        25510    25383     -127     
  Branches       487      488       +1     
===========================================
- Hits         19838    19718     -120     
+ Misses        5665     5658       -7     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented May 21, 2024

要るかしら

@kakkokari-gtyih
Copy link
Contributor Author

時間ギリギリに投稿する人で競うようなアレがあるので、まああっても悪くはないかなと思うたりする

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented May 21, 2024

(どっちにしろ詳細開かないと見れない(=ステップが減るわけではない)のでプラグインでいい説はある)

@syuilo
Copy link
Member

syuilo commented May 21, 2024

需要がニッチすぎそう
ミリ秒確認できるプラグインあるしそれで事足りそう

@syuilo
Copy link
Member

syuilo commented May 21, 2024

今のところ保留で 🙏🏻

@syuilo syuilo closed this May 21, 2024
@kakkokari-gtyih kakkokari-gtyih deleted the enh-time-ms branch May 21, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants